[Bug 1020046] New: xsp build should fail but not
http://bugzilla.opensuse.org/show_bug.cgi?id=1020046 Bug ID: 1020046 Summary: xsp build should fail but not Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Mono Assignee: bnc-team-mono@forge.provo.novell.com Reporter: i@marguerite.su QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- Hi, Recently I fixed build for xsp in Leap 42.3 by backporting a patch from Tumbleweed.[1] The error message was: configure: error: missing required Mono 2.0 assembly: System.Core.dll I sent a maintenance request[2] because the mono-core's versions are all 4.x and the xsp's versions are all the same. and Andreas Stieger rejected it because he thought why we should fix build problems for successful builds. So I invested further: In the configure.ac of xsp there is a check: <pre> SHAMROCK_CHECK_MONO_2_0_GAC_ASSEMBLIES([ System.Core System.Configuration System.Data System.Web Mono.Posix Mono.Security ]) </pre> SHAMROCK_CHECK_MONO_2_0_GAC_ASSEMBLIES refers to this: <pre> AC_DEFUN([_SHAMROCK_CHECK_MONO_GAC_ASSEMBLIES], [ for asm in $(echo "$*" | cut -d, -f3- | sed 's/\,/ /g') do AC_MSG_CHECKING([for Mono $2 GAC for $asm.dll]) echo "$($PKG_CONFIG --variable=libdir $1)/mono/$2/$asm.dll" echo "$($PKG_CONFIG --variable=prefix $1)/lib/mono/$2/$asm.dll" if test \ -e "$($PKG_CONFIG --variable=libdir $1)/mono/$2/$asm.dll" -o \ -e "$($PKG_CONFIG --variable=prefix $1)/lib/mono/$2/$asm.dll"; \ then \ AC_MSG_RESULT([found]) else AC_MSG_RESULT([not found]) AC_MSG_ERROR([missing required Mono $2 assembly: $asm.dll]) fi done ]) </pre> in build/m4/shamrock/mono.m4, basically it will check the existence of these two files: /usr/lib64/mono/2.0/System.Core.dll /usr/lib/mono/2.0/System.Core.dll There are certainly no such files because there's no longer /usr/lib/mono/2.0/System.Core.dll in mono-core 4.x. So, theoretically xsp build should fail on every openSUSE release and Tumbleweed. But, the only failure I saw was on Leap 42.3. After applying two patches that certainly will not fix this, it build successfully again. In Leap 42.1/42.2 released repository without those two patches, I saw: [ 46s] checking for Mono 2.0 GAC for System.Core.dll... found [ 46s] checking for Mono 2.0 GAC for System.Configuration.dll... found [ 46s] checking for Mono 2.0 GAC for System.Data.dll... found [ 46s] checking for Mono 2.0 GAC for System.Web.dll... found [ 46s] checking for Mono 2.0 GAC for Mono.Posix.dll... found [ 46s] checking for Mono 2.0 GAC for Mono.Security.dll... found But actually they should fail, see my test: https://build.opensuse.org/package/show/home:MargueriteSu:branches:OBS_Maint... I didn't change anything actually. I didn't apply any patch, just defined some inner variables in the specfile. Theoretically it should build successfully just as it was in Leap 42.1/42.2, but it didn't. So there're two directions now: 1. Why our Build Service didn't trigger a failure when it should and it can. 2. Why xsp/mono continued the build when a must-have library was missing? Did it fallback to /usr/lib/mono/4.5/System.Core.dll? or it just bundled/rebuilt a System.Core.dll 2.0? References: 1. https://build.opensuse.org/request/show/448139 2. https://build.opensuse.org/request/show/448186 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1020046 http://bugzilla.opensuse.org/show_bug.cgi?id=1020046#c1 Marguerite Su <i@marguerite.su> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bnc-team-mono@forge.provo.n |i@marguerite.su |ovell.com | --- Comment #1 from Marguerite Su <i@marguerite.su> --- assigned to myself. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1020046 http://bugzilla.opensuse.org/show_bug.cgi?id=1020046#c2 --- Comment #2 from Marguerite Su <i@marguerite.su> --- in Leap 42.2 and Tumbleweed, there's /usr/lib/mono/{2.0-api,3.5-api,4.0,4.0-api,4.5,4.5-api}/System.Core.dll in Leap 42.1, there's /usr/lib/mono/{2.0,3.5,4.0,4.5}/System.Core.dll all these dlls were placed in mono-devel. So Leap 42.1 don't need a build fix. but 42.2 does. The problems left is: * why openSUSE Leap 42.2 standard repository builds. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1020046 http://bugzilla.opensuse.org/show_bug.cgi?id=1020046#c3 Marguerite Su <i@marguerite.su> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS --- Comment #3 from Marguerite Su <i@marguerite.su> --- I branched xsp in openSUSE:Leap:42.2, without any modification, the build failed: https://build.opensuse.org/package/live_build_log/home:MargueriteSu:branches... at exactly the same place, with the same error message: [ 65s] checking for sn... /usr/bin/sn [ 65s] checking for Mono 2.0 GAC for System.Core.dll... not found [ 65s] configure: error: missing required Mono 2.0 assembly: System.Core.dll [ 65s] error: Bad exit status from /var/tmp/rpm-tmp.aFO7Kb (%build) So the original build is an unpredictable success. we will not know its behavior. I guess it is because the repository of release product will not trigger automatically rebuild, while it should. mono-core was 4.0.x so xsp builds, after mono-core was updated to 4.6.x, xsp didn't get rebuilt. it still requires mono-core 4.0.x instead of 4.6.x. It is an issue known for long. But it is enough for me to send an update stack. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1020046 http://bugzilla.opensuse.org/show_bug.cgi?id=1020046#c4 Marguerite Su <i@marguerite.su> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #4 from Marguerite Su <i@marguerite.su> --- fixed: https://build.opensuse.org/request/show/450520 -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com