[Bug 335573] New: kiwi should log all commands it executes
https://bugzilla.novell.com/show_bug.cgi?id=335573 Summary: kiwi should log all commands it executes Product: openSUSE.org Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Enhancement Priority: P5 - None Component: System Imaging AssignedTo: ms@novell.com ReportedBy: cthiel@novell.com QAContact: adrian@novell.com Found By: --- Kiwi should really log what commands it executes into its logs, so reproduce a problem becomes more easier. Maybe a stepped / debugging mode, where you can step through all the commands it uses, would be helpful to debug. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573 Marcus Schaefer <ms@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|kiwi should log all commands it executes |kiwi: should log all commands it executes -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573#c1 Marcus Schaefer <ms@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |cthiel@novell.com --- Comment #1 from Marcus Schaefer <ms@novell.com> 2007-10-26 09:41:21 MST --- kiwi calls many many commands how do you think it's useful to log them all ? In case of an error all output will be printed to the console and is part of the log file as well. As many commands are called within a chroot environment it's also not very useful to have the command logged because in many cases you can't recall it easily So please be more precisely. What exactly do you miss ? Thanks -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573#c2 Christoph Thiel <cthiel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|cthiel@novell.com | --- Comment #2 from Christoph Thiel <cthiel@novell.com> 2007-10-27 04:26:03 MST --- For debugging purposes it would be very helpful it the logs contained the commands kiwi actually executed. I don't really want to dig into the kiwi code, every time I run into a problem. This could have saved me a lot of time! Make it a debugging option and wrap all exec calls into a function that either puts the actual command into the log or not. You might even want to log the commands into a seperate logfile, which could be used to reproduce bugs... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573#c3 --- Comment #3 from Marcus Schaefer <ms@novell.com> 2007-11-13 08:45:28 MST --- I would like to implement this like the following code illustrates BEGIN { print "using my qx...\n"; *CORE::GLOBAL::readpipe = sub($) { print "faked\n"; }; } $a = qx (echo hello world); print $a; BUT: the override of readpipe is allowed with perl version 5.9.* for the first time: http://search.cpan.org/~rgarcia/perl/pod/perl595delta.pod#readpipe()_is_now_... For now I don't know another way to fake the qx operator in order to allow what you want. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573#c4 Marcus Schaefer <ms@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |cthiel@novell.com --- Comment #4 from Marcus Schaefer <ms@novell.com> 2007-11-13 09:47:29 MST --- Christoph please read my last comment and tell me what you think. Could we skip this one until 5.9.* ? Thanks -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573#c5 Michael Schröder <mls@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mls@novell.com --- Comment #5 from Michael Schröder <mls@novell.com> 2007-11-14 02:07:32 MST --- (You can solve this by defining a 'myqx' function and use that in your code instead of qx// and ``. Not as elegant as redefining qx, though) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573#c6 Marcus Schaefer <ms@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|cthiel@novell.com | --- Comment #6 from Marcus Schaefer <ms@novell.com> 2007-11-14 06:30:59 MST --- Hmm but this would cause many code changes not only in the function name but in the parameter list too. If I write sub myqx { qx /$_[0]/; } I can call myqx ("echo hello 1>&2"); but with standard qx I can write qx (echo hello 1>&2); That's because qx or `` are operators and myqx would be a function so changing this that way is not what I would like to do. I'm sorry -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573#c7 Christoph Thiel <cthiel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |mls@novell.com --- Comment #7 from Christoph Thiel <cthiel@novell.com> 2007-11-15 09:48:40 MST --- Micha? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573#c8 Michael Schröder <mls@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Info Provider|mls@novell.com |cthiel@novell.com --- Comment #8 from Michael Schröder <mls@novell.com> 2007-11-15 10:12:54 MST --- Yes? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573#c9 Christoph Thiel <cthiel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Info Provider|cthiel@novell.com |mls@novell.com --- Comment #9 from Christoph Thiel <cthiel@novell.com> 2007-11-19 07:53:12 MST --- Sorry, I don't really have any strong opinion on the implementation details. Micha, do you have any suggestion on how to get this done? What would waiting fro Perl 5.9.* mean? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573#c10 Michael Schröder <mls@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Info Provider|mls@novell.com |cthiel@novell.com --- Comment #10 from Michael Schröder <mls@novell.com> 2007-11-19 08:15:22 MST --- This would mean SL 11.0 and no chance for SLES10. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573#c11 Christoph Thiel <cthiel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|cthiel@novell.com | --- Comment #11 from Christoph Thiel <cthiel@novell.com> 2007-11-19 09:51:17 MST --- Marcus, would you mind going down a path that would work for all released versions? IMO this would greatly improve the "debugability" of kiwi. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573#c12 --- Comment #12 from Marcus Schaefer <ms@novell.com> 2007-11-20 02:06:34 MST --- I'm sorry I will not change any occurrences of an exec operator by a function. This will be implemented with SL11.0 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573 Marcus Schaefer <ms@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=335573 User ms@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=335573#c13 Marcus Schaefer <ms@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #13 from Marcus Schaefer <ms@novell.com> 2008-01-17 03:17:56 MST --- fixed in v2.11. As overriding readpipe still has problems if you pass along with the command variables which needs evaluation first I decided to provide a generic qxx method in a KIWIQX module. All qx calls except the ones from KIWILog (date and stty) are now part of the logfile -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com