[Bug 719382] New: Check Image Conversion Result (Missing picture of US Keyboard Layout)
https://bugzilla.novell.com/show_bug.cgi?id=719382 https://bugzilla.novell.com/show_bug.cgi?id=719382#c0 Summary: Check Image Conversion Result (Missing picture of US Keyboard Layout) Classification: openSUSE Product: openSUSE 12.1 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Enhancement Priority: P5 - None Component: Development AssignedTo: fs@suse.com ReportedBy: ke@suse.com QAContact: qa@suse.de CC: fs@suse.com, giecrilj@stegny.2a.pl Depends on: 718743 Found By: Documentation Blocker: --- +++ This bug was initially created as a clone of Bug #718743 +++ The picture of US Keyboard Layout, as advertised in the Troubleshooting manual, is missing from the installed documentation. [...] ============================================================================= ke: "Because of a misssing dependency, the SVG to PNG transformation failed in the BS." ============================================================================= To avoid such trouble in the future, we must check whether the image conversion succeeded. If not, I'd recommend to stop immediately. Maybe, it would be sufficient to add "|| false" to the inkscape commands. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=719382 https://bugzilla.novell.com/show_bug.cgi?id=719382#c1 Frank Sundermeyer <fs@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |WONTFIX --- Comment #1 from Frank Sundermeyer <fs@suse.com> 2012-01-26 16:21:52 UTC --- make always exists with an error if a program exits abnormally. The problem lies with inscape not returning a proper exit code: fs@neo:~/tmp> inkscape -z -w 800 -e foo -f bar ** (inkscape:23998): CRITICAL **: Inkscape::XML::Document* sp_repr_read_file(const gchar*, const gchar*): assertion `Inkscape::IO::file_test( filename, G_FILE_TEST_EXISTS )' failed ** (inkscape:23998): CRITICAL **: Inkscape::XML::Document* sp_repr_read_file(const gchar*, const gchar*): assertion `Inkscape::IO::file_test( filename, G_FILE_TEST_EXISTS )' failed ** (inkscape:23998): WARNING **: Specified document bar cannot be opened (does not exist or not a valid SVG file) fs@neo:~/tmp> echo $? 0 I am not going to parse this output, inkscape has to behave properly. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=719382 https://bugzilla.novell.com/show_bug.cgi?id=719382#c2 --- Comment #2 from Christopher Yeleighton <giecrilj@stegny.2a.pl> 2012-01-26 19:02:52 UTC --- While I admit it is very honorable to get so offended by Inkscape so as to kill the issue altogether, I suppose it would be sufficient to make an elementary test that the intended result exists and has a chance of being correct (e.g. using file). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=719382 https://bugzilla.novell.com/show_bug.cgi?id=719382#c3 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Blocks| |718743 Depends on|718743 | Resolution|WONTFIX | --- Comment #3 from Karl Eichwalder <ke@suse.com> 2012-01-27 10:09:31 CET --- (In reply to comment #2)
While I admit it is very honorable to get so offended by Inkscape so as to kill the issue altogether, I suppose it would be sufficient to make an elementary test that the intended result exists and has a chance of being correct (e.g. using file).
Yes, I was just about to propose the same as an intermediate workaround. I think it would be sufficient to add: inkscape -z -w 800 -e foo -f bar && [ -r bar ] || { echo bar does not exist; exit 1 ; } Or check before calling inkscape or, better, after you searched the XML files for the graphics. We were bitten by this more then once... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=719382 https://bugzilla.novell.com/show_bug.cgi?id=719382#c Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |743745 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=719382 https://bugzilla.novell.com/show_bug.cgi?id=719382#c4 --- Comment #4 from Frank Sundermeyer <fs@suse.com> 2012-03-23 14:59:20 UTC --- OK, ok. Added foo: bar inkscape ... && ( test -f $< || false ) to make/images.mk in DAPS as a workaround However, cannot close it, because of bnc #743745. Karl, I think that bug should rather be reported upstream ... . -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=719382 https://bugzilla.novell.com/show_bug.cgi?id=719382#c5 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|743745 | --- Comment #5 from Karl Eichwalder <ke@suse.com> 2012-03-26 10:01:20 CEST --- Yes, it is an upstream bug. Because you now implemented a workaround in make, we can remove the blocking bug here (done). Bash sub-shells are often dangerous. I hope the exit code will get propagated properly. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=719382 https://bugzilla.novell.com/show_bug.cgi?id=719382#c6 Frank Sundermeyer <fs@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |CLOSED Resolution| |FIXED --- Comment #6 from Frank Sundermeyer <fs@suse.com> 2012-03-26 10:40:05 UTC --- Sure. fs@pythagoras:~ > true && ( test -f non_existing_file || false ) fs@pythagoras:~ > echo $? 1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com