[Bug 219732] New: x11 / Mesa uses && instead of & sometimes
https://bugzilla.novell.com/show_bug.cgi?id=219732 Summary: x11 / Mesa uses && instead of & sometimes Product: openSUSE 10.2 Version: Beta 2 Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: X.Org AssignedTo: sndirsch@novell.com ReportedBy: meissner@novell.com QAContact: sndirsch@novell.com CC: mhopf@novell.com, dreveman@novell.com xm_spam and XKBui.c is confusing && with & ... in all copies. My grep found: /NX/nx-X11-1.5.0-21.tar.gz.contents/nx-X11/lib/xkbui/XKBui.c: (sdef.blue>>8)&&0xff); /NX/nx-X11-1.5.0-21.tar.gz.contents/nx-X11/extras/Mesa/src/X/xm_span.c: pixel = *ptr4 && 0xffff0000; /NX/nx-X11-1.5.0-21.tar.gz.contents/nx-X11/extras/Mesa/src/X/xm_span.c: pixel = *ptr4 && 0xffffff00; /NX/nx-X11-1.5.0-21.tar.gz.contents/nx-X11/extras/Mesa/src/X/xm_span.c: pixel = *ptr4 && 0xffff0000; /NX/nx-X11-1.5.0-21.tar.gz.contents/nx-X11/extras/Mesa/src/X/xm_span.c: pixel = *ptr4 && 0xffffff00; /NX/nx-X11-1.5.0-21.tar.gz.contents/nx-X11/programs/Xserver/hw/xfree86/drivers/nv/riva_hw.c: if((pNv->Chipset && 0xffff) == 0x01a0) { /xgl/Mesa-CVS-20060512.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffff0000; /xgl/Mesa-CVS-20060512.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffffff00; /xgl/Mesa-CVS-20060512.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffff0000; /xgl/Mesa-CVS-20060512.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffffff00; /BASE/xorg-x11-libs/libxkbui-X11R7.1-1.0.2.tar.bz2.contents/libxkbui-X11R7.1-1.0.2/src/XKBui.c: (sdef.blue>>8)&&0xff); /BASE/xorg-x11-server/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffff0000; /BASE/xorg-x11-server/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffffff00; /BASE/xorg-x11-server/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffff0000; /BASE/xorg-x11-server/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffffff00; /Mesa/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffff0000; /Mesa/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffffff00; /Mesa/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffff0000; /Mesa/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffffff00; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219732 ------- Comment #1 from meissner@novell.com 2006-11-10 02:47 MST ------- and 1 instance of || where it should probably be | in NX: all/NX/nx-X11-1.5.0-21.tar.gz.contents/nx-X11/programs/Xserver/hw/xfree86/drivers/sis/init.c: SR19 = (SR19)||0x01; /* TW: ??? || ??? */ -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219732 sndirsch@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Priority|P5 - None |P2 - High -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219732 ------- Comment #2 from sndirsch@novell.com 2006-11-10 06:50 MST -------
./NX/nx-X11-1.5.0-21.tar.gz.contents/nx-X11/lib/xkbui/XKBui.c Not used for building (no libxkbui built).
./NX/nx-X11-1.5.0-21.tar.gz.contents/nx-X11/extras/Mesa/src/X/xm_span.c Not used for building (Mesa is not part of the build).
./NX/nx-X11-1.5.0-21.tar.gz.contents/nx-X11/programs/Xserver/hw/xfree86/drivers/nv/riva_hw.c Not used for building (no video drivers in NX package).
./BASE/xorg-x11-libs/libxkbui-X11R7.1-1.0.2.tar.bz2.contents/libxkbui-X11R7.1-1.0.2/src/XKBui.c: Will fix this issue.
./BASE/xorg-x11-server/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c Not used for building (Mesa is required for building the Xserver, but not builded itself).
./Mesa/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c Will fix this issue.
David needs to comment on the xgl issues. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219732 ------- Comment #3 from sndirsch@novell.com 2006-11-10 06:52 MST ------- (In reply to comment #1)
and 1 instance of || where it should probably be | in NX: all/NX/nx-X11-1.5.0-21.tar.gz.contents/nx-X11/programs/Xserver/hw/xfree86/drivers/sis/init.c: SR19 = (SR19)||0x01; /* TW: ??? || ??? */ video drivers are not part of NX package.
-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219732 ------- Comment #4 from sndirsch@novell.com 2006-11-10 06:53 MST ------- Remaining stuff: /BASE/xorg-x11-libs/libxkbui-X11R7.1-1.0.2.tar.bz2.contents/libxkbui-X11R7.1-1.0.2/src/XKBui.c: (sdef.blue>>8)&&0xff); /Mesa/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffff0000; /Mesa/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffffff00; /Mesa/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffff0000; /Mesa/Mesa-6.5.1.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffffff00; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219732 sndirsch@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|sndirsch@novell.com |dreveman@novell.com Status|ASSIGNED |NEW ------- Comment #5 from sndirsch@novell.com 2006-11-10 07:09 MST ------- xorg-x11-libs and Mesa fixed. Reassigning to David. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219732 ------- Comment #6 from sndirsch@novell.com 2006-11-26 06:27 MST ------- David, you can probably use the same patch I created for Mesa (typos.diff). /xgl/Mesa-CVS-20060512.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffff0000; /xgl/Mesa-CVS-20060512.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffffff00; /xgl/Mesa-CVS-20060512.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffff0000; /xgl/Mesa-CVS-20060512.tar.bz2.contents/Mesa/src/mesa/drivers/x11/xm_span.c: pixel = *ptr4 && 0xffffff00; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=219732 sndirsch@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #7 from sndirsch@novell.com 2006-12-21 11:15 MST ------- finally fixed for openSUSE 10.3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply＠novell.com