[Bug 569271] New: upstream or drop ancient pidgin patches
http://bugzilla.novell.com/show_bug.cgi?id=569271 http://bugzilla.novell.com/show_bug.cgi?id=569271#c0 Summary: upstream or drop ancient pidgin patches Classification: openSUSE Product: openSUSE 11.3 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: GNOME AssignedTo: bnc-team-gnome@forge.provo.novell.com ReportedBy: sbrabec@novell.com QAContact: qa@suse.de CC: lnussel@novell.com, jpr@novell.com, jimmac@novell.com, hpj@novell.com, vuntz@novell.com Found By: --- Blocker: --- Here is an exhausting list of pidgin stuff that was not upstreamed. That stuff should be upstreamed or dropped. pidgin-gnome-keyring.patch: Were introduced to gaim by: Mon Nov 28 09:42:06 CET 2005 - hpj@suse.de ..- Added patch to use the GNOME keyring for passwords. Related: bug 566286, bug 553272 and bug 522361. pidgin-nonblock-*: Were introduced to gaim by: Thu Oct 6 16:09:24 CEST 2005 - gekker@suse.de - Make aim and gwim asynchronous, patches from HPJ pidgin-dbus-invalid-gpointer.patch was apparently a fix. My fault. Mon Mar 3 13:30:23 CET 2008 - sbrabec@suse.cz - Update to version 2.4.0:... pidgin-browser-default.patch: My patch, customization, must stay downstream. pidgin-directconn-argfix.patch: Look like a fix. Tue Nov 13 21:29:06 CET 2007 - maw@suse.de - Add pidgin-directconn-argfix.patch. pidgin-bnc550170-qq-2008only.patch: My new fix. - If QQ migration will not happen in pidgin-2.6.5, I'll report it upstream. includes.patch: Was apparently a fix: Tue Jul 24 00:17:19 CEST 2007 - maw@suse.de - Add includes.patch, fixing the build when new versions of evolution-data-server are installed. pidgin-NLD-smiley-theme pidgin-Tango-smiley-theme: Ancient and newer skin. May be interesting for upstream. Jakub, what do you think about them? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=569271 http://bugzilla.novell.com/show_bug.cgi?id=569271#c1 --- Comment #1 from Jakub Steiner <jimmac@novell.com> 2010-01-08 21:20:51 UTC --- The default upstream emote theme is following the tango guidelines and is a decent default, I think we can drop our custom themes. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=569271 http://bugzilla.novell.com/show_bug.cgi?id=569271#c2 --- Comment #2 from Vincent Untz <vuntz@novell.com> 2010-06-03 17:24:45 UTC --- Stanislav: any progress on this? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=569271 http://bugzilla.novell.com/show_bug.cgi?id=569271#c3 Dominique Leuenberger <dimstar@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dimstar@opensuse.org Component|GNOME |GNOME Product|openSUSE 11.3 |openSUSE 11.4 --- Comment #3 from Dominique Leuenberger <dimstar@opensuse.org> 2010-08-16 10:53:46 UTC --- Moving to 11.4 Current list of patches in the pidgin package (what is left after updating to 2.7.3 in my branch):
includes.patch pidgin-bnc550170-qq-2008only.patch pidgin-browser-default.patch pidgin-dbus-invalid-gpointer.patch pidgin-gnome-keyring.patch pidgin-nonblock-aim.patch pidgin-nonblock-common2.patch pidgin-nonblock-common.patch pidgin-nonblock-gwim.patch
-- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=569271 http://bugzilla.novell.com/show_bug.cgi?id=569271#c4 Stanislav Brabec <sbrabec@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |hpj@novell.com --- Comment #4 from Stanislav Brabec <sbrabec@novell.com> 2010-08-16 15:00:12 CEST --- Regarding my patches: pidgin-browser-default.patch: Submitting as http://developer.pidgin.im/ticket/12505 pidgin-bnc550170-qq-2008only.patch: It is a hack that forced all users to migrate to QQ2008 whenever they enter into preferences. I never tried to upstream it, as I don't use QQ and I don't know any details. Feel free to drop the patch. I think that all people already miograted. pidgin-dbus-invalid-gpointer.patch includes.patch look like apparent compilation warning fixes. We should check whether they are still needed. If not, we can drop it, otherwise upstream them. All other patches: Maybe HPJ can answer or try to describe its usefullness to the upstream: http://developer.pidgin.im/newticket -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=569271 http://bugzilla.novell.com/show_bug.cgi?id=569271#c5 --- Comment #5 from Dominique Leuenberger <dimstar@opensuse.org> 2010-08-16 14:08:36 UTC --- pidgin-bnc550170-qq-2008only.patch => dropped in my branch pidgin-dbus-invalid-gpointer.patch => seems still valid. I will upstream it includes.patch => not sure (yet) if really needed. Will check -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=569271 http://bugzilla.novell.com/show_bug.cgi?id=569271#c6 --- Comment #6 from Dominique Leuenberger <dimstar@opensuse.org> 2010-08-16 14:18:09 UTC --- includes.patch can be dropped for sure => the code change is within an #if 0 [...] #endif statement. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=569271 http://bugzilla.novell.com/show_bug.cgi?id=569271#c7 --- Comment #7 from Dominique Leuenberger <dimstar@opensuse.org> 2010-08-16 15:58:11 UTC --- pidgin-dbus-invalid-gpointer.patch submitted as http://developer.pidgin.im/ticket/12507 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=569271 http://bugzilla.novell.com/show_bug.cgi?id=569271#c8 --- Comment #8 from Dominique Leuenberger <dimstar@opensuse.org> 2010-08-16 16:10:49 UTC --- Which leaves those rest to be checked:
pidgin-gnome-keyring.patch => is disabled on any non SLE platform.. I could not care less :) I'm not even sure it applies.
pidgin-nonblock-aim.patch ==> is currently disabled in the build ; has been marked as NEEDS REBASE since January 2009. As per .changes text, it was probably earlier disabled.
pidgin-nonblock-common2.patch pidgin-nonblock-common.patch pidgin-nonblock-gwim.patch
-- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=569271 http://bugzilla.novell.com/show_bug.cgi?id=569271#c9 --- Comment #9 from Stanislav Brabec <sbrabec@novell.com> 2010-08-16 18:27:15 CEST --- Well, disabling pidgin-gnome-keyring.patch in openSUSE was a consensus in bug 566286. openSUSE: pidgin does not depend on gnome-keyring unlocking (i. e. no extra keyring unlock dialog in non-GNOME sessions). SLED: Use gnome-keyring to keep passwords more safe. It is surely not an optimal solution. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=569271 https://bugzilla.novell.com/show_bug.cgi?id=569271#c10 Hans Petter Jansson <hpj@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|hpj@novell.com | --- Comment #10 from Hans Petter Jansson <hpj@novell.com> 2010-11-28 02:15:09 CET --- I agree with Stanislav is comment #9: Leave gnome-keyring on in SLED, if that is the consensus. The nonblock patches that no longer apply can be dropped. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=569271 https://bugzilla.novell.com/show_bug.cgi?id=569271#c11 Bjørn Lie <bjorn.lie@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.lie@gmail.com --- Comment #11 from Bjørn Lie <bjorn.lie@gmail.com> 2011-02-21 18:18:18 UTC --- (changed during the 2011-02-20 Open-Bugs-Day about bugs for obsolete versions of openSUSE)+1 So is this bug ready for closing? I see that new patches have been added, so in a sense I guess this bug can remain open for eternity ;-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=569271 https://bugzilla.novell.com/show_bug.cgi?id=569271#c12 Dominique Leuenberger <dimstar@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #12 from Dominique Leuenberger <dimstar@opensuse.org> 2012-07-21 17:35:18 UTC --- Lots of patches are gone and the remaining ones are probably safe to stay, so I think it's about time to close this bug (which should not mean we should stop upstreaming patches) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com