[Bug 1131024] YaST:Head/yast2: Bug
http://bugzilla.suse.com/show_bug.cgi?id=1131024 http://bugzilla.suse.com/show_bug.cgi?id=1131024#c3 --- Comment #3 from Ancor Gonzalez Sosa <ancor@suse.com> --- (In reply to Ladislav Slezák from comment #2)
If that package is needed by xorg-x11-Xvnc-novnc then it should be Required (either by xorg-x11-Xvnc-novnc or by python-websockify), i.e. not an YaST bug.
If the dependency is really optional (there are use cases which work without that package) then we should add it to the package list in YaST. (https://github.com/yast/yast-network/blob/ d7ce4f96be1314fb93e4cfd4e6659e9ee08b3cc6/src/lib/y2remote/modes/web.rb#L13)
The problem here is that the recommends already look tricky (well, not fully straightforward) in the definition of the package: %if 0%{?suse_version} # SLES 12 and up to 15SP1 doesn't have python-jwcrypto package and will # fallback to the PyJWT implementation. # However opensuse has jwcrypto since 42.3: use this one since it also # provides support for JWE (encrypted JWT). %if 0%{?sle_version} Recommends: python-PyJWT Recommends: python-cryptography %else Recommends: python-jwcrypto %endif Duplicating that logic also in the Ruby code smells bad to me. But if you believe that using the recommends flag is dangerous, I guess we have no other option than duplicating that. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com