[Bug 440127] New: libgdiplus0-2.0-11.18: broken code
https://bugzilla.novell.com/show_bug.cgi?id=440127 Summary: libgdiplus0-2.0-11.18: broken code Product: openSUSE 11.1 Version: Factory Platform: All OS/Version: openSUSE 11.0 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just tried to build the Suse Linux package libgdiplus0-2.0-11.18 and the compiler said region-bitmap.c:359: warning: operation on 'pos' may be undefined region-bitmap.c:359: warning: operation on 'pos' may be undefined region-bitmap.c:359: warning: operation on 'pos' may be undefined The source code is BYTE combine = source [pos++] | source [pos++] | source [pos++] | source [pos]; I agree with the compiler. The order of evaluation isn't left to right. Suggest code rework. Maybe BYTE combine = source [ pos] | source [ pos + 1] | source [ pos + 2] | source [pos + 3]; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440127 Cyril Hrubis <chrubis@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.provo.novell.com |bnc-team-mono@forge.provo.novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440127 Sebastien Pouliot <spouliot@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spouliot@novell.com AssignedTo|bnc-team-mono@forge.provo.novell.com |spouliot@novell.com Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440127 User spouliot@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440127#c1 Sebastien Pouliot <spouliot@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ajorgensen@novell.com Status|ASSIGNED |NEEDINFO Info Provider| |ajorgensen@novell.com --- Comment #1 from Sebastien Pouliot <spouliot@novell.com> 2008-10-30 11:36:16 MDT --- Nice to know newer gcc catch this (mine does not obviously) and it would be possible to skip a (color) channel if the order to not left to right. This is fixed in libgdiplus HEAD (r117493). Andrew, you want this 2-0 branch to be able to update 11.1 ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440127 User ajorgensen@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440127#c2 Andrew Jorgensen <ajorgensen@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|ajorgensen@novell.com | --- Comment #2 from Andrew Jorgensen <ajorgensen@novell.com> 2008-10-30 11:40:24 MDT --- I see no reason not to backport it to branch so it will be available if we release a 2.0.2. But unless this is likely to cause problems for many users I will just check in the patch to 11.1. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440127 User spouliot@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440127#c3 --- Comment #3 from Sebastien Pouliot <spouliot@novell.com> 2008-10-30 11:52:08 MDT --- Committed to 2-0 branch (r117495). This is unlikely to cause any problem, it's old (long tested) code and the issue does not involve reading outside allocated memory (just twice the same byte and missing one). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=440127 User dcb314@hotmail.com added comment https://bugzilla.novell.com/show_bug.cgi?id=440127#c4 --- Comment #4 from David Binderman <dcb314@hotmail.com> 2009-03-03 03:32:14 MST --- (In reply to comment #3)
Committed to 2-0 branch (r117495).
I just checked version 2.0-11.62 and the code is still broken. Would you like to try again ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com