[Bug 232593] New: With fingerprint reader, kdesu prompts twice
https://bugzilla.novell.com/show_bug.cgi?id=232593 Summary: With fingerprint reader, kdesu prompts twice Product: openSUSE 10.2 Version: Final Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: KDE AssignedTo: kde-maintainers@suse.de ReportedBy: ammulder@chariotsolutions.com QAContact: qa@suse.de I'm using a ThinkPad with a fingerprint reader. When the fingerprint reader is enabled (via a proprietary driver plus various PAM configuration), it works pretty well. The main issue is that kdesu requires two finger swipes every time it prompts you. The first swipe succeeds, and then I get a second, separate prompt, which must also succeed in order for the process to go through. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=232593 ------- Comment #1 from ammulder@chariotsolutions.com 2007-01-08 11:07 MST ------- For what it's worth, someone gave me a modified kdesu.cpp which did seem to resolve the problem (with the patched kdesu it only prompts for one finger swipe); I'm trying to get a specific patch to post. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=232593 dmueller@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |ammulder@chariotsolutions.com ------- Comment #2 from dmueller@novell.com 2007-01-09 06:45 MST ------- thanks, waiting for the patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=232593 ammulder@chariotsolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|ammulder@chariotsolutions.co| |m | ------- Comment #3 from ammulder@chariotsolutions.com 2007-01-09 09:04 MST ------- OK, after looking into it more, it seems like the patch may not be generally applicable. Looking at kdesu.cpp (for example, from http://websvn.kde.org/branches/KDE/3.5/kdebase/kdesu/kdesu/kdesu.cpp?rev=529044&view=log), the patch comments out lines 336-387, which is the part that collects a password if necessary. I'm assuming that block of code is responsible for one of the prompts, and I'm not sure what causes the other prompt. If I had to guess, I'd say that kdesu first (starting on line 338 or so) tries to decide whether there's a cached password, and if not, prompts for one. In the case of a fingerprint reader, this causes one prompt. Then, on line 401 or 422, it executes the action in question (using the now-collected or cached password), which with the fingerprint reader causes another prompt (I guess since there's still no password). So the patch skips the password-collection step since with the fingerprint reader it's not going to collect a password anyway. I'm not sure what a better patch would be. Maybe this preliminary password-collection logic really is redundant (if the execution on lines 401 or 422 is going to collect the password if it's not provided anyway), or maybe there's some way to inspect the PAM configuration and determine if bioapi is enabled... I'm not really sure. I can certainly help test if anyone can come up with a better fix for this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=232593 dmueller@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=232593 ------- Comment #4 from ammulder@chariotsolutions.com 2007-04-18 10:37 MST ------- I just wanted to add that there's now an open source driver for the fingerprint reader (http://thinkfinger.sourceforge.net/). At present I'm still using the binary driver because it's all set up and working, but I'll be happy to test with either one if you think you have a fix for 10.2 or 10.3. Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=232593 Dirk Mueller <dmueller@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kde-maintainers@suse.de |dmueller@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=232593 Dirk Mueller <dmueller@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com