[Bug 1139948] New: LVM LV cannot be used as Bcache cache device (and possibly backing device)
http://bugzilla.suse.com/show_bug.cgi?id=1139948 Bug ID: 1139948 Summary: LVM LV cannot be used as Bcache cache device (and possibly backing device) Classification: openSUSE Product: openSUSE Distribution Version: Leap 15.1 Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: YaST2 Assignee: yast2-maintainers@suse.de Reporter: ancor@suse.com QA Contact: jsrain@suse.com CC: ancor@suse.com, luizluca@tre-sc.jus.br, snwint@suse.com Depends on: 1139783 Found By: --- Blocker: --- +++ This bug was initially created as a clone of Bug #1139783 +++ I decided to keep the original one to track the AutoYaST issue (which ignores an LV been used as part of a bcache setup) and create this clone to track the problems with bcache triggered by using the Expert Partitioner. Using such tool, the user can use LVM LV for bcache. It accepts nicely until it actually do partitioning. It tries to run: # /usr/sbin/bcache set-cachemode /dev/system-slow/home-back writethrough Error:Wrong device name found While this one works: # /usr/sbin/bcache set-cachemode $(readlink -f /dev/system-slow/home-back) writethrough It accepts /dev/dm-* but not /dev/system-slow/home-back. The same goes with "bcache attach" that does not follow symlinks. After installation finish, it works as expected. The only caveat (probably related) is that systemd waits until it times out for a resume= device (kernel cmdline resume=/dev/disk/by-id/ata-VBOX_HARDDISK_VB4e22b7b1-3df6870d-part3) while my disks have 2 partitions or less and swap is a LVM LV at /dev/system/swap. Fixing that at /etc/default/grub and updating grub.cfg fixes the problem. In summary (for this particular bug report): 1) Since the bcache tools seem to not follow symlinks, libstorage-ng should follow call them with the proper file name (or with any flag that makes the tools follow the symlinks). 2) yast2-bootloader should not write the wrong (non-existing) device into /etc/default/grub:GRUB_CMDLINE_LINUX_DEFAULT -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 Ancor Gonzalez Sosa <ancor@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|LVM LV cannot be used as |Problems using an LVM LV to |Bcache cache device (and |create a bcache device |possibly backing device) | -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 Ancor Gonzalez Sosa <ancor@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED URL| |https://trello.com/c/2UEz8I | |0J Assignee|yast2-maintainers@suse.de |yast-internal@suse.de -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 Arvin Schnell <aschnell@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aschnell@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c1 --- Comment #1 from Arvin Schnell <aschnell@suse.com> --- (In reply to Ancor Gonzalez Sosa from comment #0)
1) Since the bcache tools seem to not follow symlinks, libstorage-ng should follow call them with the proper file name (or with any flag that makes the tools follow the symlinks).
From my point of view it is a bug in bcache to not follow symlinks.
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c2 Ancor Gonzalez Sosa <ancor@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colyli@suse.com Flags| |needinfo?(colyli@suse.com) --- Comment #2 from Ancor Gonzalez Sosa <ancor@suse.com> --- (In reply to Arvin Schnell from comment #1)
(In reply to Ancor Gonzalez Sosa from comment #0)
1) Since the bcache tools seem to not follow symlinks, libstorage-ng should follow call them with the proper file name (or with any flag that makes the tools follow the symlinks).
From my point of view it is a bug in bcache to not follow symlinks.
Coly, what's your point of view as bcache maintainer? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c3 --- Comment #3 from Ancor Gonzalez Sosa <ancor@suse.com> --- Coly, ping... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c4 Coly Li <colyli@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|yast-internal@suse.de |colyli@suse.com Flags|needinfo?(colyli@suse.com) | --- Comment #4 from Coly Li <colyli@suse.com> --- (In reply to Ancor Gonzalez Sosa from comment #3)
Coly, ping...
My new email service does not forward bugzilla messages to suse.de account. Just realize the problem. Sure I start to handle this problem. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c5 --- Comment #5 from Coly Li <colyli@suse.com> --- (In reply to Coly Li from comment #4)
(In reply to Ancor Gonzalez Sosa from comment #3)
Coly, ping...
My new email service does not forward bugzilla messages to suse.de account. Just realize the problem. Sure I start to handle this problem.
Shaoxiong Li <dahefanteng@gmail.com>, a bcache-tool developer is interested to fix the problem. Now the fix is in processing. I will update the status once any progress is made. Thanks. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c6 --- Comment #6 from Coly Li <colyli@suse.com> --- Shaoxiong Li composes a patch for this problem, https://github.com/dahefanteng/bcache-tools/commit/5cb9e78ac083a3e6f608622c2... So far the test looks working, can anybody else help to confirm whether the problem is fixed by this patch ? Then I can be more confident to merge this patch and have them in 15.1. Thanks in advance. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 Bug 1139948 depends on bug 1139783, which changed state. Bug 1139783 Summary: LVM LV cannot be used as Bcache cache device (and possibly backing device) http://bugzilla.suse.com/show_bug.cgi?id=1139783 What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c7 --- Comment #7 from Coly Li <colyli@suse.com> --- (In reply to Coly Li from comment #6)
Shaoxiong Li composes a patch for this problem, https://github.com/dahefanteng/bcache-tools/commit/ 5cb9e78ac083a3e6f608622c29c95971640872cc
So far the test looks working, can anybody else help to confirm whether the problem is fixed by this patch ? Then I can be more confident to merge this patch and have them in 15.1.
The patch is OK but the commit log should be improved. Once the patch merged into upstream bcache-tools, I will take it. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c8 --- Comment #8 from Coly Li <colyli@suse.com> --- (In reply to Coly Li from comment #7)
(In reply to Coly Li from comment #6)
Shaoxiong Li composes a patch for this problem, https://github.com/dahefanteng/bcache-tools/commit/ 5cb9e78ac083a3e6f608622c29c95971640872cc
So far the test looks working, can anybody else help to confirm whether the problem is fixed by this patch ? Then I can be more confident to merge this patch and have them in 15.1.
The patch is OK but the commit log should be improved. Once the patch merged into upstream bcache-tools, I will take it.
I just notice package bcache-tools-1.1.0 is in Tumbleweed already, which includes the fix to follow symbolink. Hmm, should we close this report ? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c9 Ancor Gonzalez Sosa <ancor@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(colyli@suse.com) --- Comment #9 from Ancor Gonzalez Sosa <ancor@suse.com> --- (In reply to Coly Li from comment #8)
(In reply to Coly Li from comment #7)
The patch is OK but the commit log should be improved. Once the patch merged into upstream bcache-tools, I will take it.
I just notice package bcache-tools-1.1.0 is in Tumbleweed already, which includes the fix to follow symbolink.
Hmm, should we close this report ?
In general, I agree with closing it as it is, but... there is no plan to release it as a maintenance update or even a installer update for SLE-15-SP1? It was originally reported for Leap 15.1 and we may get similar reports from customers doing similar tests with SLE-15-SP1 in a near future. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c10 Coly Li <colyli@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(colyli@suse.com) | --- Comment #10 from Coly Li <colyli@suse.com> --- (In reply to Ancor Gonzalez Sosa from comment #9)
(In reply to Coly Li from comment #8)
(In reply to Coly Li from comment #7)
The patch is OK but the commit log should be improved. Once the patch merged into upstream bcache-tools, I will take it.
I just notice package bcache-tools-1.1.0 is in Tumbleweed already, which includes the fix to follow symbolink.
Hmm, should we close this report ?
In general, I agree with closing it as it is, but... there is no plan to release it as a maintenance update or even a installer update for SLE-15-SP1?
It was originally reported for Leap 15.1 and we may get similar reports from customers doing similar tests with SLE-15-SP1 in a near future.
SLE15-SP1 is released for a while, I guess product team won't update the package version. But I can do a backport for SLE12-SP4/SLE12-SP5/SLE15-SP1/SLE15-SP2. So let's keep this report open, until the backport packages are accepted into our products. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c11 --- Comment #11 from Ancor Gonzalez Sosa <ancor@suse.com> --- (In reply to Coly Li from comment #10)
SLE15-SP1 is released for a while, I guess product team won't update the But I can do a backport for SLE12-SP4/SLE12-SP5/SLE15-SP1/SLE15-SP2.
Thanks a ton -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c12 --- Comment #12 from Coly Li <colyli@suse.com> --- (In reply to Ancor Gonzalez Sosa from comment #11)
(In reply to Coly Li from comment #10)
SLE15-SP1 is released for a while, I guess product team won't update the But I can do a backport for SLE12-SP4/SLE12-SP5/SLE15-SP1/SLE15-SP2.
Thanks a ton
bcache-tools for SLE12-SP4 and SLE12-SP5 are based on bcache-tools-0.1.g71, too far from 1.0.9. So the backport will be only for SLE15-SP1 and SLE15-SP2. Now SLE15-SP2 already has bcache-tools-1.1 in, I am working on SLE15-SP1. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c13 --- Comment #13 from Coly Li <colyli@suse.com> --- (In reply to Coly Li from comment #12)
(In reply to Ancor Gonzalez Sosa from comment #11)
(In reply to Coly Li from comment #10)
SLE15-SP1 is released for a while, I guess product team won't update the But I can do a backport for SLE12-SP4/SLE12-SP5/SLE15-SP1/SLE15-SP2.
Thanks a ton
bcache-tools for SLE12-SP4 and SLE12-SP5 are based on bcache-tools-0.1.g71, too far from 1.0.9. So the backport will be only for SLE15-SP1 and SLE15-SP2.
Now SLE15-SP2 already has bcache-tools-1.1 in, I am working on SLE15-SP1.
The backport is submitted to SLE15-SP1:Update, let's wait for the progress. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c15 --- Comment #15 from Swamp Workflow Management <swamp@suse.de> --- SUSE-RU-2020:0700-1: An update that has one recommended fix can now be installed. Category: recommended (moderate) Bug References: 1139948 CVE References: Sources used: SUSE Linux Enterprise Module for Basesystem 15-SP1 (src): bcache-tools-1.0.9-3.8.1 NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c16 --- Comment #16 from Swamp Workflow Management <swamp@suse.de> --- openSUSE-RU-2020:0369-1: An update that has one recommended fix can now be installed. Category: recommended (moderate) Bug References: 1139948 CVE References: Sources used: openSUSE Leap 15.1 (src): bcache-tools-1.0.9-lp151.2.3.1 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1139948 http://bugzilla.suse.com/show_bug.cgi?id=1139948#c17 Coly Li <colyli@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #17 from Coly Li <colyli@suse.com> --- The package is in SLE15-SP1. Here I close this report. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com