[Bug 932331] New: YaST rspec tests do not give any hint to file that cannot be loaded
http://bugzilla.suse.com/show_bug.cgi?id=932331 Bug ID: 932331 Summary: YaST rspec tests do not give any hint to file that cannot be loaded Classification: openSUSE Product: openSUSE Distribution Version: 13.2 Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: YaST2 Assignee: yast2-maintainers@suse.de Reporter: aschnell@suse.com QA Contact: jsrain@suse.com Found By: --- Blocker: --- Tests for two files in https://github.com/aschnell/yast-snapper fail if the regex in SnapperDbus.rb is constructed wrong, e.g. remove the n option from "ret.gsub!(/(\\|[\x80-\xff])/n)". All tests using SnapperDbus.rb fail but rspec does not give a hint that something is wrong with the file SnapperDbus.rb, thus making analysing the problem harder than necessary. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 Arvin Schnell <aschnell@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aschnell@suse.com Found By|--- |Development -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 --- Comment #1 from Arvin Schnell <aschnell@suse.com> --- The error look like: Failure/Error: expect(Yast::SnapperDbus.unescape("hello")).to eq("hello") NameError: uninitialized constant Yast::SnapperDbus I would expect something like: invalid multibyte escape: /(\\|[\x80-\xff])/ in SnapperDbus.rb line ... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 Martin Vidner <mvidner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jreidinger@suse.com, | |mvidner@suse.com Summary|YaST rspec tests do not |[yast2-ruby-bindings] YaST |give any hint to file that |rspec tests do not give any |cannot be loaded |hint to file that cannot be | |loaded --- Comment #2 from Martin Vidner <mvidner@suse.com> --- (For the record, the current position of aschnell/master is https://github.com/aschnell/yast-snapper/tree/d27bd89fd6ce11d904f16f32f01d18...
From there, remove the n option on src/modules/SnapperDbus.rb:48)
The problem is that the yast component system eats the original exception: $ rspec test/*test.rb or $ rspec --backtrace test/*test.rb don't show it, but ~/.y2log does: 2015-05-27 15:14:37 <3> mrakoplas.suse.cz(7869) [Y2Ruby] binary/Y2RubyUtils.cc(y2_require):25 cannot require yast:/local/home-mvidner/svn/yast/snapper/src/modules/SnapperDbus.rb:51: invalid multibyte escape: /(\\|[\x80-\xff])/ at /usr/lib64/ruby/vendor_ruby/2.1.0/yast/yast.rb:162:in `import_pure' 2015-05-27 15:14:37 <3> mrakoplas.suse.cz(7869) [Interpreter] yast/i18n.rb:133 Ruby::loadModule() / Can't load ruby module '/local/home-mvidner/svn/yast/snapper/src/modules/SnapperDbus' 2015-05-27 15:14:37 <5> mrakoplas.suse.cz(7869) [Y2Ruby] binary/YRubyNamespace.cc(YRubyNamespace):219 The Ruby module 'SnapperDbus' is not provided by its rb file 2015-05-27 15:14:37 <3> mrakoplas.suse.cz(7869) [Interpreter] yast/i18n.rb:133 No table associated to module 'SnapperDbus' 2015-05-27 15:14:37 <3> mrakoplas.suse.cz(7869) [Ruby] binary/Yast.cc(getNs):64 ruby call: Can't import namespace 'SnapperDbus' 2015-05-27 15:14:37 <3> mrakoplas.suse.cz(7869) [Y2Ruby] binary/Y2RubyUtils.cc(y2_require):25 cannot require yast:component cannot import namespace 'SnapperDbus' at /usr/lib64/ruby/vendor_ruby/2.1.0/yast/yast.rb:162:in `import_pure' 2015-05-27 15:14:37 <3> mrakoplas.suse.cz(7869) [Interpreter] yast/i18n.rb:133 Ruby::loadModule() / Can't load ruby module '/local/home-mvidner/svn/yast/snapper/src/modules/Snapper' 2015-05-27 15:14:37 <1> mrakoplas.suse.cz(7869) [Y2Ruby] binary/YRuby.cc(~YRuby):107 Shutting down ruby interpreter. The problem is a combination of several problems. Compare: $ ruby -I src/modules/ -r SnapperDbus -e 1 /usr/lib64/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require': /local/home-mvidner/svn/yast/snapper/src/modules/SnapperDbus.rb:51: invalid multibyte escape: /(\\|[\x80-\xff])/ (SyntaxError) from /usr/lib64/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require' $ $ ruby -I src/modules/ -r yast -e 'Yast.import "SnapperDbus"' /usr/lib64/ruby/vendor_ruby/2.1.0/yast/yast.rb:162:in `import_pure': component cannot import namespace 'SnapperDbus' (NameError) from /usr/lib64/ruby/vendor_ruby/2.1.0/yast/yast.rb:162:in `import' from -e:1:in `<main>' [actual exception in y2log] $ ruby -I src/modules/ -r yast -e 'Yast.import "Snapper"' [no error! but it has failed like you reported] -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 Martin Vidner <mvidner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |CONFIRMED -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 --- Comment #3 from Arvin Schnell <aschnell@suse.com> --- I now have the problem with travis (https://travis-ci.org/yast/yast-snapper/builds/64283738) and no clue how to debug it. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 --- Comment #4 from Arvin Schnell <aschnell@suse.com> --- Just by guessing I figured out the problem with travis. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 --- Comment #5 from Martin Vidner <mvidner@suse.com> --- BTW this is related: error passing between liby2 and Perl https://bugzilla.suse.com/show_bug.cgi?id=549156 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 --- Comment #7 from Martin Vidner <mvidner@suse.com> --- Also related: https://github.com/yast/yast-ruby-bindings/issues/92 "Yast.import consumes raised exceptions" -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 Steffen Winterfeldt <snwint@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|yast2-maintainers@suse.de |yast-internal@suse.de -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 http://bugzilla.suse.com/show_bug.cgi?id=932331#c8 Martin Vidner <mvidner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 - Medium |P2 - High --- Comment #8 from Martin Vidner <mvidner@suse.com> --- Seen again in a SLES P1 bug https://bugzilla.suse.com/show_bug.cgi?id=990453 , raising priority. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 http://bugzilla.suse.com/show_bug.cgi?id=932331#c9 --- Comment #9 from Martin Vidner <mvidner@suse.com> --- *** Bug 549156 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 http://bugzilla.suse.com/show_bug.cgi?id=932331#c10 --- Comment #10 from Stefan Hundhammer <shundhammer@suse.com> --- Seen again in my Tumbleweed development environment. Considering that this is one of our main tools, it's sad to see that this doesn't seem to get enough priority to get fixed anytime soon. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 http://bugzilla.suse.com/show_bug.cgi?id=932331#c11 --- Comment #11 from Josef Reidinger <jreidinger@suse.com> --- Idea is to introduce specialized ErrorNamespace that is passed when loading failed and raise it later with proper message. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 http://bugzilla.suse.com/show_bug.cgi?id=932331#c12 --- Comment #12 from Martin Vidner <mvidner@suse.com> --- Fix under review in https://github.com/yast/yast-core/pull/115 and https://github.com/yast/yast-ruby-bindings/pull/181 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 http://bugzilla.suse.com/show_bug.cgi?id=932331#c13 --- Comment #13 from Josef Reidinger <jreidinger@suse.com> --- related pr is also https://github.com/yast/yast-perl-bindings/pull/14 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| maint:planned:update |maint:planned:update | |ibs:running:5260:moderate -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|maint:planned:update |maint:planned:update |ibs:running:5260:moderate | -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|maint:planned:update |maint:planned:update | |obs:running:7400:moderate -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 http://bugzilla.suse.com/show_bug.cgi?id=932331#c15 --- Comment #15 from Swamp Workflow Management <swamp@suse.de> --- SUSE-RU-2017:2808-1: An update that has 7 recommended fixes can now be installed. Category: recommended (moderate) Bug References: 1026027,1036440,1037214,1037727,1038717,1050986,932331 CVE References: Sources used: SUSE Linux Enterprise Server for SAP Installer 12-SP2 (src): yast2-3.1.217-37.18.1, yast2-network-3.1.181-46.7.46 SUSE Linux Enterprise Server for Raspberry Pi 12-SP2 (src): yast2-3.1.217-37.18.1, yast2-network-3.1.181-46.7.46 SUSE Linux Enterprise Server Installer for Raspberry Pi 12-SP2 (src): yast2-3.1.217-37.18.1, yast2-network-3.1.181-46.7.46 SUSE Linux Enterprise Server Installer 12-SP2 (src): yast2-3.1.217-37.18.1, yast2-network-3.1.181-46.7.46 SUSE Linux Enterprise Server 12-SP2 (src): yast2-3.1.217-37.18.1, yast2-network-3.1.181-46.7.46 SUSE Linux Enterprise Desktop Installer 12-SP2 (src): yast2-3.1.217-37.18.1, yast2-network-3.1.181-46.7.46 SUSE Linux Enterprise Desktop 12-SP2 (src): yast2-3.1.217-37.18.1, yast2-network-3.1.181-46.7.46 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 http://bugzilla.suse.com/show_bug.cgi?id=932331#c16 --- Comment #16 from Swamp Workflow Management <swamp@suse.de> --- openSUSE-RU-2017:2827-1: An update that has 7 recommended fixes can now be installed. Category: recommended (moderate) Bug References: 1026027,1036440,1037214,1037727,1038717,1050986,932331 CVE References: Sources used: openSUSE Leap 42.2 (src): yast2-3.1.217-5.6.1, yast2-network-3.1.181-5.9.1 -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|maint:planned:update |maint:planned:update |obs:running:7400:moderate | -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 Gustavo Pichorim Boiko <gboiko@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maint-coord@suse.de, | |yast-internal@suse.de Flags| |needinfo?(yast-internal@sus | |e.de) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 Josef Reidinger <jreidinger@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(yast-internal@sus | |e.de) | -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=932331 Swamp Workflow Management <swamp@suse.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|maint:planned:update | -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com