New subject: [Bug 510973] update-desktop-files doesn't search deep enough for icon files

8 Jun 2009

      http://bugzilla.novell.com/show_bug.cgi?id=510973

           Summary: update-desktop-files doesn't search deep enough for
                    icon files
    Classification: openSUSE
           Product: openSUSE 11.2
           Version: Factory
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Minor
          Priority: P5 - None
         Component: Basesystem
        AssignedTo: mls@novell.com
        ReportedBy: cmorve69@yahoo.es
         QAContact: qa@suse.de
          Found By: Community User

The suse_update_desktop_file.sh file contains:

if [ "$INSTALL" = "yes" ]; then
  mkdir -p $RPM_BUILD_ROOT/usr/share/applications/
  FILE=`find $RPM_SOURCE_DIR $RPM_BUILD_DIR . -name $APPLICATION.desktop| sort
-r | head -n 1`
  if [ -s "$FILE" ]; then
    cp -v "$FILE" $RPM_BUILD_ROOT/usr/share/applications/
    icon_file=`sed -n '/^\[Desktop Entry\]/,/(\[.*|$)/ s,Icon=\(.*\),\1,p'
"$FILE"`
    icon_file=`find $RPM_SOURCE_DIR $RPM_BUILD_DIR -maxdepth 1 -name
${icon_file}.png -o -name ${icon_file}.xpm -o -name $icon_file | sort -r | head
-n 1`
    if [ -s "$icon_file" ]; then
      mkdir -p $RPM_BUILD_ROOT/usr/share/pixmaps/
      cp -v "$icon_file" $RPM_BUILD_ROOT/usr/share/pixmaps/
    fi
  fi
fi

And the problem is with: find $RPM_SOURCE_DIR $RPM_BUILD_DIR -maxdepth 1 -name
${icon_file}.png -o -name ${icon_file}.xpm -o -name $icon_file | sort -r | head
-n 1

Why "-maxdepth 1"?? Normally in RPM_BUILD_DIR there isn't any file, just a
%{name}-%{version} dir. IMHO if maxdepth makes any sense at all, at least
"-maxdepth 2" would be a better value.

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 510973] New: update-desktop-files doesn't search deep enough for icon files

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

bugzilla_noreply＠novell.com

tags

participants (1)