[Bug 635920] New: hdparm v9.28 does not work with OCZ Vertex 2E SSD
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c0 Summary: hdparm v9.28 does not work with OCZ Vertex 2E SSD Classification: openSUSE Product: openSUSE 11.3 Version: Final Platform: All OS/Version: openSUSE 11.3 Status: NEW Severity: Critical Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: Greg.Freemyer@gmail.com QAContact: qa@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100723 SUSE/3.6.8-0.1.1 Firefox/3.6.8 Please upgrade oS 11.2 and 11.3 to hdparm v9.30 available on sourceforge. == background for request This bug relates to the hdparm --trim-sector-ranges-stdin capability which is invoked by the wiper.sh script which is also part of the hdparm package. Support for wiper.sh and hdparm --trim-sector-ranges-stdin is included in both openSUSE 11.2 and 11.3. Thomas Hertweck <Thomas.Hertweck at web.de> reported:
I have now installed openSUSE 11.3 on a OCZ Vertex 2E SSD. I used a standard ext4 filesystem, the mount options at the moment are "rw,noatime,acl,user_xattr". Unfortunately, wiper.sh doesn't work at all.
No joy, obviously.
I have asked Mark Lord (the hdparm maintainer) for feedback. He said the default max TRIM payload sent via hdparm has been lowered in the latest release of hdparm v2.30 and recommended we upgrade and see if it fixes the problem Reproducible: Always Steps to Reproduce: 1. Run wiper.sh against a Ext4 FS on a OCZ Vertex 2E SSD 2. 3. Actual Results:
$> wiper.sh --verbose --commit /dev/sdb1 wiper.sh: Linux SATA SSD TRIM utility, version 2.6, by Mark Lord. wiper.sh: This tool is DANGEROUS! Please read and understand wiper.sh: /usr/share/doc/packages/hdparm/README.wiper wiper.sh: before going any further. rootdev=/dev/sdb1 fsmode2: fsmode=read-write /: fstype=ext4 freesize = 45338732 KB, reserved = 453387 KB Preparing for online TRIM of free space on /dev/sdb1 (ext4 mounted read-write at /). This operation could silently destroy your data. Are you sure (y/N)? y Creating temporary file (44885345 KB).. Syncing disks.. Beginning TRIM operations.. get_trimlist=/sbin/hdparm --fibmap WIPER_TMPFILE.13467 /dev/sdb: trimming 89770696 sectors from 1493 ranges FAILED: Input/output error Removing temporary file.. Syncing disks.. Aborted.
Expected Results: All EXT4 unallocated space on the SSD should be "trimmed" such that the SSD can erase the unallocated sectors in advance of their being used, thus improving performance of the SSD. Note: There is a wiki entry that covers discard (trim) in openSUSE: http://en.opensuse.org/SDB:SSD_discard_%28trim%29_support Thread that originated the bug is available at: http://lists.opensuse.org/opensuse-kernel/2010-08/msg00068.html -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c1 --- Comment #1 from Greg Freemyer <Greg.Freemyer@gmail.com> 2010-08-31 21:51:38 UTC --- hdparm v9.30 has been tested and no longer fails for this SSD. Definitely needs to be in factory, but I hope it gets pushed out to 11.2 and 11.3 as well. ==== Per Thomas Hertweck <Thomas.Hertweck at web.de>:
hdparm v9.30 seems to work. I've run a quick test using my own build of hdparm (I am using a slightly modified wiper.sh below which picks up my own new hdparm executable instead of/sbin/hdparm).
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ $> sudo ./wiper.sh --verbose --commit /dev/sdb1 wiper.sh: Linux SATA SSD TRIM utility, version 2.8, by Mark Lord. rootdev=/dev/sdb1 fsmode2: fsmode=read-write /: fstype=ext4 freesize = 39790388 KB, reserved = 397903 KB Preparing for online TRIM of free space on /dev/sdb1 (ext4 mounted read-write at /).
This operation could silently destroy your data. Are you sure (y/N)? y Creating temporary file (39392485 KB).. Syncing disks.. Beginning TRIM operations.. get_trimlist=/home/thomas/hdparm-9.30/hdparm --fibmap WIPER_TMPFILE.9880
/dev/sdb: trimming 3833854 sectors from 64 ranges succeeded trimming 3375106 sectors from 64 ranges succeeded trimming 3735549 sectors from 64 ranges succeeded trimming 3817474 sectors from 64 ranges succeeded trimming 3915776 sectors from 64 ranges succeeded trimming 3784705 sectors from 64 ranges succeeded trimming 3833855 sectors from 64 ranges succeeded trimming 3866625 sectors from 64 ranges succeeded trimming 3850238 sectors from 64 ranges succeeded trimming 3768321 sectors from 64 ranges succeeded trimming 3883008 sectors from 64 ranges succeeded trimming 3801087 sectors from 64 ranges succeeded trimming 3719170 sectors from 64 ranges succeeded trimming 3555328 sectors from 64 ranges succeeded trimming 3833855 sectors from 64 ranges succeeded trimming 3915775 sectors from 64 ranges succeeded trimming 3915776 sectors from 64 ranges succeeded trimming 3932160 sectors from 64 ranges succeeded trimming 3866623 sectors from 64 ranges succeeded trimming 3899394 sectors from 64 ranges succeeded trimming 2681297 sectors from 49 ranges succeeded Removing temporary file.. Syncing disks.. Done. ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c n liu <nliu@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nliu@novell.com AssignedTo|bnc-team-screening@forge.pr |puzel@novell.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c2 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |NEEDINFO InfoProvider| |Greg.Freemyer@gmail.com Status Whiteboard| |hdparm --- Comment #2 from Petr Uzel <puzel@novell.com> 2010-09-14 14:04:54 UTC --- Greg, thanks for the report. (In reply to comment #1)
hdparm v9.30 has been tested and no longer fails for this SSD.
OK
Definitely needs to be in factory,
Sure - will do it soon.
but I hope it gets pushed out to 11.2 and 11.3 as well.
I'm not sure about the update - can't hdparm-2.2{2,8} be patched to work with the given device? I tried to find hdparm sourcecode repository, but couldn't find it - do you know if there is any? I doubt there are many users bitten by this - other option would be to build hdparm-2.30 for 11.2 and 11.3 and provide it in separate repository (linked from the TRIM wikipage). What do you think? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c3 Greg Freemyer <Greg.Freemyer@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|Greg.Freemyer@gmail.com | --- Comment #3 from Greg Freemyer <Greg.Freemyer@gmail.com> 2010-09-14 16:39:01 UTC --- I don't know of a git / cvs repo. But you can pull down a tarball for any of the releases. See http://sourceforge.net/projects/hdparm/files/ Just view "all files" and click on the little pointer beside hdparm at: === As to patching vs. a new release: I strongly suspect many SSDs don't work with the TRIM feature of hdparm 9.22 and 9.28 releases, but due to very limited testing, we don't have bugzillas to show it. --- I haven't read thru the release notes / changes for each release, but I think you'll find that the only part of hdparm that has been getting updates in the last couple years is the SSD TRIM handling feature which was new a couple years ago or less. So if you feel it is warranted, you can compare the source and only patch in the code changes relevant to TRIM, but my guess is that will be all the changes. Thus if I were doing it, I'd just do a full update. fyi: The TRIM portion of the ATA8 draft spec has been seeing changes and also many non-compliant SSDs have been released of the last couple years. As such hdparm has been trying to keep up with both spec changes and real-world reality. The biggest change I know of from 9.28 to 9.30 is reducing the default TRIM payload from 1 MB to 512 bytes (I think). That was done because all known SSDs handle at least one sectors worth trim payload, but several apparently don't support more than that. That one patch may make many SSDs that currently don't work with hdparm work. (ie. Intel SSDs were believed not to work prior to that change, but I haven't seen any official bugzillas, but neither have I seen any success reports.) I doubt 9.22 even tries to read the max payload size attribute from a compliant SSD. I first heard about that attribute just a few months ago, but Mark Lord said at the time that hdparm already had support for it built-in. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c4 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO CC| |maintenance@opensuse.org InfoProvider| |Greg.Freemyer@gmail.com --- Comment #4 from Petr Uzel <puzel@novell.com> 2010-09-15 13:45:52 UTC --- (In reply to comment #3)
I don't know of a git / cvs repo. But you can pull down a tarball for any of the releases.
Yes, I know that. But when looking for one particular change, the VCS is much more useful. I'll ask hdparm author.
=== As to patching vs. a new release:
I strongly suspect many SSDs don't work with the TRIM feature of hdparm 9.22 and 9.28 releases, but due to very limited testing, we don't have bugzillas to show it.
But that also means that not many users care about TRIM, right? :)
--- I haven't read thru the release notes / changes for each release, but I think you'll find that the only part of hdparm that has been getting updates in the last couple years is the SSD TRIM handling feature which was new a couple years ago or less.
hdparm-9.30 - report word[105] in -I : max 512-byte blocks of range-data per DSM/Trim command - fix wiper.sh/hdparm to use only as many LBA ranges per TRIM as the drive can handle - manpage / help-text cleanups from Benno Schulenberg <bensberg@justemail.net> hdparm-9.29 - add --offset for use with -t, to get timings from middle/end of drive, courtesy of Sergei Kirjanov <rewlad@gmail.com> - restrict --trim-sector-ranges-stdin to small TRIM commands on most drives - fix w62 bug in -I - dump all data bytes with --verbose - warn about bad/missing sense data, but continue regardless - show in/out data[] separately with --verbose - Add reporting to -I for sata3 signaling speed. - force use of ATA_16 for all commands to ATAPI devices. - supply a sector count of "1" for IDENTIFY commands, to satisfy buggy USB3 bridges.
So if you feel it is warranted, you can compare the source and only patch in the code changes relevant to TRIM, but my guess is that will be all the changes. Thus if I were doing it, I'd just do a full update.
What about this: I'll try to extract the required change from the diff between 9.28 and 9.30 and apply it to hdparm-9.28 in 11.3 - would you be able to test if it works? If it does, we can try to patch also hdparm in 11.2, if not, we will ask maintenance team about full update (CC:ing now). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c5 --- Comment #5 from Petr Uzel <puzel@novell.com> 2010-09-15 15:05:26 UTC --- hdparm-9.30 is now in Base:System (should be building for Factory, 11.3 and 11.2). Submitted to Factory as well. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c6 Greg Freemyer <Greg.Freemyer@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|Greg.Freemyer@gmail.com | --- Comment #6 from Greg Freemyer <Greg.Freemyer@gmail.com> 2010-09-17 22:43:35 UTC --- Petr, You're right hdparm trim support is not yet being used by many people, but as SSDs become more common I hope that changes, even with 11.2 and 11.3 releases of OS. I don't have an SSD that fails with hdparm 9.28 The SSD that was failing was owned by Thomas Hertweck <Thomas.Hertweck at web.de>: We need to get him to do the test. Hopefully he's willing. Can we add him to the cc list for the bug? I'll try. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c7 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #7 from Petr Uzel <puzel@novell.com> 2010-09-20 12:00:20 UTC --- (In reply to comment #6)
You're right hdparm trim support is not yet being used by many people, but as SSDs become more common I hope that changes, even with 11.2 and 11.3 releases of OS.
OK, let's try to backport the fix.
The SSD that was failing was owned by Thomas Hertweck <Thomas.Hertweck at web.de>:
We need to get him to do the test. Hopefully he's willing. Can we add him to the cc list for the bug? I'll try.
Since Thomas does not have bugzilla account, I'll discuss it with him via email (will keep you in CC of course). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c8 --- Comment #8 from Greg Freemyer <Greg.Freemyer@gmail.com> 2010-09-24 11:54:32 UTC --- Petr, hdparm 9.32 was just announced and apparently has some bug fixes that I assume should go to factory at a minimum. http://markmail.org/message/ryuv374gnbgybby6 How do the packagers like yourself track things like this? Do you have to monitor the various lists, or do you depend on bugzillas? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c9 --- Comment #9 from Petr Uzel <puzel@novell.com> 2010-09-24 12:10:16 UTC --- (In reply to comment #8)
Petr,
hdparm 9.32 was just announced and apparently has some bug fixes that I assume should go to factory at a minimum.
Alredy submitted to Factory :)
How do the packagers like yourself track things like this?
Mailing lists, RSS feeds, freshmeat, etc. In this particular case, I got a mail from Mark that new hdparm version is released.
Do you have to monitor the various lists, or do you depend on bugzillas?
It never hurts if you open bugzilla entry... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c10 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |maintenance@opensuse.org --- Comment #10 from Petr Uzel <puzel@novell.com> 2010-09-30 08:13:09 UTC --- @Mr Maintenance: Thomas reported that the hdparm with backported fix works fine on his SSD drive. After wiper.sh, the filesystem was in use for several days and fsck did not report any trouble. So, can we release it as an update? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c11 Christian Dengler <cdengler@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cdengler@novell.com --- Comment #11 from Christian Dengler <cdengler@novell.com> 2010-10-05 16:32:25 UTC --- Yes, think so. For an update +1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c12 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|hdparm |hdparm | |maint:running:36369:low --- Comment #12 from Swamp Workflow Management <swamp@suse.com> 2010-10-08 15:43:13 UTC --- The SWAMPID for this issue is 36369. This issue was rated as low. Please submit fixed packages until 2010-11-05. Also create a patchinfo file using this link: https://swamp.suse.de/webswamp/wf/36369 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c13 Christian Dengler <cdengler@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|maintenance@opensuse.org | --- Comment #13 from Christian Dengler <cdengler@novell.com> 2010-10-08 15:43:56 UTC --- No one against from team, so update started. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c14 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #14 from Petr Uzel <puzel@novell.com> 2010-10-11 09:07:20 UTC --- Packages and patchinfo submitted. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c15 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|hdparm |hdparm |maint:running:36369:low |maint:running:36369:low | |maint:released:11.2:36376 | |maint:released:11.3:36376 --- Comment #15 from Swamp Workflow Management <swamp@suse.com> 2010-10-27 08:38:17 UTC --- Update released for: hdparm, hdparm-debuginfo, hdparm-debugsource Products: openSUSE 11.2 (debug, i586, x86_64) openSUSE 11.3 (debug, i586, x86_64) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=635920 https://bugzilla.novell.com/show_bug.cgi?id=635920#c Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|hdparm |hdparm |maint:running:36369:low | |maint:released:11.2:36376 | |maint:released:11.3:36376 | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=635920 http://bugzilla.novell.com/show_bug.cgi?id=635920#c16 --- Comment #16 from Bernhard Wiedemann <bwiedemann@suse.com> --- This is an autogenerated message for OBS integration: This bug (635920) was mentioned in https://build.opensuse.org/request/show/50198 11.3:Test / hdparm https://build.opensuse.org/request/show/50199 11.2:Test / hdparm -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com