[Bug 543763] New: gnuboy-1.0.3-1061.9: missing call to close
http://bugzilla.novell.com/show_bug.cgi?id=543763 Summary: gnuboy-1.0.3-1061.9: missing call to close Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package gnuboy-1.0.3-1061.9 source code file gnuboy-1.0.3/sys/nix/map.c function map_rom local variable fd. I notice the following code fd = open(romfile, O_READ); but I fail to notice any matching call to close. This looks like a resource leak to me. Suggest add a call to close near the end of the block to plug the leak. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543763 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |wolfgang.engel@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543763 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=543763#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:56:04 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=543763 https://bugzilla.novell.com/show_bug.cgi?id=543763#c2 Wolfgang Engel <wolfgang.engel@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |WONTFIX --- Comment #2 from Wolfgang Engel <wolfgang.engel@suse.com> 2012-11-13 13:34:13 UTC --- Won't fix. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com