[Bug 442857] New: bonnie++-1.02-468.7: call to wrong C++ delete
https://bugzilla.novell.com/show_bug.cgi?id=442857 Summary: bonnie++-1.02-468.7: call to wrong C++ delete Product: openSUSE 11.1 Version: Factory Platform: All OS/Version: openSUSE 11.0 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just checked some of the source code in the Suse Linux factory package bonnie++-1.02-468.7 and I noticed the following $ fgrep new ../BUILD/bonnie++-1.02/bonnie++.cpp { delete m_buf; m_buf = new char[size]; m_chunk_size = size; } name = new char[strlen(path) + 15]; , m_buf(new char[m_chunk_size]) $ fgrep delete ../BUILD/bonnie++-1.02/bonnie++.cpp { delete m_buf; m_buf = new char[size]; m_chunk_size = size; } ~CGlobalItems() { delete name; delete m_buf; } delete name; Someone's got confused between ordinary delete and array delete. new match delete and new [] matches delete []. The results of the fgrep delete would be better as $ fgrep delete ../BUILD/bonnie++-1.02/bonnie++.cpp { delete [] m_buf; m_buf = new char[size]; m_chunk_size = size; } ~CGlobalItems() { delete [] name; delete [] m_buf; } delete [] name; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=442857 Andreas Jaeger <aj@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.provo.novell.com |ories@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=442857 User yxu@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=442857#c2 Yi Xu <yxu@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|yxu@novell.com |xxiao@novell.com --- Comment #2 from Yi Xu <yxu@novell.com> 2008-11-11 08:42:52 MST --- Xiao Xiao, could you fix it? And declare ad pdb that you are the new maintainer for bonnie++. Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=442857 xiao xiao <xxiao@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=442857 User xxiao@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=442857#c3 xiao xiao <xxiao@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #3 from xiao xiao <xxiao@novell.com> 2009-02-11 01:46:27 MST --- (In reply to comment #2)
Xiao Xiao, could you fix it? And declare ad pdb that you are the new maintainer for bonnie++. Thanks.
I already modified the bonnie++'s source as David Binderman described , do a patch the latest version of bonnie++,built it on quake31 successfully,then submitted it by using the script "submitpac" -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com