[Bug 212495] New: main-menu: 'Close' button in About Box has no effect
https://bugzilla.novell.com/show_bug.cgi?id=212495 Summary: main-menu: 'Close' button in About Box has no effect Product: openSUSE 10.2 Version: Alpha 5 Platform: All OS/Version: SuSE Other Status: NEW Severity: Minor Priority: P5 - None Component: GNOME AssignedTo: bnc-team-gnome@forge.provo.novell.com ReportedBy: rml@novell.com QAContact: qa@suse.de In the GNOME Main Menu, the 'Close' button in the About Box (right click, About) has no effect. Clicking the 'X' closes the box. This is on openSUSE 10.2, up-to-date as of 14 Oct. Package version is 0.6.2-9. This might be a bug on SLED10, too. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212495 rml@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |jimmyk@novell.com |gnome@forge.provo.novell.com| -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212495 ------- Comment #1 from danw@ximian.com 2006-10-14 15:49 MST ------- if it's just 10.2, it's probably the same bug as bug 201167, which is apparently an (accidental?) api change in GtkAboutDialog in gtk 2.10. See http://bugzilla.gnome.org/show_bug.cgi?id=360425 http://bugzilla.gnome.org/show_bug.cgi?id=361830 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212495 ------- Comment #2 from rml@novell.com 2006-10-15 08:40 MST ------- Sounds reasonable. Jimmy, the fix looks simple. FWIW, I checked the About Box on a bunch of other applications and it worked fine. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212495 jimmyk@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212495 jpr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #3 from jpr@novell.com 2006-10-19 10:34 MST ------- Works in alpha5 plus factory now, presumably gtk was updated as bug 201495 has also gone away. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212495 jpr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | ------- Comment #4 from jpr@novell.com 2006-10-19 10:36 MST ------- Oops, tested on sled 10, not 10.2. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212495 federico@ximian.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe@veber.de ------- Comment #5 from federico@ximian.com 2006-10-19 10:54 MST ------- *** Bug 201495 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212495 federico@ximian.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |federico@ximian.com ------- Comment #6 from federico@ximian.com 2006-10-19 10:54 MST ------- The change in GTK+ that caused this is http://bugzilla.gnome.org/show_bug.cgi?id=333360 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212495
------- Comment #7 from federico@ximian.com 2006-10-19 11:09 MST -------
Although strictly speaking this is an ABI change, the rationale is not bad:
(11:50:36) federico: mclasen: so regardless of consistency with the rest of the
dialog API, isn't this an ABI break?
(11:50:53) mclasen: kind of
(11:51:12) mclasen: but the failure mode is pretty benign
(11:51:23) mclasen: no crash, and the user can still close the dialog with the
window manager close button
(11:51:33) mclasen: the old behaviour could lead to crashes
(11:51:53) jannis [~jannis@e176178040.adsl.alicedsl.de] entered the room.
(11:52:01) mclasen: and yes, I don't know why nobody uses the convenience api
we conveived...
(11:52:09) federico: it's not very well documented :)
"The old behavior" is that gtk_about_dialog_new() would give you a dialog that
destroys itself when the user closes it. Many apps assumed that the dialog
would just get hidden, and they crashed when attempting to reuse the defunct
object.
"The convenience API" is gtk_show_about_dialog(). This is a fire-and-forget
function to create an about dialog. The about dialog gets associated to a
parent window and will be reused automatically if invoked a second time --- the
program doesn't have to do any extra memory management on its own.
I suggest that we change our apps that use gtk_about_dialog_new() to use
gtk_show_about_dialog():
const char *authors[] =
{
"J. Random Hacker
https://bugzilla.novell.com/show_bug.cgi?id=212495 jimmyk@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212495 jpr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zsu@novell.com ------- Comment #8 from jpr@novell.com 2006-10-31 06:39 MST ------- *** Bug 216525 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212495 jpr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|Minor |Normal -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=212495 jimmyk@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #9 from jimmyk@novell.com 2007-01-30 15:01 MST ------- The fix for this has been submitted to sle10-sp in autobuild. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply@novell.com