[Bug 259687] New: kmps no longer have hashed requires
https://bugzilla.novell.com/show_bug.cgi?id=259687 Summary: kmps no longer have hashed requires Product: openSUSE 10.3 Version: Alpha 2plus Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Kernel AssignedTo: kernel-maintainers@forge.provo.novell.com ReportedBy: rguenther@novell.com QAContact: qa@suse.de CC: agruen@novell.com, aj@novell.com because module-init-tools are not installed in the build root. Proper BuildRequires are required. I suggest a %kmp_build_requires which pulls in requires needed to build kmps. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=259687 agruen@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mls@novell.com, ro@novell.com Status|NEW |NEEDINFO Info Provider| |mls@novell.com ------- Comment #1 from agruen@novell.com 2007-03-31 11:35 MST ------- The module-init-tools were always present in build environments in the past; scripts like /usr/lib/rpm/find-requires.ksyms depend on mthem to compute the dependencies of packages that contain *.ko files under /lib/modules. There are two ways how we can deal with this: either add a build check that rejects non-KMP pakages that contain kernel modules, or add module-init-tools again. For the former, we could check if packages contain any *.ko files (under /lib/modules or even somewhere else). If they do, then we could reject the package if it doesn't contain kernel(...) requirements as well. We could add a "BuildRequires: module-init-tools" to the %kernel_module_package and %suse_kernel_module_package macros. An additional %kmp_build_requires macro would just be error prone. Michael? Rudi? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=259687 ------- Comment #2 from rguenther@novell.com 2007-03-31 11:41 MST ------- Indeed, if we have a %kernel_module_package macro already there's no need for another one. I second the proposal to add module-init-tools there. Can the scripts invoked cause the build to fail if required tools are missing? We have a similar problem for brp-check-bytecode-version which seems to require unzip (I cannot spot where the script is located right now). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=259687 ------- Comment #3 from agruen@novell.com 2007-03-31 11:54 MST ------- Unfortunately the find-* scripts cannot return any status information currently. We could add some dummy requires / provides / supplements / etc. tags that indicate failure and check for them in the resulting package, but that would only be kludges. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=259687 ------- Comment #4 from rguenther@novell.com 2007-03-31 11:59 MST ------- I think it would be good for all scripts invoked by autobuild to be able to signal a fatal error, otherwise we get "silent" changes like this one. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=259687 ------- Comment #5 from agruen@novell.com 2007-04-02 07:27 MST ------- I have added a ``BuildRequires: module-init-tools'' dependency to the %suse_kernel_module_package and %kernel_module_package macros. We should still add a build check to Autobuild though. I also agree that the find-* scripts should be allowed to fail. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=259687 lmb@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kernel- |mls@novell.com |maintainers@forge.provo.nove| |ll.com | Status|NEEDINFO |NEW Info Provider|mls@novell.com | ------- Comment #6 from lmb@novell.com 2007-05-08 01:53 MST ------- It seems this is fixed for the kernel part. Reassigning to mls for the remaining points mentioned in comment #5. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=259687 mls@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=259687 Richard Guenther <rguenther@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Found By|Other |Development -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com