[Bug 536531] New: silc-toolkit-1.1.9-1.4: missing call to pclose on successful return
http://bugzilla.novell.com/show_bug.cgi?id=536531 Summary: silc-toolkit-1.1.9-1.4: missing call to pclose on successful return Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package silc-toolkit-1.1.9-1.4 For source code file silc-toolkit-1.1.9/lib/silchttp/silchttpphp.c around line 70, function silc_http_php_file is the following code fd = popen(tmp, "r"); I can see that various error exits have a call to a close function, but I fail to find such a call on ordinary success return, somewhere near the end of the function. Suggest add call to pclose near the end of the function. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=536531 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |sbrabec@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=536531 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=536531#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:55:23 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=536531 Stanislav Brabec <sbrabec@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|silc-toolkit-1.1.9-1.4: |JJ: silc-toolkit-1.1.9-1.4: |missing call to pclose on |missing call to pclose on |successful return |successful return -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=536531 http://bugzilla.novell.com/show_bug.cgi?id=536531#c Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pgajdos@novell.com AssignedTo|sbrabec@novell.com |pgajdos@novell.com -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=536531 http://bugzilla.novell.com/show_bug.cgi?id=536531#c2 Petr Gajdos <pgajdos@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |UPSTREAM --- Comment #2 from Petr Gajdos <pgajdos@novell.com> 2010-05-03 12:10:26 UTC --- Upstream notified via http://www.silcnet.org/support/bugs.php Closing FIXED UPSTREAM. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com