[Bug 513037] New: gpsd-2.37-71.39: gpsd-2.37-71.39
http://bugzilla.novell.com/show_bug.cgi?id=513037 Summary: gpsd-2.37-71.39: gpsd-2.37-71.39 Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just tried to build Factory package gpsd-2.37-71.39 and the build said sirfmon.c:751:6: warning: array subscript is above array bounds The source code is if (controlfd < -1) FD_SET(controlfd,&select_set); This looks like very dodgy code because controlfd should have a small positive value to be legal to use in FD_SET. Suggest code rework. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=513037 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |jreuter@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=513037 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=513037#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:54:17 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=513037 http://bugzilla.novell.com/show_bug.cgi?id=513037#c2 Joerg Reuter <jreuter@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |UPSTREAM --- Comment #2 from Joerg Reuter <jreuter@novell.com> 2009-12-08 13:28:27 UTC --- This has been fixed upstream for gpsd-2.90, indeed. I'm working on a package upgrade for Factory. I cannot see how controlfd could ever become smaller than -1, and the function never even checks for controlfd after select(), it's not worth the effort to fix this typo for previous versions, IMHO. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com