https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c2 --- Comment #2 from Kay Sievers 2010-11-26 14:08:39 UTC --- Sounds nice. Thanks for taking care. Would be great if the patches can be send upstream too, when the services work as expected. The current sd-daemon.[hc] files to add are here: http://cgit.freedesktop.org/systemd/tree/src/sd-daemon.h Or installed by systemd.rpm in /usr/share/doc/packages/systemd/. Thanks again! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c4 --- Comment #4 from Kay Sievers 2010-11-26 15:37:08 UTC --- Na, there is no lib, and none planned to have so far. That's why it's not installed. It's just 2 files to copy into the project. They contain very basic logic. The logic can be open-coded too, if necessary. We will get into dependency problems if we make all services link directly against systemd at that point. That can be reconsidered later, when there might be more interesting things than gentenv() and stat() to do. :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c6 --- Comment #6 from Kay Sievers 2010-11-26 15:53:21 UTC --- It's included in a ton of projects already, also in rsyslog. And it's BSD licensed. Anyway not my call, I can just provide what I have, and I don't have a shared lib, and upstream did not want one as of now. That might all be reconsidered later. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c7 --- Comment #7 from Dr. Werner Fink 2010-11-26 16:09:52 UTC --- .. it should be reconsidered ... beside this I'd like also to have the manual page around as mentioned in sd-daemon.h: /* Returns how many file descriptors have been passed, or a negative errno code on failure. Optionally, removes the $LISTEN_FDS and $LISTEN_PID file descriptors from the environment (recommended, but problematic in threaded environments). If r is the return value of this function you'll find the file descriptors passed as fds SD_LISTEN_FDS_START to SD_LISTEN_FDS_START+r-1. Returns a negative errno style error code on failure. This function call ensures that the FD_CLOEXEC flag is set for the passed file descriptors, to make sure they are not passed on to child processes. If FD_CLOEXEC shall not be set, the caller needs to unset it after this call for all file descriptors that are used. See sd_listen_fds(3) for more information. */ int sd_listen_fds(int unset_environment) _sd_hidden_; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c9 --- Comment #9 from Kay Sievers 2010-11-26 19:36:26 UTC --- (In reply to comment #7)

... it should be reconsidered ... beside this I'd like also to have the manual page around as mentioned in sd-daemon.h:

$ rpm -ql systemd | grep fds /usr/share/man/man3/sd_listen_fds.3.gz :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c10 --- Comment #10 from Marius Tomaschewski 2010-11-29 13:19:20 UTC --- A first, not yet tested rsyslog with systemd support is in Base:System. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c12 --- Comment #12 from Marius Tomaschewski 2010-11-29 15:18:12 UTC --- Depends on: bug 656259 comment 5. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c14 --- Comment #14 from Marius Tomaschewski 2010-12-13 09:44:58 UTC --- Created an attachment (id=404504) --> (http://bugzilla.novell.com/attachment.cgi?id=404504) rsyslog-5.6.2-systemd-integration.bnc656104.diff The current rsyslog patch. Currently the upstream (git master) version limited to /dev/log. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c16 --- Comment #16 from Dr. Werner Fink 2010-12-14 10:27:10 UTC --- Please give also the old syslogd a try to see if this works flawless together with systemd, thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c Marius Tomaschewski changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |werner@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c19 --- Comment #19 from Dr. Werner Fink 2011-02-10 13:00:51 UTC --- Created an attachment (id=413292) --> (http://bugzilla.novell.com/attachment.cgi?id=413292) startproc: socket activation forwarding this one works even if -e is choosen on the startproc commandline Marius ... does this work for you? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c21 Marius Tomaschewski changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Target Milestone|--- |RC 2 --- Comment #21 from Marius Tomaschewski 2011-02-10 15:12:00 UTC --- Yes, works perfectly: same socket node [2666 here] used by systemd and syslog daemon process - also after a switch to another syslog daemon: abraxas7:~ # lsof | grep "/dev/log" systemd 1 root 25u unix 0xffff88001cb86700 0t0 2666 /dev/log systemd-k 290 root 3w unix 0xffff88001cb86700 0t0 2666 /dev/log syslog-ng 1938 root 3u unix 0xffff88001cb86700 0t0 2666 /dev/log syslog-ng 1939 root 3u unix 0xffff88001cb86700 0t0 2666 /dev/log abraxas7:~ # vi /etc/sysconfig/syslog abraxas7:~ # systemctl restart syslog.service abraxas7:~ # lsof | grep "/dev/log" systemd 1 root 25u unix 0xffff88001cb86700 0t0 2666 /dev/log systemd-k 290 root 3w unix 0xffff88001cb86700 0t0 2666 /dev/log syslogd 2053 root 3u unix 0xffff88001cb86700 0t0 2666 /dev/log abraxas7:~ # vi /etc/sysconfig/syslog abraxas7:~ # systemctl restart syslog.service abraxas7:~ # lsof | grep "/dev/log" systemd 1 root 25u unix 0xffff88001cb86700 0t0 2666 /dev/log systemd-k 290 root 3w unix 0xffff88001cb86700 0t0 2666 /dev/log rsyslogd 2083 root 3u unix 0xffff88001cb86700 0t0 2666 /dev/log rs:main 2083 2084 root 3u unix 0xffff88001cb86700 0t0 2666 /dev/log rsyslogd 2083 2085 root 3u unix 0xffff88001cb86700 0t0 2666 /dev/log rsyslogd 2083 2086 root 3u unix 0xffff88001cb86700 0t0 2666 /dev/log rsyslogd 2083 2087 root 3u unix 0xffff88001cb86700 0t0 2666 /dev/log abraxas7:~ # systemctl status syslog.service syslog.service - LSB: Start the system logging daemons Loaded: loaded (/etc/init.d/syslog) Active: active (running) since Thu, 10 Feb 2011 15:58:37 +0100; 30s ago Process: 2063 ExecStop=/etc/init.d/syslog stop (code=exited, status=0/SUCCESS) Process: 2073 ExecStart=/etc/init.d/syslog start (code=exited, status=0/SUCCESS) Main PID: 2083 (rsyslogd) CGroup: name=systemd:/system/syslog.service └ 2083 /sbin/rsyslogd -c 5 -f /etc/rsyslog.conf [syslog-ng from Base:System, due to a typo in spec file causing incorrect modules.conf on RC1 (bnc##664931#c5)]. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c23 Marius Tomaschewski changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|656259 | --- Comment #23 from Marius Tomaschewski 2011-02-10 15:20:32 UTC --- Removed the bnc#656259 dependency to be able to close this bug. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c25 --- Comment #25 from Dr. Werner Fink 2011-02-11 08:42:55 UTC --- (In reply to comment #22)

What would make sense is to try to add the functionality to forward [inherit] the sockets to a child into upstream code. Further, also to add an option to sd_listen_fds to not set FD_CLOEXEC flags (or add a variant of the function avoiding this), so we can use these functions in startproc and in fork code of the daemons...

I could try to remove FD_CLOEXEC in closefds() as I use this function to set this flag for all other file descriptors. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=656104 https://bugzilla.novell.com/show_bug.cgi?id=656104#c27 --- Comment #27 from Kay Sievers 2011-02-11 18:13:00 UTC --- (In reply to comment #26)

I'll not make anything from now on until the systemd maintainer starts working himself a bit. It is "his" feature.

What do you mean? "I" don't need any feature from syslog. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.