[Bug 523350] New: ash-1.6.1-137.5: 2 * missing calls to fclose
http://bugzilla.novell.com/show_bug.cgi?id=523350 Summary: ash-1.6.1-137.5: 2 * missing calls to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package ash-1.6.1-137.5 For source code sh-1.6.1/mknodes.c, around line 276 is the function output. 1. For local variable hfile, there seems to be a call to fclose missing. This could cause buffered data to be lost. 2. For local variable patfile, there is no call to fclose. This is a resource leak. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=523350 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |hare@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=523350 User hare@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=523350#c1 Hannes Reinecke <hare@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Hannes Reinecke <hare@novell.com> 2009-07-20 01:09:07 MDT --- Argl. Is anyone still using this? Can't we just drop it? I'd be really glad to see it go ... -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=523350 User dcb314@hotmail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=523350#c2 --- Comment #2 from David Binderman <dcb314@hotmail.com> 2009-08-21 16:25:59 MDT --- (In reply to comment #1)
Argl. Is anyone still using this? Can't we just drop it?
I'd be really glad to see it go ...
I don't know what the process is for a package to be retired. I can tell you that the same file, same function, there is a third variable "cfile" that has the same problem. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=523350 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=523350#c3 --- Comment #3 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:54:29 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=523350 https://bugzilla.novell.com/show_bug.cgi?id=523350#c4 Hannes Reinecke <hare@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED Target Milestone|--- |Future 11.3 --- Comment #4 from Hannes Reinecke <hare@novell.com> 2011-03-09 11:22:30 UTC --- I have updated the ash rpm in Factory to the version found in NetBSD 5.1. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com