[Bug 712171] New: openSUSE:Tools/spec-cleaner: frivolous %make_install breaks SLE_11_SP1
https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c0 Summary: openSUSE:Tools/spec-cleaner: frivolous %make_install breaks SLE_11_SP1 Classification: openSUSE Product: openSUSE.org Version: unspecified Platform: x86-64 OS/Version: openSUSE 11.4 Status: NEW Severity: Normal Priority: P5 - None Component: 3rd party software AssignedTo: adrian@novell.com ReportedBy: giecrilj@stegny.2a.pl QAContact: opensuse-communityscreening@forge.provo.novell.com Found By: Community User Blocker: --- spec-cleaner replaces
make install DESTDIR=${RPM_BUILD_ROOT} with %make_install
This trick breaks the build for SLE_11_SP1. + %make_install /var/tmp/rpm-tmp.59594: line 45: fg: no job control -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c1 --- Comment #1 from Christopher Yeleighton <giecrilj@stegny.2a.pl> 2011-08-13 08:13:04 UTC --- Workaround: %if 0%{!?make_install:1} %define make_install make install 'DESTDIR=%{buildroot}' %endif -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c Adrian Schröter <adrian@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|adrian@suse.com |vuntz@suse.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c2 --- Comment #2 from Joop Boonen <joop.boonen@boonen.org> 2012-05-14 15:14:19 UTC --- I think a fix is needed either at OBS ( add macro %make_install to SLE ) or at spec-cleaner ( translate to %makeinstall in stead of %make_install )? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c3 --- Comment #3 from Vincent Untz <vuntz@suse.com> 2012-05-14 15:24:14 UTC --- For reference, I think the right fix would be to add an option to control whether we want to target old rpm (like in SLE) or not. By default, spec-cleaner doesn't care about old rpm. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c4 --- Comment #4 from Joop Boonen <joop.boonen@boonen.org> 2012-05-14 16:10:16 UTC --- Wouldn't it be best to generate a spec file that works on all supported SUSE versions openSUSE and SLES? Does a list exist with the incompatibilities of spec cleaner like %make_install? Than a packager can change the spec file accordingly. I think spec cleaner is very helpful. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c5 --- Comment #5 from Joop Boonen <joop.boonen@boonen.org> 2012-05-14 16:26:58 UTC --- Is adding, the purposed work surround by Christopher, to spec-cleaner a solution? %if 0%{!?make_install:1} %define make_install make install 'DESTDIR=%{buildroot}' %endif -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c6 --- Comment #6 from Vincent Untz <vuntz@suse.com> 2012-05-14 16:31:33 UTC --- (In reply to comment #4)
Wouldn't it be best to generate a spec file that works on all supported SUSE versions openSUSE and SLES?
No, because that would go against the goal of spec-cleaner (ie, cleaning a spec file to use the latest correct packaging policies). The suggestion from comment 5, for instance, is too noisy for a cleaned .spec file, imho. But again, adding a profile to target SLE would be acceptable to me.
Does a list exist with the incompatibilities of spec cleaner like %make_install?
I'm not aware of such a list, but that would certainly be helpful. Help welcome :-) [also, keep in mind that it's highly recommended to not blindly trust spec-cleaner -- the changes it does should be double-checked, because there might be some bugs] -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c7 Juergen Weigert <jw@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jw@suse.com --- Comment #7 from Juergen Weigert <jw@suse.com> 2013-02-05 21:22:18 UTC --- I agree that the folling statements make sense: * It is not spec-cleaners goal to add cruft automatically. * It is also not spec-cleaners goal to force packagers to manually add cruft. *The build service also does not want to provide modern definitions to old distros, because then packages would break unexpectedly when built out of build service. But none of these statements forces us to prepare the same traps over and over again. Suggestion: Lets start a package "obs-portable-macros", that provides all the fancy macros, for *all* distros in a non-intrusive way. Maybe even print warnings if a maccro is already defined, and differs. Helpful? Doable? Benefit: Spec-cleaner could assert to BuildRequire obs-portable-macros, whenever it sees one of the nice macros being used, or when it wants to introduce one of these macros itself. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c8 Vincent Untz <vuntz@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tchvatal@suse.com AssignedTo|vuntz@suse.com |tcech@suse.com --- Comment #8 from Vincent Untz <vuntz@suse.com> 2013-10-21 12:54:57 UTC --- Tomáš is reviving spec-cleaner at https://github.com/openSUSE/spec-cleaner so reassigning the bugs to him. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=712171 https://bugzilla.novell.com/show_bug.cgi?id=712171#c9 Tomáš Chvátal <tchvatal@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #9 from Tomáš Chvátal <tchvatal@suse.com> 2014-01-26 21:07:04 UTC --- The thing should be addressed in 0.5 series. Firstly it uses make install DESTDIR... But if you us %make_install it lets you keep it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com