[Bug 525399] New: hercules-20080407-36.7: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=525399 Summary: hercules-20080407-36.7: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package hercules-20080407-36.7 For source code file hercules/ctc_lcs.c around line 2050 is the source code for the function BuildOAT. I notice the following line of code fp = fopen( pathname, "r" ); but no corresponding call to fclose. This looks like a resource leak to me. Suggest add call to fclose. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525399 Dirk Mueller <dmueller@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |uli@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525399 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=525399#c1 --- Comment #1 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:54:49 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=525399 http://bugzilla.novell.com/show_bug.cgi?id=525399#c2 Ulrich Hecht <uli@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |UPSTREAM --- Comment #2 from Ulrich Hecht <uli@novell.com> 2010-08-04 16:39:29 UTC --- That issue still exists upstream (3.07), needs to be fixed there. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com