[Bug 529468] New: pbbuttonsd-0.8.1a-110.15: missing call to closedir
http://bugzilla.novell.com/show_bug.cgi?id=529468 Summary: pbbuttonsd-0.8.1a-110.15: missing call to closedir Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package pbbuttonsd-0.8.1a-110.15 For source code file pbbuttonsd-0.8.1a/src/driver_backlight_sysfs.c around line 190 is the source code for the function driver_backlight_sysfs_init. I notice the following line of code if ((dh = opendir(sysfs_backlight_path->str))) { but I notice no matching call to closedir. This looks like a resource leak to me. Suggest code rework. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529468 shuang qiu <sqiu@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sqiu@novell.com AssignedTo|bnc-team-screening@forge.pr |schwab@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529468 shuang qiu <sqiu@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |stefan.fent@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=529468 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=529468#c2 --- Comment #2 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:54:55 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=529468 https://bugzilla.novell.com/show_bug.cgi?id=529468#c3 Stefan Fent <stefan.fent@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |WONTFIX --- Comment #3 from Stefan Fent <stefan.fent@suse.com> 2013-02-11 12:36:33 UTC --- No change upstream since 2007 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com