http://bugzilla.novell.com/show_bug.cgi?id=524523 Summary: brp check misses warnings it cought in openSUSE 11.1 Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Development AssignedTo: pth@novell.com ReportedBy: dominique.leuenberger@tmf-group.com QAContact: qa@suse.de Found By: --- User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.0) Gecko/20090623 SUSE/3.5.0-4.2 Firefox/3.5 I was wondering why brp-checks are sometimes less strict On Factory than they are on 11.1. Look at this short excerpt from a buildlog: src/skin_main.cpp: In function 'void* Run(void*)': src/skin_main.cpp:347: warning: control reaches end of non-void function src/skin_main.cpp: At global scope: src/skin_main.cpp:457: warning: 'int onSystrayChange(vlc_object_t*, const char*, vlc_value_t, vlc_value_t, void*)' defined but not used src/skin_main.cpp:492: warning: 'int onTaskBarChange(vlc_object_t*, const char*, vlc_value_t, vlc_value_t, void*)' defined but not used Ok, we all agree what the compiler warns about here. In 11.1, this is raised to an error: I: Program returns random data in a function E: $pkg no-return-in-nonvoid-function src/skin_main.cpp:347 In 11.2 this passes cleanly the brp check (even though the compiler still warns on it). Now what would be the proper behavior? what 11.2 (aka Factory at the moment) does or what 11.1 does? Having a 'reaches end of non-void' on a function declared as void* looks weird anyhow :) but that's another story. If the 11.2 behavior is correct: how can I get 11.1 ignore this specific error? (I don't want to completely disable brp-checks. I got to love them). If the 11.1 behavior is correct: why did this vanish from the brp on Factory? Reproducible: Always http://lists.opensuse.org/opensuse-buildservice/2009-07/msg00229.html -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.