[Bug 689468] New: fuse: fails to parse octal escape codes
https://bugzilla.novell.com/show_bug.cgi?id=689468 https://bugzilla.novell.com/show_bug.cgi?id=689468#c0 Summary: fuse: fails to parse octal escape codes Classification: openSUSE Product: openSUSE 11.4 Version: Final Platform: All OS/Version: Linux Status: NEW Severity: Minor Priority: P5 - None Component: Development AssignedTo: mszeredi@novell.com ReportedBy: jengelh@medozas.de QAContact: qa@suse.de Found By: Beta-Customer Blocker: --- The following piece of code will use a truncated fsname. /* just a testcase */ #define _FILE_OFFSET_BITS 64 #define FUSE_USE_VERSION 26 #include <stdio.h> #include <fuse.h> int main(int argc, char **argv) { int new_argc = 0; char *new_argv[8]; new_argv[new_argc++] = argv[0]; new_argv[new_argc++] = "-f"; new_argv[new_argc++] = "-osubtype=davlike,fsname=http://user\\054project@dav.company.com/"; new_argv[new_argc++] = "./mnt"; // something that belongs to us new_argv[new_argc] = NULL; return fuse_main(new_argc, new_argv, NULL, NULL); } /proc/self/mounts: http://user054project@dav.company.com/ /home/jengelh/code/ldapfuse/src/mnt fuse.davlike rw,nosuid,nodev,relatime,user_id=25121,group_id=27072 0 0 I notice that \\, would be interpreted, but in fstab \\377-style octal values seem to be used in preference to \\,. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=689468 https://bugzilla.novell.com/show_bug.cgi?id=689468#c1 --- Comment #1 from Miklos Szeredi <mszeredi@novell.com> 2012-01-02 17:18:41 UTC --- Created an attachment (id=469452) --> (http://bugzilla.novell.com/attachment.cgi?id=469452) proposed patch It doesn't seem a terribly important feature. But well, why not... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=689468 https://bugzilla.novell.com/show_bug.cgi?id=689468#c Miklos Szeredi <mszeredi@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mszeredi@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=689468 https://bugzilla.novell.com/show_bug.cgi?id=689468#c2 --- Comment #2 from Jan Engelhardt <jengelh@medozas.de> 2012-01-03 10:58:42 UTC --- This is important because if /proc/self/mounts does not show the same value as the input mountspec, the is-already-mounted check in pam_mount fails. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=689468 https://bugzilla.novell.com/show_bug.cgi?id=689468#c3 --- Comment #3 from Miklos Szeredi <mszeredi@novell.com> 2012-01-03 15:14:58 UTC --- (In reply to comment #2)
This is important because if /proc/self/mounts does not show the same value as the input mountspec, the is-already-mounted check in pam_mount fails.
Not sure I understand, /proc/self/mounts will show the comma unescaped. So some kind of transformation is needed anyway. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=689468 https://bugzilla.novell.com/show_bug.cgi?id=689468#c4 Miklos Szeredi <mszeredi@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |jengelh@medozas.de --- Comment #4 from Miklos Szeredi <mszeredi@novell.com> 2012-01-26 08:53:10 UTC --- Can you please explain exactly what bug will this fix and how? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=689468 https://bugzilla.novell.com/show_bug.cgi?id=689468#c5 Jan Engelhardt <jengelh@medozas.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|jengelh@medozas.de | --- Comment #5 from Jan Engelhardt <jengelh@medozas.de> 2012-01-26 22:18:39 UTC --- I think this was so that umount by device name works again. And/or cosmetics. I don't remember, you should have asked me that 21 months ago :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=689468 https://bugzilla.novell.com/show_bug.cgi?id=689468#c6 Miklos Szeredi <mszeredi@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #6 from Miklos Szeredi <mszeredi@novell.com> 2012-01-27 15:43:30 UTC --- Okay. Based on the fact that it doesn't add a huge amount of complexity and does make sense on some level I've committed the change. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com