[Bug 545268] New: x11vnc-0.9.8-1.5: two redundant calls to open
http://bugzilla.novell.com/show_bug.cgi?id=545268 Summary: x11vnc-0.9.8-1.5: two redundant calls to open Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: X11 Applications AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package x11vnc-0.9.8-1.5 source code file x11vnc-0.9.8/x11vnc/screen.c function initialize_raw_fb line number 1493 local variable is fd. I notice the following code fd = open(tmp, O_WRONLY); unlink_me = strdup(tmp); sprintf(str, "map:%s@%dx%dx32", tmp, w, h); raw_fb_str = strdup(str); } else if (strstr(raw_fb_str, "swirl") == raw_fb_str) { The call to open looks redundant, because fd is a local variable. Suggest remove call to open. The same thing happens a little later, around line 1515 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=545268 Andreas Jaeger <aj@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |garloff@novell.com |ovo.novell.com | Summary|x11vnc-0.9.8-1.5: two |JJ: x11vnc-0.9.8-1.5: two |redundant calls to open |redundant calls to open -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=545268 User garloff@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=545268#c1 Kurt Garloff <garloff@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Kurt Garloff <garloff@novell.com> 2009-10-15 05:59:50 MDT --- I'll have a look along with bug 542495, thanks. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=545268 User garloff@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=545268#c2 --- Comment #2 from Kurt Garloff <garloff@novell.com> 2009-10-15 06:29:22 MDT --- I agree that the open call looks bogus -- it has the side-effect of creating the file, but it exists already, so that does not look right either. The author could further rely on open() returning file descriptors in order (most commonly used for stdin(0), stdout(1) and stderr(2), but I don't see that either. The code looks like it leaks FDs -- I'll see whether I can do some tracing and see that happening. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=545268 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=545268#c3 --- Comment #3 from Richard Guenther <rguenther@novell.com> 2009-10-17 08:56:17 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=545268 https://bugzilla.novell.com/show_bug.cgi?id=545268#c Dirk Mueller <dmueller@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |pascal.bleser@opensuse.org |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com