[Bug 1173319] New: Move /etc/logrotate.d/* to /usr/etc/logrotate.d
https://bugzilla.suse.com/show_bug.cgi?id=1173319 Bug ID: 1173319 Summary: Move /etc/logrotate.d/* to /usr/etc/logrotate.d Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: screening-team-bugs@suse.de Reporter: sndirsch@suse.com QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- I'm currently working on the config file switch /etc --> /usr/etc (find Details on https://en.opensuse.org/openSUSE:Packaging_UsrEtc) and now I'm wondering what should be done with /etc/logrotate.d/* files. Thorsten Kukuk: Somebody need to rewrite logrotate first. ;-) -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 https://bugzilla.suse.com/show_bug.cgi?id=1173319#c1 Stefan Dirsch <sndirsch@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crrodriguez@opensuse.org, | |dmueller@suse.com, | |pmonrealgonzalez@suse.com --- Comment #1 from Stefan Dirsch <sndirsch@suse.com> --- Adding maintainers of logrotate to Cc -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 Stefan Dirsch <sndirsch@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1173049 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 Stefan Dirsch <sndirsch@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1173048 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 Stefan Dirsch <sndirsch@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|1173048 | -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 https://bugzilla.suse.com/show_bug.cgi?id=1173319#c2 --- Comment #2 from Pedro Monreal Gonzalez <pmonrealgonzalez@suse.com> --- Just for reference, see also the opensuse-factory ML thread: https://lists.opensuse.org/opensuse-factory/2020-06/msg00248.html -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 Pedro Monreal Gonzalez <pmonrealgonzalez@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|screening-team-bugs@suse.de |pmonrealgonzalez@suse.com -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 https://bugzilla.suse.com/show_bug.cgi?id=1173319#c3 --- Comment #3 from Stefan Dirsch <sndirsch@suse.com> --- Pedro, any plans to look into this? Just to make sure, I'm not planning to implement this. I just need it for some of my packages. ;-) Others need it as well for sure .... -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 https://bugzilla.suse.com/show_bug.cgi?id=1173319#c4 --- Comment #4 from Pedro Monreal Gonzalez <pmonrealgonzalez@suse.com> --- We were discussing this in the packaging team but I'm not yet sure how to do it, especially with the files in /etc/logrotate.d/*. Lots of packages would need to be adapted with this change. Variant 1 should be applied here. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 https://bugzilla.suse.com/show_bug.cgi?id=1173319#c5 --- Comment #5 from Stefan Dirsch <sndirsch@suse.com> --- (In reply to Pedro Monreal Gonzalez from comment #4)
We were discussing this in the packaging team but I'm not yet sure how to do it, especially with the files in /etc/logrotate.d/*. Lots of packages would need to be adapted with this change.
So what? I would be happy to adjsut all affected files of my pacckages.
Variant 1 should be applied here.
Yes, of course. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 https://bugzilla.suse.com/show_bug.cgi?id=1173319#c6 --- Comment #6 from Pedro Monreal Gonzalez <pmonrealgonzalez@suse.com> --- (In reply to Stefan Dirsch from comment #5)
From [https://build.opensuse.org/package/view_file/Base:System/logrotate/logrotate...], there is this directory where packages write their rotation info: # RPM packages drop log rotation information into this directory include /etc/logrotate.d Also the systemd files, to which .conf file should they point to? ExecStart=/usr/sbin/logrotate /etc/logrotate.conf
Variant 1 should be applied here.
Yes, of course.
-- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 https://bugzilla.suse.com/show_bug.cgi?id=1173319#c7 --- Comment #7 from Stefan Dirsch <sndirsch@suse.com> --- Yeah. That's why Thorsten Kukuk wrote: "Somebody need to rewrite logrotate first. ;-)". -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 https://bugzilla.suse.com/show_bug.cgi?id=1173319#c14 Stefan Schubert <schubi@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(genes1122@gmail.c | |om) --- Comment #14 from Stefan Schubert <schubi@suse.com> --- (In reply to Gene Snider from comment #12)
-- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 https://bugzilla.suse.com/show_bug.cgi?id=1173319#c15 Stefan Schubert <schubi@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(genes1122@gmail.c | |om) | --- Comment #15 from Stefan Schubert <schubi@suse.com> --- (In reply to Stefan Schubert from comment #14)
Not needed anymore. I can reproduce this bug. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 https://bugzilla.suse.com/show_bug.cgi?id=1173319#c16 Stefan Schubert <schubi@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #16 from Stefan Schubert <schubi@suse.com> --- https://build.opensuse.org/request/show/1003701 ------------------------------------------------------------------- Wed Sep 14 11:15:55 UTC 2022 - Stefan Schubert <schubi@suse.com> Ignoring vendor logs settings in /usr/etc/logrotate.d if they have already been defined by the the admin in the /etc/logrotate.d directory (bsc#1173319). ------------------------------------------------------------------- I have also removed the "include" in logrotate.conf because it will be handled in logrotate.service. Thanks for the hints ! :-) -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 https://bugzilla.suse.com/show_bug.cgi?id=1173319#c18 David Anes <david.anes@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.anes@suse.com Flags| |needinfo?(schubi@suse.com) --- Comment #18 from David Anes <david.anes@suse.com> --- While performing an update to latest version of logrotate in Factory, I found a new feature is implemented: * https://github.com/logrotate/logrotate/pull/473 @Stefan, do you mind to review the patch you introduced[1] (or remove it entirely) from TW by using that feature? I prefer to ask than breaking something that took so long to fix. Thanks. [1] https://build.opensuse.org/package/rdiff/Base:System/logrotate?linkrev=base&rev=103 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1173319 https://bugzilla.suse.com/show_bug.cgi?id=1173319#c19 Stefan Schubert <schubi@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(schubi@suse.com) | --- Comment #19 from Stefan Schubert <schubi@suse.com> --- (In reply to David Anes from comment #18)
The question is how LOG_FLAG_IGNOREDUPLICATES is set. If this flag is set when ENABLE_VENDORDIR has also been set then there is a chance to drop the patch because you can manage it in the configure.ac script outside of the code. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@suse.com