[Bug 543153] New: deb-1.15.0-13.11.: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=543153 Summary: deb-1.15.0-13.11.: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package deb-1.15.0-13.11. source code file dpkg-1.15.0/dpkg-deb/info.c function info_field local variable cc. I notice the following code if (!(cc= fopen("control","r"))) ohshite(_("could not open the `control' component")); but I fail to notice a matching call to fclose. This looks like a resource leak to me. Suggest add call to fclose near the end of the function. I would like to note the somewhat exotic name of the error handling routine. Some more sensitive members of the community may prefer a more sober name. Just an idea. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543153 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |puzel@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543153 User puzel@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=543153#c1 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |UPSTREAM --- Comment #1 from Petr Uzel <puzel@novell.com> 2009-10-01 07:10:02 MDT --- Patch sent to upstream.
I would like to note the somewhat exotic name of the error handling routine. Some more sensitive members of the community may prefer a more sober name. Just an idea.
OK, but it has nothing to do with SUSE - you can discuss it with dpkg developers. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com