[Bug 689006] New: Init scripts of "kadmin" and "krb5kdc" are not fully LSB compliant
https://bugzilla.novell.com/show_bug.cgi?id=689006 https://bugzilla.novell.com/show_bug.cgi?id=689006#c0 Summary: Init scripts of "kadmin" and "krb5kdc" are not fully LSB compliant Classification: openSUSE Product: openSUSE 11.4 Version: Final Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Network AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: joschibrauchle@gmx.de QAContact: qa@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.16) Gecko/20110324 SUSE/3.6.16-0.2.1 Firefox/3.6.16 The init scripts of "kadmind" and "krb5kdc" are not fully LSB compliant. When the configuration file /etc/krb5.conf is not found in the beginning of the init script, it returns exit code 0 with message "Error. Default principal database does not exist." This is not the correct exit code, as 0 suggest the service start ok. Rather it should return exit code "6" with status "unconfigured". The problematic code is: -------------------------- start() { if [ ! -f $krbdir/principal ] ; then # Make an educated guess -- if they're using kldap somewhere, # then we don't know for sure that this is an error. if ! grep -q 'db_library.*=.*kldap' /etc/krb5.conf ; then echo "Error. Default principal database does not exist." exit 0 fi fi if [ -f $krbdir/kpropd.acl ] ; then echo "This seems to be a slave server, found kpropd.acl" exit 0 else .... -------------------------- Suggested change: -------------------------- start() { if [ ! -f $krbdir/principal ] ; then # Make an educated guess -- if they're using kldap somewhere, # then we don't know for sure that this is an error. if ! grep -q 'db_library.*=.*kldap' /etc/krb5.conf ; then echo "Error. Default principal database does not exist." rc_failed 6 rc_exit # exit 0 fi fi if [ -f $krbdir/kpropd.acl ] ; then echo "This seems to be a slave server, found kpropd.acl" # This still needs to be fixed! 0 is probably not the correct exit code here. exit 0 else ... -------------------------- Reproducible: Always Steps to Reproduce: 1. Link /etc/krb5.conf to a file on a DRBD device. 2. Unmount the DRBD device. 3. Start kadmind with "rckadmind start" Actual Results: Exit code 0 is returned, although the service is not configured. Expected Results: It should return the correct status "unconfigured" with exit code 6. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=689006
https://bugzilla.novell.com/show_bug.cgi?id=689006#c
zj jia
https://bugzilla.novell.com/show_bug.cgi?id=689006
https://bugzilla.novell.com/show_bug.cgi?id=689006#c
Michael Calmer
https://bugzilla.novell.com/show_bug.cgi?id=689006
https://bugzilla.novell.com/show_bug.cgi?id=689006#c1
Michael Calmer
https://bugzilla.novell.com/show_bug.cgi?id=689006
https://bugzilla.novell.com/show_bug.cgi?id=689006#c2
--- Comment #2 from Bernhard Wiedemann
participants (1)
-
bugzilla_noreply@novell.com