[Bug 713126] New: mkinitrd puts duplicated firmware files in initrd
https://bugzilla.novell.com/show_bug.cgi?id=713126 https://bugzilla.novell.com/show_bug.cgi?id=713126#c0 Summary: mkinitrd puts duplicated firmware files in initrd Classification: openSUSE Product: openSUSE 12.1 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: tiwai@novell.com QAContact: qa@suse.de Found By: --- Blocker: --- When multiple firmware files are present in the system (e.g. when multiple kernels are installed), mkinitrd puts all firmware files into an initrd although only one of them is actually needed. The patch below is an attempt for fix. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=713126 https://bugzilla.novell.com/show_bug.cgi?id=713126#c1 --- Comment #1 from Takashi Iwai <tiwai@novell.com> 2011-08-19 11:27:02 UTC --- Created an attachment (id=446623) --> (http://bugzilla.novell.com/attachment.cgi?id=446623) Fix patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=713126 https://bugzilla.novell.com/show_bug.cgi?id=713126#c zj jia <zjjia@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zjjia@novell.com AssignedTo|bnc-team-screening@forge.pr |mmarek@novell.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=713126 https://bugzilla.novell.com/show_bug.cgi?id=713126#c2 Olaf Hering <ohering@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |tiwai@suse.com --- Comment #2 from Olaf Hering <ohering@suse.com> 2013-07-31 17:25:18 CEST --- I think this is already fixed. Do you still see it with current Factory or 12.3? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=713126 https://bugzilla.novell.com/show_bug.cgi?id=713126#c3 --- Comment #3 from Olaf Hering <ohering@suse.com> 2013-08-04 16:26:47 CEST --- The initial issue is maybe fixed. Current Factory still puts duplicate files, once in /lib/firmware and once in /usr/lib/firmware. The reason is the symlink /usr/lib/firmware from udev.rpm. This patch avoids the duplicate files, and the duplicate output. index 4736709..6fda9ea 100644 --- a/scripts/setup-modules.sh +++ b/scripts/setup-modules.sh @@ -320,6 +320,10 @@ fi # Copy all modules into the initrd has_firmware=false +declare -A fw_array +mkdir -p $tmp_mnt/lib/firmware +mkdir -p $tmp_mnt/usr/lib +ln -sfbn ../../lib/firmware $tmp_mnt/usr/lib/firmware for module in $resolved_modules; do if [ ! -r $root_dir/$module ]; then oops 9 "Module $module not found." @@ -340,7 +344,11 @@ for module in $resolved_modules; do echo -ne "Firmware:\t" has_firmware=true fi - echo -n "$fw " + if test -z "${fw_array[$fw]}" + then + fw_array[$fw]=$fw + echo -n "$fw " + fi if test -e "$dir/$subdir/$fw.sig"; then cp -p --parents "$_" "$tmp_mnt" echo -n "$fw.sig " -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=713126 https://bugzilla.novell.com/show_bug.cgi?id=713126#c4 --- Comment #4 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-08-04 16:00:08 UTC --- This is an autogenerated message for OBS integration: This bug (713126) was mentioned in https://build.opensuse.org/request/show/185843 Factory / mkinitrd -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=713126 https://bugzilla.novell.com/show_bug.cgi?id=713126#c4 --- Comment #4 from Bernhard Wiedemann <bwiedemann@suse.com> 2013-08-04 18:00:08 CEST --- This is an autogenerated message for OBS integration: This bug (713126) was mentioned in https://build.opensuse.org/request/show/185843 Factory / mkinitrd -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=713126 https://bugzilla.novell.com/show_bug.cgi?id=713126#c5 Takashi Iwai <tiwai@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|tiwai@suse.com | --- Comment #5 from Takashi Iwai <tiwai@suse.com> 2013-08-05 08:16:15 UTC --- Yes, the original problem was already fixed in the recent version. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=713126 https://bugzilla.novell.com/show_bug.cgi?id=713126#c6 Olaf Hering <ohering@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #6 from Olaf Hering <ohering@suse.com> 2013-08-05 15:35:24 CEST --- Closing. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com