https://bugzilla.novell.com/show_bug.cgi?id=774226 https://bugzilla.novell.com/show_bug.cgi?id=774226#c1 Andreas Jaeger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fcrozat@suse.com AssignedTo|bnc-team-screening@forge.pr |trenn@suse.com |ovo.novell.com | --- Comment #1 from Andreas Jaeger 2012-08-03 08:47:56 UTC --- What is the error message you get? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=774226 https://bugzilla.novell.com/show_bug.cgi?id=774226#c4 Thomas Renninger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |fcrozat@suse.com --- Comment #4 from Thomas Renninger 2012-08-14 10:43:51 UTC --- Ok, this is about: ExecStart=/usr/sbin/mcelog --ignorenodev --daemon --foreground --email $MCELOG_ADMIN_EMAIL The Exec= line should call a script to test of MCELOG_ADMIN_EMAIL and add --email only if it isn't empty. But this would need starting another process which with systemd should get avoided whenever/wherever possible? This is one big advantage of systemd: Faster because not that much shell processes have to be initiated and scheduled. Wouldn't it be cleaner to remove --email $MCELOG_ADMIN_EMAIL and make mcelog be aware of an MCELOG_ADMIN_EMAIL environment variable? That's what EnvironmentFile=-/etc/sysconfig/mcelog is for and no further stuff is needed? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=774226 https://bugzilla.novell.com/show_bug.cgi?id=774226#c6 --- Comment #6 from Jon Nelson 2012-08-14 15:29:40 UTC --- I vote for a simple shell script wrapper. It has the following advantages: a) it solves the problem trivially b) it's easily auditable c) it does not require involvement of upstream d) it's quick. it can be 'fixed' in 10 minutes instead of waiting days or weeks for upstream downsides: a) it requires an additional exec. I don't consider the downside a big deal. How often does mcelog get started, anyway? Something like this (untested, but trival): #! /bin/sh if [ -e /etc/sysconfig/mcelog ]; then source /etc/sysconfig/mcelog fi ADDTL_ARGS="" if [ -n "$MCELOG_ADMIN_EMAIL" ]; then ADDTL_ARGS="--email $MCELOG_ADMIN_EMAIL" fi exec /usr/sbin/mcelog $ARGS $ADDTL_ARGS exit 1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.