[Bug 350635] New: glib2: Need patch review
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=350635 Summary: glib2: Need patch review Product: openSUSE 10.3 Version: Final Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: GNOME AssignedTo: federico@novell.com ReportedBy: mboman@novell.com QAContact: qa@suse.de CC: mboman@novell.com, mmeeks@novell.com Found By: --- Created an attachment (id=188678) --> (https://bugzilla.novell.com/attachment.cgi?id=188678) gutils.diff There seems to be excess calls to getenv when profiling Slab. They all originate from g_get_language_names in glib2. I've created a patch but don't know if it's sane, so need a patch review. Also attaching profile information from both Slab and gnome-menu-spec-test. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=350635
User mboman@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=350635#c1
--- Comment #1 from Magnus Boman
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=350635
User mboman@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=350635#c2
--- Comment #2 from Magnus Boman
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=350635
User mboman@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=350635#c3
--- Comment #3 from Magnus Boman
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=350635
User mboman@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=350635#c4
--- Comment #4 from Magnus Boman
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=350635
Magnus Boman
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=350635
User mmeeks@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=350635#c5
--- Comment #5 from Michael Meeks
![](https://seccdn.libravatar.org/avatar/3035b38ff33cf86f480bb169b8500b80.jpg?s=120&d=mm&r=g)
https://bugzilla.novell.com/show_bug.cgi?id=350635
User jpr@novell.com added comment
https://bugzilla.novell.com/show_bug.cgi?id=350635#c6
JP Rosevear
participants (1)
-
bugzilla_noreply@novell.com