[Bug 543135] New: cyrus-imapd-2.3.14-6.1: missing call to fclose
http://bugzilla.novell.com/show_bug.cgi?id=543135 Summary: cyrus-imapd-2.3.14-6.1: missing call to fclose Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package cyrus-imapd-2.3.14-6.1 source code file cyrus-imapd-2.3.14/imap/global.c function shutdown_file local variable f. I notice the following code if ((f = fopen(shutdownfilename, "r")) == NULL) return 0; but I fail to notice a matching call to fclose. This looks like a resource leak to me. Suggest add call to fclose near the end of the function. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543135 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |rhafer@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=543135 User rhafer@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=543135#c1 Ralf Haferkamp <rhafer@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #1 from Ralf Haferkamp <rhafer@novell.com> 2009-10-02 01:54:25 MDT --- fclose() is not needed here. If the shutdownfile can be opened the process that called shutdown_file() will terminate almost immediately. That's what the shutdown files are for. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com