http://bugzilla.novell.com/show_bug.cgi?id=1042726 http://bugzilla.novell.com/show_bug.cgi?id=1042726#c4 Larry Finger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Flags|needinfo?(Larry.Finger@lwfi | |nger.net) | --- Comment #4 from Larry Finger --- A VirtualBox installation on a host includes a script /sbin/vboxconfig that will install the necessary packages, build the host modules, and install them. A similar script /sbin/vboxguestconfig does the same operations for openSUSE guests. I believe these scripts meet your needs. If not, please re-open this bug. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=1042726 http://bugzilla.novell.com/show_bug.cgi?id=1042726#c6 Daniel Pecka changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #6 from Daniel Pecka --- JFYI: if [ ! $? ] ; then ^^ is wrong .. reopening, that script is just ``too much'' for my tastes and it even doesn't work (nor it could because of ...) did you test it ? anyhow, please fix your script -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=1042726 http://bugzilla.novell.com/show_bug.cgi?id=1042726#c8 --- Comment #8 from Daniel Pecka ---

...

3. Why is "if [ ! $? ] ; then" wrong? To me, that means to examine the status of the previously run command.

It's a logic (and semi-syntax) error and it is not going to work, it's just wrongly used test, will always be false:

[ 1 ] && echo ue ue

[ 0 ] && echo ue ue

you wanted to do [ "$?" -ne "0" ] or directlty ``if ! CMD; then BLOCK; fi''

...

5. If you wish to do things "your way", I am very willing to transfer the maintainership of VirtualBox to you. Keeping up with the rapid changes in both the Oracle version, and the demands of Leap 42.3 are more than I bargained for, and I would be happy to get rid of the work.

I have to politely refuse ... This won't work and I appreciate very much that ppl (like you) are doing a priceless time investment into open source techs. I simply don't have a time for that. now back to business, after doing ``> diff ./src/VBox/Installer/linux/vboxdrv.sh /etc/init.d/vboxdrv'' it's obvious, that only part of real code that changed is setup() function ... If original setup() function doesn't work my plan A would be to fix it to keep things simple ... and we're now returning in circles at the beginning, because original setup() function requires other scripts that are in $VBOXSRC/src/VBox/Installer/linux (eg check_module_dependencies.sh). regards, dan -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=1042726 http://bugzilla.novell.com/show_bug.cgi?id=1042726#c13 Larry Finger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #13 from Larry Finger --- As noted, the fix is available. -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=1042726 http://bugzilla.novell.com/show_bug.cgi?id=1042726#c16 Daniel Pecka changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #16 from Daniel Pecka --- Sorry for additional comment, I forgot to reopen that within my patch-providing comment ... regards, d -- You are receiving this mail because: You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=1042726 http://bugzilla.novell.com/show_bug.cgi?id=1042726#c18 --- Comment #18 from Daniel Pecka --- Hello, 1) okay, cool 2) Because it's too much and it can fail on many reasons. User can be connected via modem with FUP that he doesn't want to eat, whatever. This is just clear resolution to tell him what's wrong and what to fix and to re-running the script afterwards. 3) Nope, just think of that - it's logic - and I've hit exactly this case many times. I need this script working because I have kernel that has not available module for that and that's why one wants to use the script. # grep ^multiversion\\\.kernels /etc/zypp/zypp.conf multiversion.kernels = latest,latest-1,running,4.11.8-1.g42bd7a0-default,4.11.8-1.g42bd7a0,4.13.rc3.102.g26c5ceb-1.1.ga6978f6,4.13.0-rc3-102-g26c5ceb-1.ga6978f6-vanilla This only makes sure, that you have version of module sources matching the rest of the vbox so normally it won't happen. Many other users that I personally know have it like me - eg they have some custom kernel with module not available for that and they have to rebuild modules periodically. 4) Make clean is there for safe as a generic step. No need to make concerns about that. Weird things can happen when you're upping the code in same dir and rebuilding over and over. regards, dan -- You are receiving this mail because: You are on the CC list for the bug.