[Bug 781074] New: Legacy menus displayed incorrectly in cinnamon 1.5.8
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c0 Summary: Legacy menus displayed incorrectly in cinnamon 1.5.8 Classification: openSUSE Product: openSUSE 12.2 Version: Final Platform: All OS/Version: openSUSE 12.2 Status: NEW Severity: Normal Priority: P5 - None Component: GNOME AssignedTo: bnc-team-gnome@forge.provo.novell.com ReportedBy: hippolyte@shaw.ca QAContact: qa-bugs@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20100101 Firefox/15.0 Custom (tree) cinnamon-applications.menu is not parsed correctly under cinnamon 1.5.8. Several menus and most menu entries are missing. The same menu works well under Gnome fallback (this should exclude a syntax error in the menu). Reproducible: Always Steps to Reproduce: 1. just relace cinnamon-applications.menu with your own menu or set XDG_CONFIG_DIRS to an alternate location containing you own cinnamon-applications.menu and restart cinnamon. 2. If you just replace teh menu file without changing XDG_CONFIG_DIRS, there is no need to restart cinnamon. 3. Actual Results: Some menus and mots menu items are missing. The following warning appears in the log; JS ERROR: !!! WARNING: 'assignment to undeclared variable subdir' JS ERROR: !!! WARNING: file '/usr/share/cinnamon/applets/menu@cinnamon.org/applet.js' line 1298 exception 0 number 156 Expected Results: All menus and items are displayed. As a temporary workaround, using menu@cinnamon.org/applet.js from version 1.4.0 (copying this file to /usr/share/cinnamon/applets/menu@cinnamon.org/) would solve the menu issue (all menus and entries are displayed correctly) but produces this warning over and over: (cinnamon:2899): Clutter-WARNING **: Attempting to add actor of type 'CinnamonGenericContainer' to a container of type 'StBoxLayout', but the actor has already a parent of type 'StBoxLayout'. (cinnamon:2899): Clutter-WARNING **: Attempting to add actor of type 'StScrollView' to a container of type 'StBoxLayout', but the actor has already a parent of type 'StBoxLayout'. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c1 Bjørn Lie <zaitor@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zaitor@opensuse.org AssignedTo|bnc-team-gnome@forge.provo. |nmo.marques@gmail.com |novell.com | --- Comment #1 from Bjørn Lie <zaitor@opensuse.org> 2012-09-21 21:57:25 CEST --- Not gnome :-) Reassigning to Cinamon maintainer, -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c Bjørn Lie <zaitor@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|GNOME |Other -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c2 Nelson Marques <nmo.marques@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |hippolyte@shaw.ca AssignedTo|nmo.marques@gmail.com |hippolyte@shaw.ca --- Comment #2 from Nelson Marques <nmo.marques@gmail.com> 2012-09-21 20:22:27 UTC --- Could you please confirm if this happens with 1.6.0? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c3 --- Comment #3 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-09-22 03:09:29 UTC --- Yes it does. I used the same workaround (the menu applet from version 1.4.0). I took a quick look at this java script. It has been completely rewritten. Otherwise cinnamon seems to work at least with the nvidia driver (unlike version 1.4.0 that I had to recompile - if you remember). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c4 Nelson Marques <nmo.marques@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nmo.marques@gmail.com --- Comment #4 from Nelson Marques <nmo.marques@gmail.com> 2012-09-24 13:22:31 UTC --- Can you please provide us a sample of the custom menu ? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c5 Nelson Marques <nmo.marques@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|hippolyte@shaw.ca | AssignedTo|hippolyte@shaw.ca |nmo.marques@gmail.com --- Comment #5 from Nelson Marques <nmo.marques@gmail.com> 2012-09-24 13:26:48 UTC --- I've spoken with Clement from upstream about this issue; they are aware of this issue, and according to him the missing items in 'Administration' should be in 'Preferences'. This should be fixed in a future point release (1.6.x); The regression has been confirmed from 1.5.8 up till today. I'll leave the bug report opened for now, until we have cleared this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c6 Michael Webster <miketwebster@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |miketwebster@gmail.com --- Comment #6 from Michael Webster <miketwebster@gmail.com> 2012-09-24 14:17:19 UTC --- Do you have a .menu file that I could try to reproduce this with? Alternatively, could you try the following: Edit line 1298 of the menu applet.js file to begin with: let subdir ..... Thanks (In reply to comment #0)
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20100101 Firefox/15.0
Custom (tree) cinnamon-applications.menu is not parsed correctly under cinnamon 1.5.8. Several menus and most menu entries are missing. The same menu works well under Gnome fallback (this should exclude a syntax error in the menu).
Reproducible: Always
Steps to Reproduce: 1. just relace cinnamon-applications.menu with your own menu or set XDG_CONFIG_DIRS to an alternate location containing you own cinnamon-applications.menu and restart cinnamon. 2. If you just replace teh menu file without changing XDG_CONFIG_DIRS, there is no need to restart cinnamon. 3. Actual Results: Some menus and mots menu items are missing. The following warning appears in the log; JS ERROR: !!! WARNING: 'assignment to undeclared variable subdir' JS ERROR: !!! WARNING: file '/usr/share/cinnamon/applets/menu@cinnamon.org/applet.js' line 1298 exception 0 number 156
Expected Results: All menus and items are displayed.
As a temporary workaround, using menu@cinnamon.org/applet.js from version 1.4.0 (copying this file to /usr/share/cinnamon/applets/menu@cinnamon.org/) would solve the menu issue (all menus and entries are displayed correctly) but produces this warning over and over:
(cinnamon:2899): Clutter-WARNING **: Attempting to add actor of type 'CinnamonGenericContainer' to a container of type 'StBoxLayout', but the actor has already a parent of type 'StBoxLayout'.
(cinnamon:2899): Clutter-WARNING **: Attempting to add actor of type 'StScrollView' to a container of type 'StBoxLayout', but the actor has already a parent of type 'StBoxLayout'.
-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c7 Nelson Marques <nmo.marques@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |hippolyte@shaw.ca --- Comment #7 from Nelson Marques <nmo.marques@gmail.com> 2012-09-24 14:36:53 UTC --- Agnello, please test that out; If Michael suggestion fixes it, I will do a small patched release (if there are no further impacts) until we get the next point release :) THX -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c8 --- Comment #8 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-09-24 16:17:27 UTC --- Created an attachment (id=506791) --> (http://bugzilla.novell.com/attachment.cgi?id=506791) custom applications.menu cinnamon-applications.menu is a symlink pointing to this file. I use alternate XDG_CONFIG_DIRS and XDG_DATA_DIRS # echo $XDG_CONFIG_DIRS /usr/local/config/xdg:/etc/xdg # echo $XDG_DATA_DIRS /usr/local/share:/usr/share This menu works with the menu applet from version 1.4.0. It also works in Gnome fallback, Xfce and LXDE. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c9 --- Comment #9 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-09-24 16:24:16 UTC --- Addind "let" suppresses the error message but doesn't fix the menu. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c10 Nelson Marques <nmo.marques@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- InfoProvider|hippolyte@shaw.ca |miketwebster@gmail.com --- Comment #10 from Nelson Marques <nmo.marques@gmail.com> 2012-09-24 16:28:24 UTC --- Michael; Anyone you can replicate with the menu file submitted by the user and according to the information provided? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c11 --- Comment #11 from Nelson Marques <nmo.marques@gmail.com> 2012-09-24 16:29:23 UTC --- Michael; Anyone you can replicate with the menu file submitted by the user and according to the information provided? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c12 Michael Webster <miketwebster@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|miketwebster@gmail.com | --- Comment #12 from Michael Webster <miketwebster@gmail.com> 2012-09-24 16:33:57 UTC --- Got it reproduced with that file - thanks. I'll see what's causing it to crash and burn (I'm the one who re-did the applet so it must be my fault! :)) Thanks -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c13 --- Comment #13 from Nelson Marques <nmo.marques@gmail.com> 2012-09-24 16:44:59 UTC --- Michael, Thanks for following this in record time; Once you have a patch we can test, that would be most welcome. NM -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c14 --- Comment #14 from Michael Webster <miketwebster@gmail.com> 2012-09-24 23:27:37 UTC --- Just fyi, the fix for the missing Administration menu was committed today - https://github.com/linuxmint/Cinnamon/commit/4a94a90d3f458c385318cea571014b1... As far as the other issue goes, looks like it's some upstream change, I'm still figuring out what's been changed and how to handle it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c15 --- Comment #15 from Michael Webster <miketwebster@gmail.com> 2012-09-24 23:59:40 UTC --- So messed around a bit more - I installed 3.5.92 of gnome-menus, which allowed me to edit the menus using Cinnamon's alacarte port (right-click menu applet). If I manually added an item to one of the menus there, it would then show up in the applet. So, it's not that it refuses to show them, it's just that in Cinnamon's eyes, they're empty menu categories, so it hides them. I may need to set up a VM of exactly what's being run here just to have the proper perspective.. so, openSuse 12.2? ;) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c16 --- Comment #16 from Nelson Marques <nmo.marques@gmail.com> 2012-09-25 00:03:26 UTC --- Sounds good to me; My advice is to use the GNOME Live CD and then use our Meta Installer to just install the stuff... Here's the link: http://download.opensuse.org/repositories/X11:/Cinnamon:/GNOME34/12.2/cinnam... Enjoy :) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c17 --- Comment #17 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-09-25 01:28:41 UTC --- (In reply to comment #15)
So messed around a bit more - I installed 3.5.92 of gnome-menus, which allowed me to edit the menus using Cinnamon's alacarte port (right-click menu applet).
Just for info, I never do that. My menus are defined at system level, not at user level.
If I manually added an item to one of the menus there, it would then show up in the applet. So, it's not that it refuses to show them, it's just that in Cinnamon's eyes, they're empty menu categories, so it hides them.
Notice that you don't have these categories, because I created them ... but some menu entries I use (.desktop files) belong to several categories, i.e predefined ones and custom ones. This may be why I see some entries but not all. My menu file only uses my categories and desktop files and directories from an alternate location (/usr/local/share/applications and /usr/local/share/desktop-directories). For example, I'm not using this file at all: # cat /usr/share/applications/gnome-terminal.desktop [Desktop Entry] X-SuSE-translate=true GenericName=Terminal DocPath=gnome-terminal Name=GNOME Terminal Comment=Use the command line TryExec=gnome-terminal Exec=gnome-terminal Icon=utilities-terminal Type=Application X-GNOME-DocPath=gnome-terminal/index.html X-GNOME-Bugzilla-Bugzilla=GNOME X-GNOME-Bugzilla-Product=gnome-terminal X-GNOME-Bugzilla-Component=BugBuddyBugs X-GNOME-Bugzilla-Version=3.4.1.1 Categories=GNOME;GTK;Utility;TerminalEmulator; StartupNotify=true but this file instead: # cat /usr/local/share/applications/X_gnome-terminal.desktop [Desktop Entry] X-SuSE-translate=true GenericName=Command Line Terminal DocPath=gnome-terminal Name=GNOME Terminal Comment=Use the command line TryExec=gnome-terminal Exec=gnome-terminal --geometry=104x44 Icon=utilities-terminal Type=Application X-GNOME-DocPath=gnome-terminal/index.html X-GNOME-Bugzilla-Bugzilla=GNOME X-GNOME-Bugzilla-Product=gnome-terminal X-GNOME-Bugzilla-Component=BugBuddyBugs X-GNOME-Bugzilla-Version=3.4.1.1 Categories=X-Main-Terminals; StartupNotify=true Notice the category "X-Main-Terminals" which won't exist for you. I apologize for organizing menus differently. Could it be that you're just ignoring my categopries? ~~~~~~~~~~~~~~ One more thing: submenus are not supported, thus menus appear "flat" in cinnamon. It's a bummer. Any chance you could re-implement the classic tree model for cinnamon somehow? It would make lots of users happy IMO. See the "funny" xslt filter I wrote to "work around" the flat menu in gnome-shell: http://forums.opensuse.org/english/other-forums/development/programming-scri.... But in this example, I used the default menus (reset XDG_DATA_DIRS and XDG_CONFIG_DIRS) My menus are more consistent. :-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c18 --- Comment #18 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-09-25 01:53:59 UTC --- I think that's the problem. If I replace Categories=X-Main-Terminals; with Categories=System;FileManager;X-Main; in gnome-terminal, it will show up under "Main" (which is again one of my custom menus). You're just looking for predefined categories. Or at least you're not looking for "unexpected" custom ones. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c19 --- Comment #19 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-09-25 02:06:20 UTC ---
I may need to set up a VM of exactly what's being run here just to have the proper perspective..
You don't need to do that. Just create a directory /usr/local/share/applications (for example) and copy some .desktop files from /usr/share/applications into that directory. Set Categories in (some) of these .desktop files to match (some) categories imported in the menu file I provided. Make sure that XDG_DATA_DIRS looks in /usr/local/share first. Have some .desktop files using 'only' my categories and some other using both, like 'well known' categories and custom ones. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c20 --- Comment #20 from Nelson Marques <nmo.marques@gmail.com> 2012-09-27 16:15:33 UTC --- JFY cinnamon and muffin have been updated to a bugfix point release (mutter: 1.1.1 and Cinnamon: 1.6.1). The Cinnamon team doesn't make public the contents of the update; I do not expect this to be fixed yet. Nevertheless, the updates are live. $ sudo zypper ref && zypper update -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c21 --- Comment #21 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-09-29 01:01:57 UTC --- The menu issue is not fixed. It looks like somebody tried though. # diff -u applet.js.1.6.0 applet.js --- applet.js.1.6.0 2012-09-18 14:23:51.936298882 -0700 +++ applet.js 2012-09-27 09:05:05.000000000 -0700 @@ -1274,7 +1274,7 @@ if (nextType == GMenu.TreeItemType.ENTRY) { var entry = iter.get_entry(); if (!entry.get_app_info().get_nodisplay()) { - var app = appsys.lookup_app_by_tree_entry(entry); + var app = appsys.lookup_app_by_tree_entry(entry); if (!app) app = appsys.lookup_settings_app_by_tree_entry(entry); dupe = this.find_dupe(app); @@ -1292,8 +1292,9 @@ this._applicationsButtons[i].category.push(dir.get_menu_id()); } } + this.applicationsByCategory[dir.get_menu_id()].push(app.get_name()); } - } + } } else if (nextType == GMenu.TreeItemType.DIRECTORY) { subdir = iter.get_directory(); this.applicationsByCategory[subdir.get_menu_id()] = new Array(); -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c22 --- Comment #22 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-06 22:26:59 UTC --- I got it fixed. Here's a patch - it works for me. Also please have a look at this post: http://forums.opensuse.org/english/get-technical-help-here/applications/4786... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c23 --- Comment #23 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-06 22:29:50 UTC --- Created an attachment (id=508441) --> (http://bugzilla.novell.com/attachment.cgi?id=508441) menu@cinnamon.org/applet.js 1.6.1 fixes missing entries in cinnamon 1.6.1 applications menu. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c24 --- Comment #24 from Michael Webster <miketwebster@gmail.com> 2012-10-06 23:04:46 UTC --- Great! Will you be submitting this on github for Cinnamon as well? If not, I have a patch set in the process regarding the menu applet and editor, I can include this as well. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c25 --- Comment #25 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-06 23:32:05 UTC --- (In reply to comment #24)
Great!
Will you be submitting this on github for Cinnamon as well? If not, I have a patch set in the process regarding the menu applet and editor, I can include this as well.
Please do so! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c26 --- Comment #26 from Michael Webster <miketwebster@gmail.com> 2012-10-06 23:45:58 UTC --- Included in this: https://github.com/linuxmint/Cinnamon/pull/1256 Note a side-effect of this pull request may remove that duplicated Administration menu as well. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c27 --- Comment #27 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-07 00:05:08 UTC --- Great! I just noticed another small issue. If an application (a .desktop file) contains an empty "Comment=" key, the menu displays about 10 lines of information - I don't know from where - and it becomes difficult to scroll the menu out of there. Do you see what I mean or shall I post a screenshot? To reproduce it, try to put an empty Comment in nautilus.desktop for example: [Desktop Entry] X-SuSE-translate=true Name=Files #Comment=Access and organize files Comment= Exec=nautilus %U Icon=system-file-manager Terminal=false Type=Application StartupNotify=true OnlyShowIn=GNOME;Unity; Categories=GNOME;GTK;Utility;Core; MimeType=inode/directory;application/x-gnome-saved-search; X-GNOME-Bugzilla-Bugzilla=GNOME X-GNOME-Bugzilla-Product=nautilus X-GNOME-Bugzilla-Component=general X-GNOME-Bugzilla-Version=3.4.2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c28 --- Comment #28 from Michael Webster <miketwebster@gmail.com> 2012-10-07 00:10:36 UTC --- Hmm not happening here - do a screenshot please. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c29 --- Comment #29 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-07 00:42:44 UTC --- http://imageshack.us/a/img716/3629/cinnamonemptycomment.png -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c30 --- Comment #30 from Michael Webster <miketwebster@gmail.com> 2012-10-07 01:01:38 UTC --- If you remove or comment the line: X-SuSE-translate=true Does the problem still occur? That looks like translation info. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c31 --- Comment #31 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-07 01:12:55 UTC --- Yes it does. That was actually the first thing I tried. But I noticed the issue with another application "juk", a KDE music player, which doesn't include X-SuSE-translate and came with an empty comment. I then tried to reproduce this menu behaviour by emptying the comment in nautilus.desktop - as you can see in my screenshot. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c32 --- Comment #32 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-07 01:27:06 UTC --- I wouldn't have noticed if an application hadn't come with an empty Comment field. If this field is missing, nothing will be displayed under the application name. It only occurs when this field is present but empty. Adding a comment in the offending .desktop file solves the problem immediately. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c33 --- Comment #33 from Michael Webster <miketwebster@gmail.com> 2012-10-07 02:03:05 UTC --- I can reproduce this easily on my OpenSUSE vm, but cannot on my Mint 13 install. Doing some searching yielded this: http://framework.zend.com/issues/browse/ZF-2914 among other similar results from trying to access the tooltip or comment of an app when it's empty. So, a "feature?" :) If nothing else, I think the developer of the original app you discovered this in needs to add a comment or remove the line entirely. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c34 --- Comment #34 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-07 05:07:29 UTC --- I wouldn't call it a feature. It rather looks like an annoying Easter egg. If you put several entries with empty comments next to each other, the menu will become pretty much unresponsive and difficult to scroll. IMO, it would be better to just discard empty comments. You can not expect from any app that it won't have an empty Comment - although it is not very common. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c35 --- Comment #35 from Nelson Marques <nmo.marques@gmail.com> 2012-10-07 16:12:12 UTC --- Michael, Anyway you can check with Clement when the next bugfix point release is coming? If it takes a few days, then I'll wait for the update, otherwise I'll add the patch the fix the bug that this issue is about. NM -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c36 --- Comment #36 from Nelson Marques <nmo.marques@gmail.com> 2012-10-07 16:17:27 UTC --- Agnelo, This discussion about the missing values is going to far. Let me put this way: 1) Here you have the Desktop file specification[1] 2) Here you have the values types that are accepted[2] As you and anyone else can notice, values can't be empty 3) Here you have stuff regarding entries[3] All of this suggests that it is required to have all entries are made by a PAIR; the case you bring up is not according the specifications, therefore according to my obnoxious interpretation of the sad truth that shrouds this issue in mistery, it's a bug (packaging or design) from Nautilus and it can be fixed during the packaging stage with %suse_update_desktop_file. So please open a bug report on Nautilus, I'm sure Dominique or Bjorn will love to fix it (they shouldn't allow a package with broken specification implementation go live anyway). Looks like people are neat picking with how changelogs are done, but forget stuff that actually have high impact on application usage. [1] - http://standards.freedesktop.org/desktop-entry-spec/latest/ [2] - http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s03.html [3] - http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s02.html#entr... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c37 --- Comment #37 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-07 19:25:23 UTC --- (In reply to comment #36)
Agnelo,
This discussion about the missing values is going to far.
Hi Nelson, I knew you would say that. ;) Sorry. It's another problem I just noticed incidentally ... and fixed - or more exactly worked around. A new patch will follow. It suffices to take only the first line of the returned description. That way, if the Comment key is present but empty and you get the file header information instead, it won't break the menu. It doesn't just affect cinnamon. It is indeed a gettext "feature". You'll see the same info in gnome-fallback but there, it will appear in a tooltip box, which is not really a problem. In cinnamon however, it will show up at the bottom of the menu, increasing its size, and as I said, it's not always easy to scroll out of there. Please compare these 2 pictures, before and after I patched the applet: http://imageshack.us/a/img716/3629/cinnamonemptycomment.png http://imageshack.us/a/img201/5387/cinnamonmenuemptycommen.png
it's a bug (packaging or design) from Nautilus and it can be fixed during the packaging stage with %suse_update_desktop_file. So please open a bug report on Nautilus,
Nautilus is OK. I did empty the Comment in order to reproduce this behaviour. I could have chosen another example. Actually the "only" application which came with an empty comment on this machine was "juk", an old KDE music player. I would expect but don't assume that packagers and developers will strickly follow the specifications. We often have to deal with .desktop files containing (mostly minor) syntax errors and have to figure out some hacks. I guess my patch should be OK, despite it's a little bit straightforward. But considering the fact that cinnamon displays the description inside the menu and not in a tooltip box, taking only the first line of the Comment looks like an acceptable workaround. I haven't seen any Comment that includes "\n" anyway. The only ones which produce line feeds are empty comments when they get replaced with header information. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c38 --- Comment #38 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-07 19:33:09 UTC --- Created an attachment (id=508450) --> (http://bugzilla.novell.com/attachment.cgi?id=508450) cinnaon 1.6.1 meny applet - new patch fixes the following: - undeclared subdir - missing menu entries - displays only the first line of header info returned for empty Comment field in .desktop file to avoid breaking the menu. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c39 --- Comment #39 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-07 19:42:46 UTC --- Further, you could replace this string ("Projetct-Id-Version", etc) with the application name. But it's not this info which is bothering, it's the 10 lines of text of the header info. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c40 --- Comment #40 from Nelson Marques <nmo.marques@gmail.com> 2012-10-08 19:09:18 UTC --- I have spoken with Clement today and there's going a fixes/maintenance point release this week; once it's on the wilderness, I'll get this updated. The bug which this bug report is addressed to should be fixed in the next release. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c41 Nelson Marques <nmo.marques@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO InfoProvider| |hippolyte@shaw.ca --- Comment #41 from Nelson Marques <nmo.marques@gmail.com> 2012-10-19 15:30:29 UTC --- I've issued an update to 1.6.2 which is currently building for GNOME 3.4 repository, I will migrate it to GNOME 3.6 repository after. The main bug of this issue has been fixed according to upstream changelog; please confirm if the __original__ bug has been fixed so we can close this issue. Regarding the other issue raised on this bug report, I believe it's a grey field, while cinnamon can be improved to ignore such bug, the bug itself lies in another application which doesn't respect the specs from FreeDesktop has as a missing key in the .desktop file. Feel free to open specific bug about that if you believe this is a real issue. If the bug in the KDE app hasn't been fixed meanwhile, I'll submit an update for it during the weekend.
From my side this can be closed.
-- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c42 --- Comment #42 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-20 01:45:45 UTC --- Created an attachment (id=510297) --> (http://bugzilla.novell.com/attachment.cgi?id=510297) patches missing menus in cinnamon 1.6.2 The patch I submitted has not been applied to this file: # md5sum /usr/share/cinnamon/applets/menu\@cinnamon.org/applet.js f22bd2bed4de315a5b139171c354c959 /usr/share/cinnamon/applets/menu@cinnamon.org/applet.js And the bug originally discussed here has NOT been fixed. To get all the menu entries displayed, you'd still need to appy this patch against menu@cinnamon.org/applet.js in cinnamon 1.6.2. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c43 --- Comment #43 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-20 01:47:30 UTC --- Created an attachment (id=510298) --> (http://bugzilla.novell.com/attachment.cgi?id=510298) limits comments to 1 line of text As for the other issue, it has been magically fixed, but I guess not in cinnamon (maybe in gettext) - although I noticed a change in the code for the favourites but not for the applications. Anyway if a desktop file has an empty "Comment" key, nothing will be displayed now in the menu, just as if it doesn't have a "Comment" key at all. That's OK so far. However I believe that cinnamon should not display more than one line of comments in any case, so my other patch still makes sense, since "/n" is valid in comments. It's not a problem when comments are displayed in tooltip popups (as in gnome-fallback for example), but in cinnamon, each comment split over multiple lines changes the height of the menu, so that it will become unwieldy it developers or users start to write multiple line comments. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c44 --- Comment #44 from Michael Webster <miketwebster@gmail.com> 2012-10-20 20:25:37 UTC --- Fixes were merged in just a little while ago, 1.6.3 has been tagged. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c45 Nelson Marques <nmo.marques@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED InfoProvider|hippolyte@shaw.ca | Resolution| |FIXED --- Comment #45 from Nelson Marques <nmo.marques@gmail.com> 2012-10-21 15:09:20 UTC --- Agnello, Your patch has been upstreamed by Michael and it's a part of the 1.6.3 release; Closing this bug and 1.6.3 is now entering repository (rebuilding atm). NM -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c46 --- Comment #46 from Nelson Marques <nmo.marques@gmail.com> 2012-10-21 15:10:00 UTC --- Michael, thanks for your support and help around this issue. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=781074 https://bugzilla.novell.com/show_bug.cgi?id=781074#c47 --- Comment #47 from Agnelo de la Crotche <hippolyte@shaw.ca> 2012-10-21 23:49:12 UTC --- OK. Many thanks to both of you. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com