[Bug 567652] New: parted corrupts reiserfs superblock during resize
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c0 Summary: parted corrupts reiserfs superblock during resize Classification: openSUSE Product: openSUSE 11.2 Version: Final Platform: Other OS/Version: Other Status: NEW Severity: Major Priority: P5 - None Component: Basesystem AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: aschnell@novell.com QAContact: qa@suse.de Found By: Development Blocker: --- parted corrupts the superblock of a reiser filesystem during resize (on a partitioned software RAID): Steps to reproduce: - create partitioned software RAID md1 with partition md1p2 - mkfs.reiserfs /dev/md1p2 - parted /dev/md1 print gives: 2 20964887s 54034226s 33069340s primary reiserfs type=83 resizing partition 2 gives this info: Information: The reiserfs file system passed a basic check. For a more comprehensive check, run reiserfsck --check. print now gives: 2 20964887s 64034226s 43069340s primary reiserfs type=83 - reiserfsck --check /dev/md1p2 prints the error: reiserfs_open: Your partition is not big enough to contain the filesystem of (5383666) blocks as was specified in the found super block. Failed to open the filesystem. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c1 Arvin Schnell <aschnell@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |puzel@novell.com |ovo.novell.com | --- Comment #1 from Arvin Schnell <aschnell@novell.com> 2009-12-30 09:47:55 UTC --- Rereading the partition table of /dev/md1 with blockdev updates the size in /proc/partitions. So likely it's a duplicate of bug #539521. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c2 --- Comment #2 from Arvin Schnell <aschnell@novell.com> 2009-12-30 09:54:10 UTC --- Apparently not a duplicate since it's not fixed with the version from /work/SRC/all/parted. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium Status|NEW |ASSIGNED -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c3 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |aschnell@novell.com --- Comment #3 from Petr Uzel <puzel@novell.com> 2010-01-06 13:18:12 UTC --- Are you sure /dev/md1 is partitionable MD raid device? When I created MD (/dev/md0) device with yast, it did not seem to be partitionable: 1) /sys/block/md0/range = 1 2) according to mdadm(8), partitionable MD should be named either /dev/md/dNN or /dev/md_dNN Could you check /sys/block/mdX/range? When I've created DM array manually using mdadm -C /dev/md_d0 -l1 -n2 --auto=p7 /dev/sd[ab]1, parted worked fine on it, creating correct /dev/md_d0pX nodes and /proc/partitions entries as expected. However, I admit that until today, I had no idea that there is something like partitionable MD, so I wouldn't be surprised if I miss something. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c4 Arvin Schnell <aschnell@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED CC| |aschnell@novell.com Info Provider|aschnell@novell.com | --- Comment #4 from Arvin Schnell <aschnell@novell.com> 2010-01-06 19:46:46 UTC --- I did not use YaST to create the setup but mdadm for the RAID and parted for the partitions. /sys/block/mdX/range is 1 and ext_range is 256. I suppose the manpage of mdadm is outdated with kernel 2.6.28 where the kernel simply names the devices mdXpY. The problem isn't that device nodes or entries in /proc/partitions are missing but that the entires in /proc/partitions are not updated after resizing the partiton with parted. Rereading the partition table with blockdev updates /proc/partitions. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c5 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO CC| |mmarek@novell.com, | |teheo@novell.com Info Provider| |teheo@novell.com --- Comment #5 from Petr Uzel <puzel@novell.com> 2010-01-07 15:24:05 UTC --- (In reply to comment #4)
/sys/block/mdX/range is 1 and ext_range is 256.
Parted up to 1.9.0 uses /sys/block/DEV/range to determine the highest possible partition number that might exist on DEV. Since it is 1 in your case, parted will not inform kernel about any partition except the first one. As far as I understand, /sys/block/DEV/range represents maximum number of partitions DEV can contain. Tejun: is this correct? Or should ext_range be also consulted when looking for highest possible partition number on given device? If I create the array like in comment #2, then range==64.
I suppose the manpage of mdadm is outdated with kernel 2.6.28 where the kernel simply names the devices mdXpY. I don't know, but as I wrote above, it behaves differently when created with /dev/dm_dX name wrt to range attribute. Adding mdadm maintainer to CC:
The problem isn't that device nodes or entries in /proc/partitions are missing but that the entires in /proc/partitions are not updated after resizing the partiton with parted. Rereading the partition table with blockdev updates /proc/partitions.
I get this. With device whose range==1, kernel won't be informed about any changes of partitions with no.>=2. So either 1) MD device with range==1 isn't supposed to be partitioned 2) there is a bug in MD causing range==1 3) there is a bug parted => the algorithm for determining largest partition number for a device has to be fixed Apart from that, there still might be some parted/kernel/udev/hal timing issues (the fix for bug #539521 doesn't seem to work in all cases), but without fixing the range thing, this cannot work. I'm going to investigate further. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c6 --- Comment #6 from Petr Uzel <puzel@novell.com> 2010-01-07 15:26:53 UTC --- (In reply to comment #5)
I don't know, but as I wrote above, it behaves differently when created with /dev/dm_dX name wrt to range attribute. Adding mdadm maintainer to CC: */dev/md_dX*
-- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c7 Tejun Heo <teheo@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|teheo@novell.com | --- Comment #7 from Tejun Heo <teheo@novell.com> 2010-01-07 22:27:52 UTC --- (In reply to comment #5)
As far as I understand, /sys/block/DEV/range represents maximum number of partitions DEV can contain. Tejun: is this correct? Or should ext_range be also consulted when looking for highest possible partition number on given device?
range now shows the traditional contiguous minor range while ext_range shows the full range which may be discontiguous. So, yeap, all md devices can be partitioned now and parted should tell the kernel so. Thanks. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c8 --- Comment #8 from Petr Uzel <puzel@novell.com> 2010-01-25 16:00:50 UTC --- OK, I will patch parted to use ext_range instead of range to determine maximum number of partitions on the device. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c9 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |maintenance@opensuse.org --- Comment #9 from Petr Uzel <puzel@novell.com> 2010-01-26 09:31:10 UTC --- Fixed in Factory; I believe this is worth a maintenance update, so I've also submitted the fix to openSUSE:11.2:Update:Test (together with new fix for bug #539521). Maintenance team: are you okay with update? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c10 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED CC| |meissner@novell.com Info Provider|maintenance@opensuse.org | --- Comment #10 from Marcus Meissner <meissner@novell.com> 2010-01-26 15:28:28 UTC --- its ok to have this in the update too I guess. (data corruption - not good). You dont need a seperate swamp id, right? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c11 --- Comment #11 from Petr Uzel <puzel@novell.com> 2010-01-27 10:40:03 UTC --- (In reply to comment #10)
You dont need a seperate swamp id, right? I believe not as I'd like to release the fix together with fix for bug#539521.
-- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c12 Swamp Workflow Management <swamp@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |maint:released:11.2:32633 --- Comment #12 from Swamp Workflow Management <swamp@suse.com> 2010-04-16 14:07:34 UTC --- Update released for: parted, parted-debuginfo, parted-debugsource, parted-devel, parted-lang Products: openSUSE 11.2 (debug, i586, x86_64) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c13 Petr Uzel <puzel@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #13 from Petr Uzel <puzel@novell.com> 2010-04-19 11:36:47 UTC --- Fixed. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=567652 http://bugzilla.novell.com/show_bug.cgi?id=567652#c14 --- Comment #14 from Bernhard Wiedemann <bwiedemann@suse.com> --- This is an autogenerated message for OBS integration: This bug (567652) was mentioned in https://build.opensuse.org/request/show/30479 11.2:Test / parted https://build.opensuse.org/request/show/37780 11.2:Test / parted -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com