[Bug 1224148] sddm-helper should not write utmp entry if utmp file does not exist
https://bugzilla.suse.com/show_bug.cgi?id=1224148 https://bugzilla.suse.com/show_bug.cgi?id=1224148#c5 Fabian Vogt <fvogt@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo? --- Comment #5 from Fabian Vogt <fvogt@suse.com> --- (In reply to Thorsten Kukuk from comment #4)
(In reply to Fabian Vogt from comment #3)
What should sddm do? Just ignore ENOENT?
glibc (and several other implementations I saw) do a "return 0" if the utmp file cannot be open'd, for all reasons. So they do nothing if they cannot open the utmp file RDONLY.
This is about writing, i.e. pututxline. That appears to fail. SDDM does // fill entry ... // write to utmp setutxent(); if (!pututxline (&entry)) qWarning() << "Failed to write utmpx: " << strerror(errno); endutxent(); Should SDDM explicitly ignore ENOENT? Some compile time detection would be fine as well, but I don't see anything fitting. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@suse.com