[Bug 544437] New: openhpi-2.14.0-1.1: missing call to close

older
[Bug 445189] boot.rootfsck doesn't...

bugzilla_noreply＠novell.com

5 Oct 2009 5 Oct '09

18:58

http://bugzilla.novell.com/show_bug.cgi?id=544437 Summary: openhpi-2.14.0-1.1: missing call to close Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: All OS/Version: openSUSE 11.1 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just had a look at factory package openhpi-2.14.0-1.1 source code file openhpi-2.14.0/plugins/ilo2_ribcl/ilo2_ribcl_discover.c function ilo2_ribcl_getfile local variable fd I notice the following code if( (fd = open( fname, O_RDONLY)) == -1){ but I fail to find a matching call to close. This looks like a resource leak to me. Suggest add call to close near the end of the function. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

bugzilla_noreply＠novell.com

6 Oct 6 Oct

11:43

New subject: [Bug 544437] openhpi-2.14.0-1.1: missing call to close

http://bugzilla.novell.com/show_bug.cgi?id=544437 Marcus Meissner changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |mrueckert@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

11:48

New subject: [Bug 544437] openhpi-2.14.0-1.1: missing call to close

http://bugzilla.novell.com/show_bug.cgi?id=544437 User mrueckert@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=544437#c1 Marcus Rückert changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Info Provider| |dcb314@hotmail.com --- Comment #1 from Marcus Rückert 2009-10-06 05:48:32 MDT --- the upstream bug report tool is at http://sourceforge.net/tracker/?group_id=71730&atid=532251 . please open a bugreport there and link the resulting bug here. thanks in advance. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

12:04

New subject: [Bug 544437] openhpi-2.14.0-1.1: missing call to close

http://bugzilla.novell.com/show_bug.cgi?id=544437 User dcb314@hotmail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=544437#c2 David Binderman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Info Provider|dcb314@hotmail.com | --- Comment #2 from David Binderman 2009-10-06 06:04:55 MDT --- (In reply to comment #1)

...

the upstream bug report tool is at http://sourceforge.net/tracker/?group_id=71730&atid=532251 .

I see that a certain MRueckert already has an account with sourceforge.

...

please open a bugreport there and link the resulting bug here. thanks in advance.

Thanks for your offer, but I will not be creating an account at sourceforge anytime soon. Feel free to submit the bug report to sourceforge, if you wish. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

15:34

New subject: [Bug 544437] openhpi-2.14.0-1.1: missing call to close

http://bugzilla.novell.com/show_bug.cgi?id=544437 User shuah.khan@hp.com added comment http://bugzilla.novell.com/show_bug.cgi?id=544437#c3 Shuah Khan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shuah.khan@hp.com --- Comment #3 from Shuah Khan 2009-10-06 09:34:23 MDT --- This code path gets executed only in a simulated test during unit testing of this plug-in. This code will not be executed during normal plug-in. Even though it is a test bug, we will try to fix it in our next release of this plug-in. (Shuah Khan - iLO2 RIBCL Maintainer) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

17 Oct 17 Oct

14:56

New subject: [Bug 544437] openhpi-2.14.0-1.1: missing call to close

http://bugzilla.novell.com/show_bug.cgi?id=544437 User rguenther@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=544437#c4 --- Comment #4 from Richard Guenther 2009-10-17 08:56:11 MDT --- David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

bugzilla_noreply＠novell.com

18 May 18 May

13:45

New subject: [Bug 544437] openhpi-2.14.0-1.1: missing call to close

http://bugzilla.novell.com/show_bug.cgi?id=544437 http://bugzilla.novell.com/show_bug.cgi?id=544437#c5 Marcus Rückert changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #5 from Marcus Rückert 2010-05-18 13:45:57 UTC --- as Shuah wrote this is not runtime specific. So I am sure we can wait for the next version update. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5100

Age (days ago)

5325

Last active (days ago)

List overview

Download

6 comments

1 participants

participants (1)

bugzilla_noreply＠novell.com