[Bug 749563] New: regression with quilt diff
https://bugzilla.novell.com/show_bug.cgi?id=749563 https://bugzilla.novell.com/show_bug.cgi?id=749563#c0 Summary: regression with quilt diff Classification: openSUSE Product: openSUSE 12.2 Version: Factory Platform: x86-64 OS/Version: openSUSE 12.2 Status: NEW Severity: Normal Priority: P5 - None Component: Development AssignedTo: jdelvare@suse.com ReportedBy: puzel@suse.com QAContact: qa@suse.de Found By: Development Blocker: --- I have set up an alias for viewing quilt-managed patches with vimdiff: $ alias qdv alias qdv='quilt diff -p0 -C 9999 --color=never --diff=vimdiff' This worked fine with quilt-0.48, but after updating to quilt-0.51, it no longer works. It prints a message "Vim: WARNING: Output is not to a terimnal" and then the terminal becomes garbled. Sidenote: If I use meld instead of vimdiff, it works fine. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749563 https://bugzilla.novell.com/show_bug.cgi?id=749563#c1 Jean Delvare <jdelvare@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |puzel@suse.com --- Comment #1 from Jean Delvare <jdelvare@suse.com> 2012-03-01 20:44:40 UTC --- Please try adding: QUILT_PAGER= to your ~/.quiltrc, I believe it should work around the problem. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749563 https://bugzilla.novell.com/show_bug.cgi?id=749563#c2 Petr Uzel <puzel@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED InfoProvider|puzel@suse.com | --- Comment #2 from Petr Uzel <puzel@suse.com> 2012-03-02 08:22:52 UTC --- Great, it works now! Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749563 https://bugzilla.novell.com/show_bug.cgi?id=749563#c3 --- Comment #3 from Jean Delvare <jdelvare@suse.com> 2012-03-02 12:27:38 UTC --- At least you have a workaround now. I'm not sure how to fix it proper though. I presume we could hard-code a list of text diff helpers for which the pager should be inhibited, but obviously this would fail again for unknown/future text diff helpers. So I'll bring it up upstream to the guys who added support for QUILT_PAGER, maybe they'll have a better idea. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749563 https://bugzilla.novell.com/show_bug.cgi?id=749563#c4 --- Comment #4 from Petr Uzel <puzel@suse.com> 2012-03-02 12:52:22 UTC --- As far as I'm concerned, I'm perfectly fine with the workaround. Please close this bug at your own convenience. Thanks once again. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749563 https://bugzilla.novell.com/show_bug.cgi?id=749563#c5 --- Comment #5 from Jean Delvare <jdelvare@suse.com> 2012-03-02 13:01:17 UTC --- Well, this is a regression, so I can't just close it as if it was never reported. The workaround is not necessarily obvious. I would like to at least fix the problem for common diff viewers and I presume vimdiff is one of these, and document the problem if we can't come up with a generic fix. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749563 https://bugzilla.novell.com/show_bug.cgi?id=749563#c6 --- Comment #6 from Jean Delvare <jdelvare@suse.com> 2012-03-02 13:16:07 UTC --- Created an attachment (id=479153) --> (http://bugzilla.novell.com/attachment.cgi?id=479153) Minimal fix This isn't the generic fix I am hoping for, but at least it fixes the reported issue. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749563 https://bugzilla.novell.com/show_bug.cgi?id=749563#c7 --- Comment #7 from Petr Uzel <puzel@suse.com> 2012-03-02 13:20:12 UTC --- Looks good to me. I have no idea about the generic fix (honestly, I was not brave enough to look into the code), but if you need the list of 'common' console diff viewers, this is what I could think of: vimdiff diff sdiff wdiff colordiff I tried all of these and only vimdiff complains about the terminal (I guess because of the libcurses). Rest of those works fine. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749563 https://bugzilla.novell.com/show_bug.cgi?id=749563#c8 --- Comment #8 from Jean Delvare <jdelvare@suse.com> 2012-03-02 13:27:25 UTC --- OK, so my patch should be good enough in practice, thanks for the tests and report. I have just pushed the fix to devel:tools:scm. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=749563 https://bugzilla.novell.com/show_bug.cgi?id=749563#c9 Jean Delvare <jdelvare@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #9 from Jean Delvare <jdelvare@suse.com> 2012-03-07 13:25:22 UTC --- Fixed in Factory. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com