[Bug 1223892] New: Gimp does not build with GCC 14 because of use of incompatible pointer types
https://bugzilla.suse.com/show_bug.cgi?id=1223892 Bug ID: 1223892 Summary: Gimp does not build with GCC 14 because of use of incompatible pointer types Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Other Assignee: screening-team-bugs@suse.de Reporter: mjambor@suse.com QA Contact: qa-bugs@suse.de Blocks: 1220571 Target Milestone: --- Found By: --- Blocker: --- Gimp fails when built with GCC 14 because of use incompatible pointer types, which used to be warnings in previous versions of GCC but are errors by default in GCC 14. For more information, see https://gcc.gnu.org/gcc-14/porting_to.html Upstream issues seem to be: - https://gitlab.gnome.org/GNOME/gimp/-/issues/8807 and - https://gitlab.gnome.org/GNOME/gimp/-/issues/8649 but perhaps there are others. Corresponding Gentoo bug is https://bugs.gentoo.org/875413 Failed build log is available at: https://build.opensuse.org/package/live_build_log/home:rguenther:plgrnd/gimp... -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223892 Chenzi Cao <chcao@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|screening-team-bugs@suse.de |dimstar@opensuse.org -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223892 https://bugzilla.suse.com/show_bug.cgi?id=1223892#c1 Dominique Leuenberger <dimstar@opensuse.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dimstar@opensuse.org |pstivanin@suse.com --- Comment #1 from Dominique Leuenberger <dimstar@opensuse.org> --- Assigning to Paolo - seems to have done much more work on gimp than me -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223892 https://bugzilla.suse.com/show_bug.cgi?id=1223892#c2 Paolo Stivanin <pstivanin@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |IN_PROGRESS --- Comment #2 from Paolo Stivanin <pstivanin@suse.com> --- looking into it! -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223892 https://bugzilla.suse.com/show_bug.cgi?id=1223892#c3 Paolo Stivanin <pstivanin@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjambor@suse.com Flags| |needinfo?(mjambor@suse.com) --- Comment #3 from Paolo Stivanin <pstivanin@suse.com> --- @Martin: can you please try with the patch I added here https://build.opensuse.org/package/show/home:polslinux:branches:graphics/gim... ? thanks -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223892 https://bugzilla.suse.com/show_bug.cgi?id=1223892#c4 --- Comment #4 from Martin Jambor <mjambor@suse.com> --- (In reply to Paolo Stivanin from comment #3)
@Martin: can you please try with the patch I added here https://build.opensuse.org/package/show/home:polslinux:branches:graphics/ gimp ? thanks
You can try yourself with osc build --alternative-project home:rguenther:nextgcc Because it may take a me day or three before I get to it. Thanks for dealing with this! -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223892 https://bugzilla.suse.com/show_bug.cgi?id=1223892#c5 Paolo Stivanin <pstivanin@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mjambor@suse.com) | --- Comment #5 from Paolo Stivanin <pstivanin@suse.com> --- Thanks! The patch is not enough, there are more things to fix. -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223892 https://bugzilla.suse.com/show_bug.cgi?id=1223892#c6 Paolo Stivanin <pstivanin@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #6 from Paolo Stivanin <pstivanin@suse.com> --- Tested on tumbleweed, all good: https://build.opensuse.org/request/show/1175538 compiles fine now with gcc14 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223892 https://bugzilla.suse.com/show_bug.cgi?id=1223892#c7 Martin Jambor <mjambor@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #7 from Martin Jambor <mjambor@suse.com> --- (In reply to Paolo Stivanin from comment #6)
Tested on tumbleweed, all good: https://build.opensuse.org/request/show/1175538
compiles fine now with gcc14
Unfortunately, it does not: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:G... You can try locally with: osc build --clean --alternative-project home:rguenther:nextgcc standard The failure stopping the build is: [ 178s] file-tiff-load.c: In function ‘load_image’: [ 178s] file-tiff-load.c:572:7: warning: ‘uint16’ is deprecated [-Wdeprecated-declarations] [ 178s] 572 | uint16 planar = PLANARCONFIG_CONTIG; [ 178s] | ^~~~~~ [ 178s] file-tiff-load.c:1239:9: warning: ‘uint32’ is deprecated [-Wdeprecated-declarations] [ 178s] 1239 | uint32 count = 0; [ 178s] | ^~~~~~ [ 178s] file-tiff-load.c:1372:56: error: passing argument 2 of ‘gimp_image_get_resolution’ from incompatible pointer type [-Wincompatible-pointer-types] [ 178s] 1372 | gimp_image_get_resolution (*image, &xres, &yres); [ 178s] | ^~~~~ [ 178s] | | [ 178s] | gfloat * {aka float *} [ 178s] In file included from ../../libgimp/gimp_pdb_headers.h:55, [ 178s] from ../../libgimp/gimp.h:66, [ 178s] from file-tiff-load.c:52: [ 178s] ../../libgimp/gimpimage_pdb.h:179:86: note: expected ‘gdouble *’ {aka ‘double *’} but argument is of type ‘gfloat *’ {aka ‘float *’} [ 178s] 179 | gdouble *xresolution, [ 178s] | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ [ 178s] file-tiff-load.c:1372:63: error: passing argument 3 of ‘gimp_image_get_resolution’ from incompatible pointer type [-Wincompatible-pointer-types] [ 178s] 1372 | gimp_image_get_resolution (*image, &xres, &yres); [ 178s] | ^~~~~ [ 178s] | | [ 178s] | gfloat * {aka float *} [ 178s] ../../libgimp/gimpimage_pdb.h:180:86: note: expected ‘gdouble *’ {aka ‘double *’} but argument is of type ‘gfloat *’ {aka ‘float *’} [ 178s] 180 | gdouble *yresolution); [ 178s] | ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223892 https://bugzilla.suse.com/show_bug.cgi?id=1223892#c8 Paolo Stivanin <pstivanin@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mjambor@suse.com) --- Comment #8 from Paolo Stivanin <pstivanin@suse.com> --- It's working fine for me: $ osc build --clean --alternative-project home:rguenther:nextgcc standard .... [ 368s] Check time report (>1% & >0.1s): [ 368s] Check Duration (in s) Fraction (in %) Checked files [ 368s] BinariesCheck 5.5 57.1 [ 368s] ExtractRpm 1.6 16.4 [ 368s] SignatureCheck 0.5 5.5 [ 368s] FilesCheck 0.5 5.4 [ 368s] BashismsCheck 0.4 4.2 [ 368s] SharedLibraryPolicyCheck 0.4 3.8 [ 368s] BuildRootAndDateCheck 0.3 3.3 [ 368s] FilelistCheck 0.1 1.3 [ 368s] TOTAL 9.6 100.0 [ 368s] [ 368s] 8 packages and 0 specfiles checked; 14 errors, 4 warnings, 295 filtered, 110 badness; has taken 9.8 s [ 368s] [ 368s] ... running 01-delete-x86_64-subarches [ 368s] [ 368s] suse-ws finished "build gimp.spec" at Mon Jun 10 06:18:12 UTC 2024. [ 368s] /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/SRPMS/gimp-2.10.38-0.src.rpm /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/RPMS/noarch/gimp-lang-2.10.38-0.noarch.rpm /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/RPMS/x86_64/libgimp-2_0-0-2.10.38-0.x86_64.rpm /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/RPMS/x86_64/gimp-plugins-python-debuginfo-2.10.38-0.x86_64.rpm /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/RPMS/x86_64/gimp-2.10.38-0.x86_64.rpm /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/RPMS/x86_64/gimp-debugsource-2.10.38-0.x86_64.rpm /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/RPMS/x86_64/gimp-devel-2.10.38-0.x86_64.rpm /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/RPMS/x86_64/gimp-plugin-aa-debuginfo-2.10.38-0.x86_64.rpm /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/RPMS/x86_64/gimp-plugins-python-2.10.38-0.x86_64.rpm /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/RPMS/x86_64/libgimpui-2_0-0-2.10.38-0.x86_64.rpm /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/RPMS/x86_64/libgimp-2_0-0-debuginfo-2.10.38-0.x86_64.rpm /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/RPMS/x86_64/libgimpui-2_0-0-debuginfo-2.10.38-0.x86_64.rpm /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/RPMS/x86_64/gimp-plugin-aa-2.10.38-0.x86_64.rpm /var/tmp/build-root/standard-x86_64/home/abuild/rpmbuild/RPMS/x86_64/gimp-debuginfo-2.10.38-0.x86_64.rpm -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223892 https://bugzilla.suse.com/show_bug.cgi?id=1223892#c9 Martin Jambor <mjambor@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mjambor@suse.com) | --- Comment #9 from Martin Jambor <mjambor@suse.com> --- Unfortunately, when I check out the current factory version (r142, last gimp.changes update has date "Mon May 6 07:20:05 UTC 2024"), and try to build it with the same alternative, project, it fails with me with a C99 viloations. The forst one is: [ 142s] file-tiff-load.c:1372:56: error: passing argument 2 of ‘gimp_image_get_resolution’ from incompatible pointer type [-Wincompatible-pointer-types] [ 142s] 1372 | gimp_image_get_resolution (*image, &xres, &yres); [ 142s] | ^~~~~ [ 142s] | | [ 142s] | gfloat * {aka float *} [ 142s] In file included from ../../libgimp/gimp_pdb_headers.h:55, [ 142s] from ../../libgimp/gimp.h:66, [ 142s] from file-tiff-load.c:52: [ 142s] ../../libgimp/gimpimage_pdb.h:179:86: note: expected ‘gdouble *’ {aka ‘double *’} but argument is of type ‘gfloat *’ {aka ‘float *’} [ 142s] 179 | gdouble *xresolution, [ 142s] | ~~~~~~~~~~~~~~~~~ -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223892 https://bugzilla.suse.com/show_bug.cgi?id=1223892#c10 --- Comment #10 from Paolo Stivanin <pstivanin@suse.com> --- That's because you are missing the fix itself. The fix was pushed on the 21st of May: ------------------------------------------------------------------- Tue May 21 08:45:44 UTC 2024 - Paolo Stivanin <info@paolostivanin.com> - Add fix-gcc14-build.patch (fix bsc#1223892) -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1223892 https://bugzilla.suse.com/show_bug.cgi?id=1223892#c11 Martin Jambor <mjambor@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #11 from Martin Jambor <mjambor@suse.com> --- (In reply to Paolo Stivanin from comment #10)
That's because you are missing the fix itself. The fix was pushed on the 21st of May:
------------------------------------------------------------------- Tue May 21 08:45:44 UTC 2024 - Paolo Stivanin <info@paolostivanin.com>
- Add fix-gcc14-build.patch (fix bsc#1223892)
I did the (clean) package check-out from Factory yesterday and did not get the fix though. I see that there is a submit request to factory, so hopefully after it is accepted, the fix will be there as well. Thanks. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com