[Bug 382739] New: acroread writes xulrunner path to user config
https://bugzilla.novell.com/show_bug.cgi?id=382739 Summary: acroread writes xulrunner path to user config Product: openSUSE 11.0 Version: Factory Platform: All OS/Version: openSUSE 11.0 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: mfabian@novell.com ReportedBy: wolfgang@rosenauer.org QAContact: qa@suse.de Found By: --- This is a follow up on the xulrunner part of bug 382523 It seems to me that acroread writes the path to gtkmozembed to the user settings and keeps it. I guess there can't be done anything to avoid that but then we have to make sure that it doesn't set the full version path but only the /usr/lib/xulrunner-1.8.1 one. Actually the path /usr/lib/xulrunner-1.8.1 should be pretty hardcoded for 11.0 since the xulrunner181 package is the only one exporting gtkmozembed in the distribution, it should be installed always and acroread is i586 only so we have to make sure this is used in every case. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 Mike Fabian <mfabian@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koenig@linux.de Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User andreas.hanke@gmx-topmail.de added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c1 Andreas Hanke <andreas.hanke@gmx-topmail.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hanke@gmx-topmail.de --- Comment #1 from Andreas Hanke <andreas.hanke@gmx-topmail.de> 2008-04-23 06:32:32 MST --- See http://blogs.adobe.com/acroread/2007/09/adobe_reader_811_faqs.html (section 11) for a possible solution. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c2 --- Comment #2 from Mike Fabian <mfabian@novell.com> 2008-04-23 06:55:48 MST --- Actually we do that already (and I just tested again that it works). We patch the acroread start script like this: @@ -413,6 +429,14 @@ if [ -f "$i" ]; then mozillaPath="`grep "^GRE_PATH=" "$i" | cut -d= -f2 | sed -e 's/^[ ]*//g' -e 's/[ ]*$//g'`" if [ -n "$mozillaPath" ]; then + if [ "$(arch)" = "x86_64" ]; then + for lib in /usr/lib/xulrunner-*/libgtkembedmoz.so /usr/lib/seamonkey/libgtkembedmoz.so + do + if [ -f $lib ]; then + mozillaPath="$(dirname $lib)" + fi + done + fi MOZILLA_COMP_PATH="$mozillaPath" export MOZILLA_COMP_PATH break /usr/lib/seamonkey doesn’t exist on STABLE/Factory. And /usr/lib/xulrunner-*/libgtkembedmoz.so expands to mfabian@magellan:~$ echo /usr/lib/xulrunner-*/libgtkembedmoz.so /usr/lib/xulrunner-1.8.1.13/libgtkembedmoz.so /usr/lib/xulrunner-1.8.1/libgtkembedmoz.so mfabian@magellan:~$ i.e. the shortest library name comes last (glob patterns sort in alphabetical order according to the bash man page). mozillaPath is then to the last match in the glob pattern where the library is found. Maybe I should move /usr/lib/seamonkey/libgtkembedmoz.so to the front of the globpattern to make this more obvious. (Probably I added this /usr/lib/seamonkey/libgtkembedmoz.so path because of some old version of openSUSE where the library is in that location.). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c4 --- Comment #4 from Mike Fabian <mfabian@novell.com> 2008-04-23 07:05:24 MST --- Maybe I should use our hack with the glob pattern on both architectures. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c3 --- Comment #3 from Mike Fabian <mfabian@novell.com> 2008-04-23 07:04:41 MST --- OK, I overlooked the “if [ "$(arch)" = "x86_64" ]; then”. I.e. on 64 bit it is as I wrote in my last comment, /usr/lib/xulrunner-1.8.1 will be used. But on 32 bit, the “Adobe way” of searching for libgtkembedmoz.so is still used, i.e. checking the config files: for i in /etc/gre.d/gre.conf /etc/gre.d/firefox.conf /etc/gre.d/mozilla.conf /etc/gre.d/*.conf /etc/gre.conf This will usually have the result that the full version path is used. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User wolfgang@rosenauer.org added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c5 --- Comment #5 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2008-04-23 07:52:43 MST --- Ok, just verified that it's set up correctly with a clean acroread profile. But if the wrong setting is in the user prefs it overrides the stuff in the startscript and if some older acroread version wrote the wrong value to the config it doesn't work. But probably there is no way to "fix" that. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c6 --- Comment #6 from Mike Fabian <mfabian@novell.com> 2008-04-23 08:00:36 MST --- Wolfgang> Ok, just verified that it's set up correctly with a clean Wolfgang> acroread profile. Yes, on x86_64. But did you look at my comment #3? Does it also work correctly in i386? Wolfgang> But if the wrong setting is in the user prefs it overrides Wolfgang> the stuff in the startscript and if some older acroread Wolfgang> version wrote the wrong value to the config it doesn't Wolfgang> work. But probably there is no way to "fix" that. Yes. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User koenig@linux.de added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c7 --- Comment #7 from Harald Koenig <koenig@linux.de> 2008-04-23 10:45:32 MST --- (In reply to comment #3 from Mike Fabian)
OK, I overlooked the “if [ "$(arch)" = "x86_64" ]; then”.
I.e. on 64 bit it is as I wrote in my last comment, /usr/lib/xulrunner-1.8.1 will be used.
my notebook runs 11.0-b1 x64_64 and it did not work. maybe there is an override for user prefs settings over MOZILLA_COMP_PATH environment ? remember: I did update from 10.3 and I used acroread 8.1.2 before updating to 11.0! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c8 --- Comment #8 from Mike Fabian <mfabian@novell.com> 2008-04-23 10:52:55 MST --- Harald> maybe there is an override for user prefs settings over Harald> MOZILLA_COMP_PATH environment ? Yes, that is what Wolfgang said in comment #5, the settings from the user prefs have higher priority. You see that in the /usr/bin/acroread start script: greConfigFile="${HOME}/.adobe/Acrobat/$majorRelease/Preferences/acrogre.conf" if [ -f "$greConfigFile" ]; then mozillaPath="`cat "$greConfigFile"`" if [ -n "$mozillaPath" ]; then MOZILLA_COMP_PATH="$mozillaPath" export MOZILLA_COMP_PATH fi else [ ... no setting in user prefs → find libgtkembedmoz.so in the system ...] Harald> remember: I did update from 10.3 and I used acroread 8.1.2 Harald> before updating to 11.0! Yes, but that can probably not be fixed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c9 --- Comment #9 from Mike Fabian <mfabian@novell.com> 2008-04-23 10:55:11 MST --- Well, I could check in the start script whether there is a libgtkembedmoz.so in the directory specified in the user prefs and if not ignore the user prefs and ot the search in the system. I’m not sure whether this is a good idea. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User wolfgang@rosenauer.org added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c11 --- Comment #11 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2008-04-23 11:00:06 MST --- (In reply to comment #9 from Mike Fabian)
Well, I could check in the start script whether there is a libgtkembedmoz.so in the directory specified in the user prefs and if not ignore the user prefs and ot the search in the system.
Actually it's not enough to look for the file. You also have to check for the right architecture. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User wolfgang@rosenauer.org added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c10 --- Comment #10 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2008-04-23 10:59:16 MST --- Do we "need" to make it configurable for the user? Either check if there is libgtkembedmoz.so there or ignore $greConfigFile completely? Does it make sense to let the user change it? -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User koenig@linux.de added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c12 --- Comment #12 from Harald Koenig <koenig@linux.de> 2008-04-23 11:02:45 MST --- (In reply to comment #8 from Mike Fabian)
Harald> remember: I did update from 10.3 and I used acroread 8.1.2 Harald> before updating to 11.0!
Yes, but that can probably not be fixed.
see bug #382523: adding a symlink /usr/lib/xulrunner-1.8.1.10 -> xulrunner-1.8.1 worked for me(tm) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User wolfgang@rosenauer.org added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c13 --- Comment #13 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2008-04-23 11:08:10 MST --- That would mean adding all symlinks from 1.8.1.4 to 1.8.1.13 since it only depends when the user started acroread 8 the first time? (And doing so for every future SUSE distribution). Doesn't sound like a solution ;-) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c14 --- Comment #14 from Mike Fabian <mfabian@novell.com> 2008-04-23 12:07:20 MST --- Wolfgang> Actually it's not enough to look for the file. You also have Wolfgang> to check for the right architecture. I don’t think so. Because if the directory from the user prefs points to a libgtkembedmoz.so with the wrong architecture, it is clearly caused by user error (has been edited manually). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c15 Mike Fabian <mfabian@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |wolfgang@rosenauer.org --- Comment #15 from Mike Fabian <mfabian@novell.com> 2008-04-23 12:20:07 MST --- Wolfgang, do you think we need to change the search algorithm for the i386 platform (see comment #3)? If not, we could close this bug as WORKSFORME. → NEEDINFO. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User wolfgang@rosenauer.org added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c16 Wolfgang Rosenauer <wolfgang@rosenauer.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|wolfgang@rosenauer.org | --- Comment #16 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2008-04-23 12:31:00 MST --- It seems to be dangerous since 11.0 has mozilla-xulrunner190 as well which registers in /etc/gre.d while it doesn't provide libgtkembedmoz.so as 1.8.x did. It's still available in libxul.so but its usage and initialization is completely different but as I read the current script it could choose a xulrunner-1.9 path which wouldn't work. Therefore the scriptlet should be made safer for the i386 case IMHO. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c17 --- Comment #17 from Mike Fabian <mfabian@novell.com> 2008-04-23 12:35:10 MST --- OK, I’ll try … -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c18 --- Comment #18 from Mike Fabian <mfabian@novell.com> 2008-04-28 10:28:56 MST --- So how about this?: # if MOZILLA_COMP_PATH is already set, use it (useful for debugging?) # if not, get it from the user config or search it in the system: if [ -z "$MOZILLA_COMP_PATH" ]; then # First try to get MOZILLA_COMP_PATH from the user config file. # But use it only if it points to a location where libgtkembedmoz.so # really exists: greConfigFile="${HOME}/.adobe/Acrobat/$majorRelease/Preferences/acrogre.conf" if [ -f "$greConfigFile" ]; then mozillaPath="`cat "$greConfigFile"`" if [ -x "$mozillaPath/libgtkembedmoz.so" ]; then MOZILLA_COMP_PATH="$mozillaPath" export MOZILLA_COMP_PATH fi fi if [ -z "$MOZILLA_COMP_PATH" ]; then # There was either nothing in the user config file (first start ever # of acroread?) or something invalid. Try to find # libgtkembedmoz.so in the system: # (the last match in the glob pattern will win. glob patterns # are sorted alphabetically, i.e the symlink # /usr/lib/xulrunner-1.8.1 which points to the current version # will win over any specific version /usr/lib/xulrunner-1.8.1.1x). for lib in /usr/lib/seamonkey/libgtkembedmoz.so /usr/lib/xulrunner-*/libgtkembedmoz.so do if [ -x $lib ]; then MOZILLA_COMP_PATH="$(dirname $lib)" export MOZILLA_COMP_PATH fi done fi fi -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User wolfgang@rosenauer.org added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c19 --- Comment #19 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2008-04-28 11:09:03 MST --- Logic looks good. I'd go for that. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c20 Mike Fabian <mfabian@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #20 from Mike Fabian <mfabian@novell.com> 2008-04-29 05:05:51 MST --- Submitted like that to STABLE/Factory. Closing as FIXED. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c21 Mike Fabian <mfabian@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaurav@adobe.com --- Comment #21 from Mike Fabian <mfabian@novell.com> 2008-04-29 07:06:07 MST --- Gaurav, maybe the way I used in comment #18 to search for libgtkembedmoz.so is more useful then the original method used in the startscript? Please see also https://bugzilla.novell.com/show_bug.cgi?id=351054#c55 https://bugzilla.novell.com/show_bug.cgi?id=351054#c56 https://bugzilla.novell.com/show_bug.cgi?id=351054#c57 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c22 Mike Fabian <mfabian@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ast@novell.com, meissner@novell.com --- Comment #22 from Mike Fabian <mfabian@novell.com> 2008-05-07 04:21:29 MST --- SWAMP-ID : 17513 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c23 --- Comment #23 from Mike Fabian <mfabian@novell.com> 2008-05-07 07:52:27 MST --- Updated packages submitted to /work/src/done/{SLES10,10.1,10.2,10.3}. Patchinfos submitted to /work/src/done/PATCHINFO/acroread.patch.box /work/src/done/PATCHINFO/acroread.patch.maintained Closing as FIXED. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User mfabian@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c24 --- Comment #24 from Mike Fabian <mfabian@novell.com> 2008-05-07 07:59:35 MST --- FIXED. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=382739 User meissner@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=382739#c25 --- Comment #25 from Marcus Meissner <meissner@novell.com> 2008-07-02 07:21:30 MDT --- released update now -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com