[Bug 229238] New: xchat-2.6.6-25: comparison with string literal
https://bugzilla.novell.com/show_bug.cgi?id=229238 Summary: xchat-2.6.6-25: comparison with string literal Product: openSUSE 10.3 Version: unspecified Platform: All OS/Version: SuSE Other Status: NEW Severity: Normal Priority: P5 - None Component: X11 Applications AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: sndirsch@novell.com I just tried to compile package xchat-2.6.6-25 The compiler said gtkutil.c:394: warning: comparison with string literal The source code is if (stock == GTK_STOCK_GOTO_LAST) but linux:/usr/src/packages/SPECS # find /opt/gnome/include/gtk-2.0 -name \*.h -print | xargs fgrep GTK_STOCK_GOTO_LAST /opt/gnome/include/gtk-2.0/gtk/gtkstock.h:#define GTK_STOCK_GOTO_LAST "gtk-goto-last" Suggest new code if (strcmp( stock, GTK_STOCK_GOTO_LAST) == 0) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=229238 mhorvath@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |bnc-team-gnome@forge.provo.novell.com |screening@forge.provo.novell| |.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=229238 jpr@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |sbrabec@novell.com |gnome@forge.provo.novell.com| -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=229238 ------- Comment #1 from sndirsch@novell.com 2007-01-16 15:30 MST ------- Feel free to close as duplicate of Bug #233655. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=229238 mvaner@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|sbrabec@novell.com |mvaner@novell.com Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=229238 mvaner@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #2 from mvaner@novell.com 2007-02-20 10:14 MST ------- Comparing in a propper way (strcmp) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply@novell.com