[Bug 571819] New: brp-desktop won't let pass desktop file if contains system side icon
http://bugzilla.novell.com/show_bug.cgi?id=571819 http://bugzilla.novell.com/show_bug.cgi?id=571819#c0 Summary: brp-desktop won't let pass desktop file if contains system side icon Classification: openSUSE Product: openSUSE.org Version: unspecified Platform: Other OS/Version: openSUSE 11.2 Status: NEW Severity: Major Priority: P5 - None Component: BuildService AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: ilfirin.ms@gmail.com QAContact: adrian@novell.com Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; cs; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729) If package did not provide own icon (file) and desktop file is using system icons (installed by gnome-icon-theme, tango-icon-theme ...) such as "computer" "display" "media-optical" "gtk-cdrom" etc. brp-desktop raise error: ERROR: Icon file not installed: /usr/src/packages/BUILDROOT/application-version-release.arch//usr/share/applications/application.desktop (media-optical) Errors in installed desktop file detected. Please mail stbinner@suse.de, if you think this is wrong. Reproducible: Always Steps to Reproduce: 1. Create package with desktop file using system icon 2. Try to build it in BuildService Actual Results: ERROR: Icon file not installed: /usr/src/packages/BUILDROOT/application-version-release.arch//usr/share/applications/application.desktop (media-optical) Errors in installed desktop file detected. Please mail stbinner@suse.de, if you think this is wrong. Expected Results: pass, or just warn. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=571819 http://bugzilla.novell.com/show_bug.cgi?id=571819#c1 --- Comment #1 from Michal Smrž <ilfirin.ms@gmail.com> 2010-01-19 16:18:33 UTC --- In brp-check-suse-1.0 is brp-desktop.data/xdg_menu which contain starting with line 1562 ----------------------------- if ($desktop->{'OnlyShowIn'} eq "KDE") {$xtrapath .= ",icons/crystalsvg";} if ($desktop->{'OnlyShowIn'} eq "GNOME") {$xtrapath .= ",icons/gnome";} my @out = `find \$RPM_BUILD_ROOT{/usr,/opt/kde3,/opt/gnome}/share/{pixmaps,icons/hicolor$xtrapath}{,{16x16,22x22,24x24,32x32,36x36,48x48,64x64,72x72,96x96,128x128,192x192,scalable}/{actions,animations,apps,categories,devices,emblems,emotes,filesystems,intl,mimetypes,places,status,stock}} -name $desktop->{Icon} -o -name $desktop->{Icon}.png -o -name $desktop->{Icon}.jpg -o -name $desktop->{Icon}.xpm -o -name $desktop->{Icon}.svg -o -name $desktop->{Icon}.svgz 2> /dev/null`; @out = `find {/usr,/opt/kde3,/opt/gnome}/share/{pixmaps,icons/hicolor$xtrapath}{,{16x16,22x22,24x24,32x32,36x36,48x48,64x64,72x72,96x96,128x128,192x192,scalable}/{actions,animations,apps,categories,devices,emblems,emotes,filesystems,intl,mimetypes,places,status,stock}} -name $desktop->{Icon} -o -name $desktop->{Icon}.png -o -name $desktop->{Icon}.jpg -o -name $desktop->{Icon}.xpm -o -name $desktop->{Icon}.svg -o -name $desktop->{Icon}.svgz 2> /dev/null` unless @out; if ( !@out and $desktop->{'X-SuSE-YaST-Call'} eq '' ){ $output .= "ERROR: Icon file not installed: $desktop->{file} ($desktop->{Icon})\n"; $validate_error = 1; ----------------------------- I think, this is the reason. Looking for icons only in {pixmaps,icons/hicolor} ? I think, whole brp-desktop should be deprecated if there is rpmlint -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=571819 http://bugzilla.novell.com/show_bug.cgi?id=571819#c yang xiaoyu <xyyang@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xyyang@novell.com AssignedTo|bnc-team-screening@forge.pr |ro@novell.com |ovo.novell.com | -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=571819 http://bugzilla.novell.com/show_bug.cgi?id=571819#c2 Ruediger Oertel <ro@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO InfoProvider| |dmueller@novell.com --- Comment #2 from Ruediger Oertel <ro@novell.com> 2010-05-17 14:02:17 UTC --- in parts this may be a duplicate of bnc#423717 Dirk: is rpmlint already checking all relevant cases so I can take this out of brp-check-suse and not get this type of bugs any more ... ? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=571819 https://bugzilla.novell.com/show_bug.cgi?id=571819#c3 Ruediger Oertel <ro@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |RESOLVED InfoProvider|dmueller@suse.com | Resolution| |FIXED --- Comment #3 from Ruediger Oertel <ro@suse.com> 2012-03-19 11:57:55 UTC --- should be fixed with this one: Fri Mar 9 21:56:04 UTC 2012 - dimstar@opensuse.org - Add brp-check-xdg-menus.patch: Accept all icons specified in icon naming spec. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com