[Bug 503351] New: Change text color in a search field of visited pages in Firefox
http://bugzilla.novell.com/show_bug.cgi?id=503351 Summary: Change text color in a search field of visited pages in Firefox Classification: openSUSE Product: openSUSE 11.2 Version: Factory Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: GNOME AssignedTo: bnc-team-gnome@forge.provo.novell.com ReportedBy: rastislav.krupansky@gmail.com QAContact: qa@suse.de Found By: --- Created an attachment (id=291800) --> (http://bugzilla.novell.com/attachment.cgi?id=291800) screenshot User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; sk; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5 Hi gus, if you really want to use dark theme Sonar for openSUSE 11.2 (i don´t like it, i hope you´ll change decission;-)), please at least change blue text color in search field of visited pages for Firefox. That´s terrible, i can´t see very well text. Thanks a lot. Attached snapshot. Reproducible: Always Steps to Reproduce: 1. 2. 3. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User vuntz@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c1 Vincent Untz <vuntz@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P3 - Medium CC| |vuntz@novell.com AssignedTo|bnc-team-gnome@forge.provo. |jimmac@novell.com |novell.com | Severity|Normal |Major --- Comment #1 from Vincent Untz <vuntz@novell.com> 2009-05-15 02:56:31 MDT --- Yeah, that's the worst issue I have with the theme too. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 Jakub Steiner <jimmac@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User vuntz@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c2 Vincent Untz <vuntz@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wolfgang@rosenauer.org --- Comment #2 from Vincent Untz <vuntz@novell.com> 2009-05-15 06:18:27 MDT --- So, to me, the bug is that Firefox uses GtkMenu style for the awesomebar, while it should use something that behaves like GtkEntryCompletion (which seems to use the GtkTreeView style). Wolfgang: do you know if this is something that we could easily change? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User wolfgang@rosenauer.org added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c3 --- Comment #3 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2009-05-15 06:37:43 MDT --- We can probably change it but if it's easy is not always clear with Mozilla's trademark policy. But we should discuss upstream what to do. Is that Firefox 3.5 only (as I think the blue links came only with that)? I'll raise it with upstream people. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User vuntz@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c4 --- Comment #4 from Vincent Untz <vuntz@novell.com> 2009-05-15 06:52:15 MDT --- (In reply to comment #3)
We can probably change it but if it's easy is not always clear with Mozilla's trademark policy. But we should discuss upstream what to do. Is that Firefox 3.5 only (as I think the blue links came only with that)?
Hrm, I don't have Firefox 3.0 anymore ;-) But even if the links aren't blue there, I think that for consistency reasons, Firefox is doing it wrong if the background is not the same as GtkEntryCompletion background.
I'll raise it with upstream people.
Cool, thanks! -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User jimmac@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c5 --- Comment #5 from Jakub Steiner <jimmac@novell.com> 2009-06-04 06:17:23 MDT --- Created an attachment (id=296214) --> (http://bugzilla.novell.com/attachment.cgi?id=296214) light menus I was aiming to work around th issue by having the standard light background/dark text combination for menus while keeping menubar white text on dark background. Sadly things are probably nested differently in firefox and the menubar style isn't applied there. Any hints how to solve this? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User wolfgang@rosenauer.org added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c6 --- Comment #6 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2009-06-04 06:32:47 MDT --- This is the best fitting upstream bug about it: https://bugzilla.mozilla.org/show_bug.cgi?id=478632 I've searched how the skinning is done in Firefox because I never had to do with it before but was distracted again. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User jimmac@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c7 --- Comment #7 from Jakub Steiner <jimmac@novell.com> 2009-06-16 12:57:05 MDT --- Created an attachment (id=298509) --> (http://bugzilla.novell.com/attachment.cgi?id=298509) User Chrome addressing theming issues with the awesomebar This is the user chrome that ships with shiki colors which suffers from similar issues (Sonar is a derived theme). The fix seems to work fine regardless of the gtk theme I tested so if this isn't done upstream we could do this globally for our Firefox packages at least. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User rastislav.krupansky@gmail.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c9 --- Comment #9 from Rastislav Krupansky <rastislav.krupansky@gmail.com> 2009-09-27 12:32:30 MDT --- I am just trying Factory LiveCD, build 0300 and no progress here. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User jimmac@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c10 Jakub Steiner <jimmac@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|jimmac@novell.com |bnc-team-gnome@forge.provo. | |novell.com --- Comment #10 from Jakub Steiner <jimmac@novell.com> 2009-09-28 03:51:40 MDT ---
From what I've tried the style change doesn't have any visible regressions on other themes. We should apply the changes in the attached chrome.
-- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User vuntz@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c11 Vincent Untz <vuntz@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aj@novell.com --- Comment #11 from Vincent Untz <vuntz@novell.com> 2009-09-29 08:44:49 MDT --- *** Bug 542493 has been marked as a duplicate of this bug. *** http://bugzilla.novell.com/show_bug.cgi?id=542493 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User vuntz@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c12 Vincent Untz <vuntz@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwhiteley@novell.com --- Comment #12 from Vincent Untz <vuntz@novell.com> 2009-09-29 10:02:18 MDT --- *** Bug 541255 has been marked as a duplicate of this bug. *** http://bugzilla.novell.com/show_bug.cgi?id=541255 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User wolfgang@rosenauer.org added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c13 Wolfgang Rosenauer <wolfgang@rosenauer.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Info Provider| |jimmac@novell.com --- Comment #13 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2009-10-01 13:59:50 MDT --- Applying a userChrome wouldn't work for existing profiles. The changes should be applied to the default CSS. AFAIK that is http://mxr.mozilla.org/mozilla1.9.1/source/browser/themes/gnomestripe/browse... Jakub, could you please create a patch against that file and attach it here? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User jimmac@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c14 Jakub Steiner <jimmac@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jimmac@novell.com --- Comment #14 from Jakub Steiner <jimmac@novell.com> 2009-10-02 05:32:37 MDT --- Is that browser.css inside /usr/lib/firefox/chrome/browser.jar? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User wolfgang@rosenauer.org added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c15 --- Comment #15 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2009-10-02 05:45:21 MDT --- Hmm, there are actually two browser.css files. 1. in browser.jar 2. in classic.jar classic.jar is the default theme. So switching to another theme would disable changes there. browser.jar is usually theme-independent. As I'm not a themeing expert I'm not sure which one needs to be changed but I'd guess the general one if that makes sense to you from the contents. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User jimmac@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c16 --- Comment #16 from Jakub Steiner <jimmac@novell.com> 2009-10-02 05:51:00 MDT --- The described issues are valid for other themes that use light widgets but have dark menus with light text, such as shiki. The patch doesn't seem to break any themes I tested so I think it's better to have this applied for all themes. Attaching a patch against browser.css in browser.jar. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User jimmac@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c17 Jakub Steiner <jimmac@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Info Provider|jimmac@novell.com | --- Comment #17 from Jakub Steiner <jimmac@novell.com> 2009-10-02 05:52:24 MDT --- Created an attachment (id=320799) --> (http://bugzilla.novell.com/attachment.cgi?id=320799) theming fixes for Sonar and other dark menu themes. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User jimmac@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c18 Jakub Steiner <jimmac@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #320799|0 |1 is obsolete| | --- Comment #18 from Jakub Steiner <jimmac@novell.com> 2009-10-02 05:54:24 MDT --- Created an attachment (id=320800) --> (http://bugzilla.novell.com/attachment.cgi?id=320800) d'oh. inverted the patch ;) -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User wolfgang@rosenauer.org added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c19 Wolfgang Rosenauer <wolfgang@rosenauer.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #19 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2009-10-02 15:01:43 MDT --- Committed to mozilla:Factory. Thanks for the patch. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 User vuntz@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=503351#c20 Vincent Untz <vuntz@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lnussel@novell.com --- Comment #20 from Vincent Untz <vuntz@novell.com> 2009-10-05 02:56:36 MDT --- *** Bug 544262 has been marked as a duplicate of this bug. *** http://bugzilla.novell.com/show_bug.cgi?id=544262 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 http://bugzilla.novell.com/show_bug.cgi?id=503351#c21 --- Comment #21 from Michael Schueller <schueller-berlin@gmx.de> 2009-12-08 10:12:50 UTC --- Created an attachment (id=331516) --> (http://bugzilla.novell.com/attachment.cgi?id=331516) with Patch the Noia eXtrem Theme -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 http://bugzilla.novell.com/show_bug.cgi?id=503351#c22 Michael Schueller <schueller-berlin@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |schueller-berlin@gmx.de Severity|Major |Critical --- Comment #22 from Michael Schueller <schueller-berlin@gmx.de> 2009-12-08 10:19:12 UTC --- (In reply to comment #10)
From what I've tried the style change doesn't have any visible regressions on other themes. We should apply the changes in the attached chrome.
Hello Jakub Unfortunately thats not true. The Patch has bad regressions on the Noia eXtreme Theme. As you can see in my attachment it looks like the adressbar was hacked. I have just tried it whitout the Patch, and the adressbar looks fine again. Greets Michael -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 http://bugzilla.novell.com/show_bug.cgi?id=503351#c23 --- Comment #23 from Michael Schueller <schueller-berlin@gmx.de> 2009-12-08 10:21:13 UTC --- Created an attachment (id=331517) --> (http://bugzilla.novell.com/attachment.cgi?id=331517) Noia eXtreme without Patch -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 http://bugzilla.novell.com/show_bug.cgi?id=503351#c24 --- Comment #24 from Wolfgang Rosenauer <wolfgang@rosenauer.org> 2009-12-08 10:24:11 UTC --- Please see bug 561027 -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 http://bugzilla.novell.com/show_bug.cgi?id=503351#c25 --- Comment #25 from Michael Schueller <schueller-berlin@gmx.de> 2009-12-08 10:44:40 UTC --- (In reply to comment #24)
Please see bug 561027
Thanks Wolfgang, have'nt seen this. Got the Bug Nr. from the Patch it self, so thats why i'm landed here ;-) Greets Michael -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
http://bugzilla.novell.com/show_bug.cgi?id=503351 http://bugzilla.novell.com/show_bug.cgi?id=503351#c26 --- Comment #26 from Bernhard Wiedemann <bwiedemann@suse.com> --- This is an autogenerated message for OBS integration: This bug (503351) was mentioned in https://build.opensuse.org/request/show/21627 Factory / MozillaFirefox -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com