https://bugzilla.novell.com/show_bug.cgi?id=768354 https://bugzilla.novell.com/show_bug.cgi?id=768354#c1 Cristian Rodríguez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |crrodriguez@opensuse.org Resolution| |FIXED --- Comment #1 from Cristian Rodríguez 2012-10-31 23:23:59 CLST --- Fixed in request id 139902. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=768354 https://bugzilla.novell.com/show_bug.cgi?id=768354#c3 Jean Delvare changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #3 from Jean Delvare 2012-11-02 09:15:33 UTC --- I would decline this request but apparently I am not allowed to do so. Thanks a lot for looking into this as I was never able to make time to do it myself. I see two issues with these changes though: * The dependency on systemd should be optional, otherwise the package is broken for anything older than openSUSE 12.1, including SLE11 SP2. * The sysv init script does more than loading the kernel modules and running "sensors -s", it also starts fancontrol if needed. So the current change introduces a regression for users which have fancontrol set up. I don't know if the lm_sensors unit should be modified to also start fancontrol, or if we want to split fancontrol to a separate systemd unit. The latter seems cleaner to me. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=768354 https://bugzilla.novell.com/show_bug.cgi?id=768354#c4 --- Comment #4 from Cristian Rodríguez 2012-11-02 09:48:44 CLST --- OK, I will add a fancontrol unit.. however this stuff is still pretty ugly. modprobe should not be called from systemd units.. kernel modules if any must be loaded by the programs that require them using libkmod.. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.novell.com/show_bug.cgi?id=768354 https://bugzilla.novell.com/show_bug.cgi?id=768354#c6 --- Comment #6 from Jean Delvare 2012-11-02 14:26:44 UTC --- I'm afraid you don't get to tell upstream how they should implement their software. If you think it is so easy to get hwmon drivers to be automatically loaded, go and implement it (good luck.) And if you think libsensors should be responsible for loading the drivers, go ahead and implement that. Never heard about libkmod though, openSUSE 12.1 doesn't even seem to have it. But my understanding is that the role of systemd is to integrate software as it exists, rather than to dictate how software should be written. Systemd probably has bad press enough as is without trying to go that route. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.