[Bug 238194] New: mlterm-2.9.3-42 : array subscript is above array bounds
https://bugzilla.novell.com/show_bug.cgi?id=238194 Summary: mlterm-2.9.3-42 : array subscript is above array bounds Product: openSUSE 10.3 Version: unspecified Platform: All OS/Version: SuSE Other Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de I just tried to compile package mlterm-2.9.3-42 with the new GNU compiler version 4.3 snapshot 20070119 The compiler said kik_time.c:308: warning: array subscript is above array bounds The source code is if( strcmp( wday , wdays[ count]) == 0 || but static char * wdays[] = { "Sunday" , "Monday" , "Tuesday" , "Wednesday" , "Thursday" , "Saturday" } ; and count has the value six on the last execution of the loop. Suggest code rework. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238194 mhorvath@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team- |mfabian@novell.com |screening@forge.provo.novell| |.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238194 mfabian@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |coolo@novell.com Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238194 ------- Comment #1 from dominique.leuenberger@tmf-group.com 2007-01-24 08:03 MST ------- The Error has even been quoted in this bug report. It lies in kik_time.c:24 static char * wdays[] = { "Sunday" , "Monday" , "Tuesday" , "Wednesday" , "Thursday" , "Saturday" } ; Correct would be: static char * wdays[] = { "Sunday" , "Monday" , "Tuesday" , "Wednesday" , "Thursday" , "Friday", "Saturday" } ; -> The most appreciated day (Friday) was missing in the list. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238194 ------- Comment #2 from dominique.leuenberger@tmf-group.com 2007-01-24 08:22 MST ------- error also reported upstream: http://sourceforge.net/tracker/index.php?func=detail&aid=1643625&group_id=40891&atid=429201 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238194 ------- Comment #3 from mfabian@novell.com 2007-01-24 13:31 MST ------- Created an attachment (id=114816) --> (https://bugzilla.novell.com/attachment.cgi?id=114816&action=view) bugzilla-238194-array-subscript-out-of-bounds.patch Good catch Dominique! Thank you very much. Here is the change as a patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238194 ------- Comment #4 from mfabian@novell.com 2007-01-24 13:34 MST ------- mlterm package updated to 2.9.4 pre with that patch added submitted to STABLE and to the openSUSE build service. ------------------------------------------------------------------- Wed Jan 24 20:53:59 CET 2007 - mfabian@suse.de - update to 2.9.3.20070123 (= 2.9.4 pre). - fix Bugzilla #238194. ------------------------------------------------------------------- -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
https://bugzilla.novell.com/show_bug.cgi?id=238194 mfabian@novell.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #5 from mfabian@novell.com 2007-01-24 13:47 MST ------- I committed the fix to upstream CVS. Closing this bug as FIXED. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
participants (1)
-
bugzilla_noreply＠novell.com