[Bug 432616] New: nspluginwrapper-0.9.91.5.99.20071225-21: ordered comparison of pointer with integer zero
https://bugzilla.novell.com/show_bug.cgi?id=432616 Summary: nspluginwrapper-0.9.91.5.99.20071225-21: ordered comparison of pointer with integer zero Product: openSUSE 11.1 Version: Factory Platform: All OS/Version: openSUSE 11.0 Status: NEW Severity: Normal Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: dcb314@hotmail.com QAContact: qa@suse.de Found By: --- I just tried to compile Suse Linux package nspluginwrapper-0.9.91.5.99.20071225-21 and the compiler said /usr/src/packages/BUILD/nspluginwrapper-0.9.91.6/src/npruntime.c:584: warning: ordered comparison of pointer with integer zero The source code is assert(npobj && npobj_info && npobj_info > 0); Suggest replace with assert(npobj && npobj_info && (npobj_info != 0)); -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=432616 Marcus Meissner <meissner@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.provo.novell.com |sbrabec@novell.com -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=432616 User sbrabec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=432616#c1 Stanislav Brabec <sbrabec@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #1 from Stanislav Brabec <sbrabec@novell.com> 2008-12-12 08:53:17 MST --- Logical value of "npobj_info && (npobj_info != 0)" is equal to "npobj_info". Fixed in Factory/11.2 and sent upstream. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=432616 User sbrabec@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=432616#c2 --- Comment #2 from Stanislav Brabec <sbrabec@novell.com> 2008-12-15 07:15:02 MST --- Not correct. Here is a reply from Gwenole Beauchesne. Resubmitting both issues. Hi, Le 12 déc. 08 à 16:52, Stanislav Brabec a écrit :
Here is a small fix for:
/usr/src/packages/BUILD/nspluginwrapper-1.1.10/src/npruntime.c:814: warning: ordered comparison of pointer with integer zero
Thanks for spotting this. Actually, my fingers got interrupted somehow as the test should have been npobj_info->npobj_id > 0. Anyway, this is just internal checking, and should not be triggered. BTW, SunStudio compilers also caught a similar mix-up. I have attached a patch from SVN. Regards, Gwenole. Index: src/npw-wrapper.c =================================================================== --- src/npw-wrapper.c (revision 820) +++ src/npw-wrapper.c (revision 821) @@ -3371,7 +3371,7 @@ // Consume the whole line, we can't see our tags here while (fgets(line, sizeof(line), viewer_fp)) { len = strlen(line); - if (line > 0 && line[len - 1] == '\n') + if (len > 0 && line[len - 1] == '\n') break; } continue; -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com