http://bugzilla.novell.com/show_bug.cgi?id=536778 User vuntz@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=536778#c1 Vincent Untz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO CC| |vuntz@novell.com Info Provider| |stshaw@novell.com --- Comment #1 from Vincent Untz 2009-09-04 01:57:54 MDT --- Stephen, did you solve all those issues? I think you had them, so you might remember what was wrong. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=536778 User vuntz@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=536778#c3 Vincent Untz changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P2 - High CC| |captain.magnus@opensuse.org | |, sreeves@novell.com Severity|Normal |Major --- Comment #3 from Vincent Untz 2009-09-04 02:45:37 MDT --- cc'ing Scott and Magnus: I can't really help here until Monday, but if it's a real issue affecting everybody, we should try to get this fixed before Monday to not release the next milestone with this issue. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=536778 User vuntz@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=536778#c5 --- Comment #5 from Vincent Untz 2009-09-04 03:17:19 MDT --- My guess is that it could be caused by the gnome-main-menu-bnc187879-clear-recent-files.diff patch in gnome-main-menu and libslab-bnc187879-clear-recent-files.patch patch in libslab. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=536778 User mxwu@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=536778#c7 Mingxi Wu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dliang@novell.com, | |mxwu@novell.com --- Comment #7 from Mingxi Wu 2009-09-04 11:11:40 MDT --- David, see comment #5, maybe there is a bug in your patch. Do you have time to look at it? -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=536778 User mxwu@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=536778#c9 --- Comment #9 from Mingxi Wu 2009-09-04 13:29:45 MDT --- Created an attachment (id=316861) --> (http://bugzilla.novell.com/attachment.cgi?id=316861) patch -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=536778 User dominique.leuenberger@tmf-group.com added comment http://bugzilla.novell.com/show_bug.cgi?id=536778#c11 --- Comment #11 from Dominique Leuenberger 2009-09-05 09:11:00 MDT --- A test build with this patch on my system resolves the issue and the Favorites do show up again. Added it in my branch and SRed it: Request to submit (sri19995): home:dimstar:branches:GNOME:Factory/libslab -> GNOME:Factory/libslab Source revision: 2 Message: The patch from bnc536778 fixes the showing of favorites. This needs to be pushed to oS:F asap State: new 2009-09-05T17:01:15 dimstar Comment: None -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=536778 User mxwu@novell.com added comment http://bugzilla.novell.com/show_bug.cgi?id=536778#c13 --- Comment #13 from Mingxi Wu 2009-09-07 02:40:27 MDT --- (In reply to comment #12)

Thanks for debugging and patching this. The patch is fine for the quick fix for the M7 deadline but for long term the patch goes the wrong way. It makes the low level library depend on explicit knowledge of a particular upper layer app that uses it. What needs to happen is something like bookmark_agent_get_instance() needs to be modified to take an additional parameter that is the calling apps directory prefix.

Agree. I found there are a lot of work to remove the dependency of gnome-main-menu, eg gconf entries, so I've just done a quick fix here. If upstream fix this before GNOME 2.28 release, maybe we can use it in 11.2. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.novell.com/show_bug.cgi?id=536778 http://bugzilla.novell.com/show_bug.cgi?id=536778#c15 --- Comment #15 from Bernhard Wiedemann --- This is an autogenerated message for OBS integration: This bug (536778) was mentioned in https://build.opensuse.org/request/show/20045 Factory / libslab -- You are receiving this mail because: You are on the CC list for the bug.