[Bug 757746] New: grub2-probe fails on probing mount-by device names
https://bugzilla.novell.com/show_bug.cgi?id=757746 https://bugzilla.novell.com/show_bug.cgi?id=757746#c0 Summary: grub2-probe fails on probing mount-by device names Classification: openSUSE Product: openSUSE 12.2 Version: Milestone 3 Platform: x86-64 OS/Version: openSUSE 12.2 Status: NEW Severity: Major Priority: P5 - None Component: Bootloader AssignedTo: mchang@suse.com ReportedBy: mchang@suse.com QAContact: jsrain@suse.com CC: ug@suse.com Found By: Development Blocker: --- When testing AutoYaST with Grub2, I found that if I specify <boot_custom>/dev/sda<boot_custom> in autoyast's profile, the install ends up with a error message: "grub2-probe: error: cannot find a GRUB drive for /dev/disk/by-id/ata-WDC_WD1600BEKT-60V5T1_WD-WXK0A69Y4761. Check your device.map" In yast2-bootloader, the custom boot device is converted to the device names indicated by "mount-by". I don't know the rationale so better don't try to tamper with names to use ordinary names (like /dev/sda) .. This is a bug of grub2 indeed, I can reproduce easily on any machine with commands like this $grub2-probe --target=drive --device /dev/disk/by-id/ata-WDC_WD1600BEKT-60V5T1_WD-WXK0A69Y4761 Actual Result: "grub2-probe: error: cannot find a GRUB drive for /dev/disk/by-id/ata-WDC_WD1600BEKT-60V5T1_WD-WXK0A69Y4761. Check your device.map" Expected Result (hd0) The real fix is to fix Grub2 and not yast bootloader's convention. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=757746 https://bugzilla.novell.com/show_bug.cgi?id=757746#c1 --- Comment #1 from Michael Chang <mchang@suse.com> 2012-04-18 11:33:49 UTC --- Just did a quick check on Fedora 16, things work as expected. $grub2-probe --target=drive --device /dev/disk-by-id/ata-Hitachi_HTS727550A9E364_J33B0084GPJ3JB (hd0) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=757746 https://bugzilla.novell.com/show_bug.cgi?id=757746#c2 --- Comment #2 from Michael Chang <mchang@suse.com> 2012-04-20 11:33:43 UTC --- Created an attachment (id=487169) --> (http://bugzilla.novell.com/attachment.cgi?id=487169) use_kernel_device_name_in_device_is_wholedisk.patch -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=757746 https://bugzilla.novell.com/show_bug.cgi?id=757746#c3 --- Comment #3 from Michael Chang <mchang@suse.com> 2012-04-20 11:39:40 UTC --- Tested above patch works for me. The method used to determine the whole disk is by it's name without numeric character end, but this may be wrong for the by-(id|uuid|path) names as they are not necessary ended without numeric character. For instance, my disk was named "/dev/disk/by-id/ata-WDC_WD1600BEKT-60V5T1_WD-WXK0A69Y4761". The fix is use resolved link to kernel device names (like /dev/sda) instead of these alias names. Btw test fedora also fail if by-id name ends with number character. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=757746 https://bugzilla.novell.com/show_bug.cgi?id=757746#c4 --- Comment #4 from Michael Chang <mchang@suse.com> 2012-04-20 11:44:36 UTC --- Patch is sent to upstream for review. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=757746 https://bugzilla.novell.com/show_bug.cgi?id=757746#c5 --- Comment #5 from Michael Chang <mchang@suse.com> 2012-04-24 08:44:27 UTC --- Created an attachment (id=487661) --> (http://bugzilla.novell.com/attachment.cgi?id=487661) grub2-probe-disk-mountby.patch Patch backport from upstream rev 4234 that has been verified to fix the issue. ------------------------------------------------------------ revno: 4234 committer: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com> branch nick: grub timestamp: Sat 2012-04-21 16:42:28 +0200 message: Fix and unify wholedisk detection. * util/getroot.c (convert_system_partition_to_system_disk): New argument is_part. All users updated. (device_is_wholedisk): Removed. (grub_util_biosdisk_get_grub_dev): Use is_part. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=757746 https://bugzilla.novell.com/show_bug.cgi?id=757746#c6 --- Comment #6 from Bernhard Wiedemann <bwiedemann@suse.com> 2012-05-02 13:00:09 CEST --- This is an autogenerated message for OBS integration: This bug (757746) was mentioned in https://build.opensuse.org/request/show/116247 Factory / grub2 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=757746 https://bugzilla.novell.com/show_bug.cgi?id=757746#c7 Michael Chang <mchang@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #7 from Michael Chang <mchang@suse.com> 2012-07-05 06:40:54 UTC --- As the fix is released I'd like to close it. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com