[Bug 838515] New: dkimproxy package has broken init script and is incorrectly packaged
https://bugzilla.novell.com/show_bug.cgi?id=838515 https://bugzilla.novell.com/show_bug.cgi?id=838515#c0 Summary: dkimproxy package has broken init script and is incorrectly packaged Classification: openSUSE Product: openSUSE 12.3 Version: Final Platform: x86-64 OS/Version: openSUSE 12.3 Status: NEW Severity: Minor Priority: P5 - None Component: Other AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: sum.notify@gmail.com QAContact: qa-bugs@suse.de Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 There are multiple problems with thee dkimproxy package that's in the stock openSUSE repository: 1) /etc/init.d/dkimproxy (line 87/88) test -f $DKIMPROXY_IN_CFG && $0 start-in || exit 0 test -f $DKIMPROXY_OUT_CFG && $0 start-out || exit 0 The idea behind this is to only start the in and out proxies if the configuration files exist. The "|| exit 0" is wrong an unnecessary. This means if there is no in-proxy configuration file, it won't even check to see if the out-proxy should start. It should be the following: test -f $DKIMPROXY_IN_CFG && $0 start-in test -f $DKIMPROXY_OUT_CFG && $0 start-out 2) The configuration file locations at the top need to be moved to /etc and should look (more) like the following: DKIMPROXY_IN_CFG="/etc/dkim/dkimproxy_in.conf" DKIMPROXY_OUT_CFG="/etc/dkim/proxy_out.conf" 3) And this gets us to the big problem. The entire layout for the package is bad. There is a /usr/share/dkimproxy/{etc,share,var}. The share directory shouldn't be replicated/nested, the init script should point to the real /var for the PID location and the init script should also reference /etc over the one in share. Reproducible: Always Steps to Reproduce: 1. 2. 3. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=838515
https://bugzilla.novell.com/show_bug.cgi?id=838515#c
FeiXiang Zhang
participants (1)
-
bugzilla_noreply@novell.com